Update scripts to make the replace work

Author: Riccardo Cipolleschi

.gitignore

@@ -21,6 +21,7 @@ DerivedData
 *.xcuserstate
 project.xcworkspace
 **/.xcode.env.local
+/poackages/react-native/sdks/downloads/
 
 # Gradle
 /build/

packages/react-native/sdks/hermes-engine/hermes-engine.podspec

@@ -11,7 +11,6 @@ react_native_path = File.join(__dir__, "..", "..")
 # package.json
 package = JSON.parse(File.read(File.join(react_native_path, "package.json")))
 version = package['version']
-version = "0.72.0-rc.5"
 
 # sdks/.hermesversion
 hermestag_file = File.join(react_native_path, "sdks", ".hermesversion")
@@ -65,11 +64,11 @@ Pod::Spec.new do |spec|
     # test something specific for that tarball.
     if source[:http].include?('https://repo1.maven.org/')
       spec.script_phase = {
-        :name => "[Hermes] Download Hermes for the right configuration, if needed",
+        :name => "[Hermes] Replace Hermes for the right configuration, if needed",
         :execution_position => :before_compile,
         :script => <<-EOS
         . "$REACT_NATIVE_PATH/scripts/xcode/with-environment.sh"
-        "$NODE_BINARY" "$REACT_NATIVE_PATH/sdks/hermes-engine/utils/replace_hermes_version.js" -c "$CONFIGURATION" -r "#{version}"
+        "$NODE_BINARY" "$REACT_NATIVE_PATH/sdks/hermes-engine/utils/replace_hermes_version.js" -c "$CONFIGURATION" -r "#{version}" -p "$REACT_NATIVE_PATH"
         EOS
       }
     end

packages/react-native/sdks/hermes-engine/hermes-utils.rb

@@ -33,25 +33,25 @@ def abort_if_invalid_tarball_provided!()
 def compute_hermes_source(build_from_source, hermestag_file, git, version, react_native_path)
     source = {}
 
-    # if ENV.has_key?('HERMES_ENGINE_TARBALL_PATH')
-    #     use_tarball(source)
-    # elsif ENV.has_key?('HERMES_COMMIT')
-    #     build_hermes_from_commit(source, git, ENV['HERMES_COMMIT'])
-    # elsif build_from_source
-    #     if File.exist?(hermestag_file)
-    #         build_from_tagfile(source, git, hermestag_file)
-    #     else
-    #         build_hermes_from_source(source, git)
-    #     end
-    # elsif hermes_artifact_exists(release_tarball_url(version, :debug))
+    if ENV.has_key?('HERMES_ENGINE_TARBALL_PATH')
+        use_tarball(source)
+    elsif ENV.has_key?('HERMES_COMMIT')
+        build_hermes_from_commit(source, git, ENV['HERMES_COMMIT'])
+    elsif build_from_source
+        if File.exist?(hermestag_file)
+            build_from_tagfile(source, git, hermestag_file)
+        else
+            build_hermes_from_source(source, git)
+        end
+    elsif hermes_artifact_exists(release_tarball_url(version, :debug))
         use_release_tarball(source, version, :debug)
         download_stable_hermes(react_native_path, version, :debug)
         download_stable_hermes(react_native_path, version, :release)
-    # elsif hermes_artifact_exists(nightly_tarball_url(version).gsub("\\", ""))
-    #     use_nightly_tarball(source, react_native_path, version)
-    # else
-    #     build_hermes_from_source(source, git)
-    # end
+    elsif hermes_artifact_exists(nightly_tarball_url(version).gsub("\\", ""))
+        use_nightly_tarball(source, react_native_path, version)
+    else
+        build_hermes_from_source(source, git)
+    end
 
     return source
 end

packages/react-native/sdks/hermes-engine/utils/replace_hermes_version.js

@@ -33,7 +33,7 @@ function shouldReplaceHermesConfiguration(configuration) {
 
   if (fileExists) {
     console.log(`Found ${LAST_BUILD_FILENAME} file`);
-    const oldConfiguration = fs.readFileSync(LAST_BUILD_FILENAME);
+    const oldConfiguration = fs.readFileSync(LAST_BUILD_FILENAME).toString();
     if (oldConfiguration === configuration) {
       console.log('No need to download a new build of Hermes!');
       return false;
@@ -54,7 +54,7 @@ function shouldReplaceHermesConfiguration(configuration) {
 function replaceHermesConfiguration(configuration, version, reactNativePath) {
   const tarballURLPath = `${reactNativePath}/sdks/downloads/hermes-ios-${version}-${configuration}.tar.gz`;
 
-  const finalLocation = 'Pods/hermes-engine';
+  const finalLocation = 'hermes-engine';
   console.log('Preparing the final location');
   fs.rmSync(finalLocation, {force: true, recursive: true});
   fs.mkdirSync(finalLocation, {recursive: true});
@@ -77,6 +77,7 @@ function main(configuration, version, reactNativePath) {
 
   replaceHermesConfiguration(configuration, version, reactNativePath);
   updateLastBuildConfiguration(configuration);
+  console.log('Done replacing hermes-engine');
 }
 
 // This script is executed in the Pods folder, which is usually not synched to Github, so it should be ok
@@ -101,5 +102,4 @@ const configuration = argv.configuration;
 const version = argv.reactNativeVersion;
 const reactNativePath = argv.reactNativePath;
 
-throw new Error(`React native path is: ${reactNativePath}`);
 main(configuration, version, reactNativePath);