Skip to content

Commit 4b6b706

Browse files
hoxyqfacebook-github-bot
authored andcommitted
Update paths in a new setup to fix nightlies (#36535)
Summary: Pull Request resolved: #36535 Changelog: [Internal] - We should be copying `/packages/react-native/package.json`, not root `package.json` - Updating CircleCI config's target directory where hermes artifacts should be copied Reviewed By: cortinico Differential Revision: D44214309 fbshipit-source-id: af84897df3931c6a2d6a902b33c71b665c3fcefc
1 parent c9db994 commit 4b6b706

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.circleci/config.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1510,9 +1510,9 @@ jobs:
15101510
15111511
cp -r $HERMES_WS_DIR/win64-bin/* ./packages/react-native/sdks/hermesc/win64-bin/.
15121512
cp -r $HERMES_WS_DIR/linux64-bin/* ./packages/react-native/sdks/hermesc/linux64-bin/.
1513-
mkdir -p ./ReactAndroid/external-artifacts/artifacts/
1514-
cp $HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-debug.tar.gz ./ReactAndroid/external-artifacts/artifacts/hermes-ios-debug.tar.gz
1515-
cp $HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-release.tar.gz ./ReactAndroid/external-artifacts/artifacts/hermes-ios-release.tar.gz
1513+
mkdir -p ./packages/react-native/ReactAndroid/external-artifacts/artifacts/
1514+
cp $HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-debug.tar.gz ./packages/react-native/ReactAndroid/external-artifacts/artifacts/hermes-ios-debug.tar.gz
1515+
cp $HERMES_WS_DIR/hermes-runtime-darwin/hermes-ios-release.tar.gz ./packages/react-native/ReactAndroid/external-artifacts/artifacts/hermes-ios-release.tar.gz
15161516
15171517
- run_yarn
15181518
- download_gradle_dependencies

scripts/set-rn-version.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,10 @@ const tmpVersioningFolder = fs.mkdtempSync(
6161
echo(`The temp versioning folder is ${tmpVersioningFolder}`);
6262

6363
saveFiles(
64-
['package.json', 'packages/react-native/template/package.json'],
64+
[
65+
'packages/react-native/package.json',
66+
'packages/react-native/template/package.json',
67+
],
6568
tmpVersioningFolder,
6669
);
6770

0 commit comments

Comments
 (0)