Skip to content

Commit 1acca01

Browse files
gabelevisahrens
authored andcommitted
[Flow] Fix or suppress react-native github errors for Flow v0.12.0
1 parent 78db5ca commit 1acca01

File tree

12 files changed

+37
-22
lines changed

12 files changed

+37
-22
lines changed

Examples/Movies/MovieCell.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,14 @@ var MovieCell = React.createClass({
3434
var criticsScore = this.props.movie.ratings.critics_score;
3535
return (
3636
<View>
37-
<TouchableHighlight
37+
<TouchableHighlight
3838
onPress={this.props.onSelect}
3939
onShowUnderlay={this.props.onHighlight}
4040
onHideUnderlay={this.props.onUnhighlight}>
4141
<View style={styles.row}>
42+
{/* $FlowIssue #7363964 - There's a bug in Flow where you cannot
43+
* omit a property or set it to undefined if it's inside a shape,
44+
* even if it isn't required */}
4245
<Image
4346
source={getImageSource(this.props.movie, 'det')}
4447
style={styles.cellImage}

Examples/Movies/MovieScreen.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ var MovieScreen = React.createClass({
3434
return (
3535
<ScrollView contentContainerStyle={styles.contentContainer}>
3636
<View style={styles.mainSection}>
37+
{/* $FlowIssue #7363964 - There's a bug in Flow where you cannot
38+
* omit a property or set it to undefined if it's inside a shape,
39+
* even if it isn't required */}
3740
<Image
3841
source={getImageSource(this.props.movie, 'det')}
3942
style={styles.detailsImage}

Examples/Movies/MoviesApp.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ var SearchScreen = require('./SearchScreen');
2828
var MoviesApp = React.createClass({
2929
render: function() {
3030
return (
31+
/* $FlowIssue #7363964 - There's a bug in Flow where you cannot
32+
* omit a property or set it to undefined if it's inside a shape,
33+
* even if it isn't required */
3134
<NavigatorIOS
3235
style={styles.container}
3336
initialRoute={{

Examples/UIExplorer/MapViewExample.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,15 @@ var MapViewExample = React.createClass({
159159
render() {
160160
return (
161161
<View>
162+
{/* $FlowIssue #7363964 - There's a bug in Flow where you cannot
163+
* omit a property or set it to undefined if it's inside a shape,
164+
* even if it isn't required */}
162165
<MapView
163166
style={styles.map}
164167
onRegionChange={this._onRegionChange}
165168
onRegionChangeComplete={this._onRegionChangeComplete}
166-
region={this.state.mapRegion}
167-
annotations={this.state.annotations}
169+
region={this.state.mapRegion || undefined}
170+
annotations={this.state.annotations || undefined}
168171
/>
169172
<MapRegionInput
170173
onChange={this._onRegionInputChanged}

Examples/UIExplorer/UIExplorerApp.ios.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ var UIExplorerApp = React.createClass({
4444
);
4545
}
4646
return (
47+
/* $FlowIssue #7363964 - There's a bug in Flow where you cannot
48+
* omit a property or set it to undefined if it's inside a shape,
49+
* even if it isn't required */
4750
<NavigatorIOS
4851
style={styles.container}
4952
initialRoute={{

Examples/UIExplorer/UIExplorerPage.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ var UIExplorerPage = React.createClass({
3737
var ContentWrapper;
3838
var wrapperProps = {};
3939
if (this.props.noScroll) {
40-
ContentWrapper = View;
40+
ContentWrapper = (View: ReactClass<any, any, any>);
4141
} else {
42-
ContentWrapper = ScrollView;
42+
ContentWrapper = (ScrollView: ReactClass<any, any, any>);
4343
wrapperProps.keyboardShouldPersistTaps = true;
4444
wrapperProps.keyboardDismissMode = 'interactive';
4545
}

Libraries/Components/ScrollView/ScrollView.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ var ScrollView = React.createClass({
299299
onResponderRelease: this.scrollResponderHandleResponderRelease,
300300
onResponderReject: this.scrollResponderHandleResponderReject,
301301
};
302-
302+
303303
var ScrollViewClass;
304304
if (Platform.OS === 'ios') {
305305
ScrollViewClass = RCTScrollView;

Libraries/Network/NetInfo.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ var NetInfo = {
147147
eventName: ChangeEventName,
148148
handler: Function
149149
): void {
150-
_subscriptions[handler] = RCTDeviceEventEmitter.addListener(
150+
_subscriptions[String(handler)] = RCTDeviceEventEmitter.addListener(
151151
DEVICE_REACHABILITY_EVENT,
152152
(appStateData) => {
153153
handler(appStateData.network_reachability);
@@ -159,11 +159,11 @@ var NetInfo = {
159159
eventName: ChangeEventName,
160160
handler: Function
161161
): void {
162-
if (!_subscriptions[handler]) {
162+
if (!_subscriptions[String(handler)]) {
163163
return;
164164
}
165-
_subscriptions[handler].remove();
166-
_subscriptions[handler] = null;
165+
_subscriptions[String(handler)].remove();
166+
_subscriptions[String(handler)] = null;
167167
},
168168

169169
fetch: function(): Promise {
@@ -204,12 +204,12 @@ NetInfo.isConnected = {
204204
eventName: ChangeEventName,
205205
handler: Function
206206
): void {
207-
_isConnectedSubscriptions[handler] = (connection) => {
207+
_isConnectedSubscriptions[String(handler)] = (connection) => {
208208
handler(_isConnected(connection));
209209
};
210210
NetInfo.addEventListener(
211211
eventName,
212-
_isConnectedSubscriptions[handler]
212+
_isConnectedSubscriptions[String(handler)]
213213
);
214214
},
215215

@@ -219,7 +219,7 @@ NetInfo.isConnected = {
219219
): void {
220220
NetInfo.removeEventListener(
221221
eventName,
222-
_isConnectedSubscriptions[handler]
222+
_isConnectedSubscriptions[String(handler)]
223223
);
224224
},
225225

Libraries/PushNotificationIOS/PushNotificationIOS.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,14 @@ class PushNotificationIOS {
6666
'PushNotificationIOS only supports `notification` and `register` events'
6767
);
6868
if (type === 'notification') {
69-
_notifHandlers[handler] = RCTDeviceEventEmitter.addListener(
69+
_notifHandlers[String(handler)] = RCTDeviceEventEmitter.addListener(
7070
DEVICE_NOTIF_EVENT,
7171
(notifData) => {
7272
handler(new PushNotificationIOS(notifData));
7373
}
7474
);
7575
} else if (type === 'register') {
76-
_notifHandlers[handler] = RCTDeviceEventEmitter.addListener(
76+
_notifHandlers[String(handler)] = RCTDeviceEventEmitter.addListener(
7777
NOTIF_REGISTER_EVENT,
7878
(registrationInfo) => {
7979
handler(registrationInfo.deviceToken);
@@ -143,11 +143,11 @@ class PushNotificationIOS {
143143
type === 'notification' || type === 'register',
144144
'PushNotificationIOS only supports `notification` and `register` events'
145145
);
146-
if (!_notifHandlers[handler]) {
146+
if (!_notifHandlers[String(handler)]) {
147147
return;
148148
}
149-
_notifHandlers[handler].remove();
150-
_notifHandlers[handler] = null;
149+
_notifHandlers[String(handler)].remove();
150+
_notifHandlers[String(handler)] = null;
151151
}
152152

153153

Libraries/ReactIOS/InspectorOverlay/resolveBoxStyle.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
*
2121
* If none are set, returns false.
2222
*/
23-
function resolveBoxStyle(prefix: String, style: Object): ?Object {
23+
function resolveBoxStyle(prefix: string, style: Object): ?Object {
2424
var res = {};
2525
var subs = ['top', 'left', 'bottom', 'right'];
2626
var set = false;

0 commit comments

Comments
 (0)