Skip to content

Commit 833f2ff

Browse files
motiz88facebook-github-bot
authored andcommitted
Remove dev-mode Hermes bytecode experiment
Summary: Changelog: * **[Internal]**: Remove experimental `metro-hermes-compiler` package. * **[Fix]**: Remove spammy warning about a possible EventEmitter memory leak. Removes the `metro-hermes-compiler` package and associated support for compiling JS to bytecode within Metro. This code was part of an unreleased experiment to offload Hermes bytecode compilation in React Native to Metro. Reviewed By: robhogan Differential Revision: D43604706 fbshipit-source-id: a449a51435c3eecef42ff8e7951bebb4661aee9c
1 parent 8a43c11 commit 833f2ff

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+17
-1573
lines changed

packages/metro-hermes-compiler/.npmignore

Lines changed: 0 additions & 5 deletions
This file was deleted.

packages/metro-hermes-compiler/README.md

Lines changed: 0 additions & 18 deletions
This file was deleted.

packages/metro-hermes-compiler/package.json

Lines changed: 0 additions & 18 deletions
This file was deleted.

packages/metro-hermes-compiler/src/__tests__/index-test.js

Lines changed: 0 additions & 54 deletions
This file was deleted.

packages/metro-hermes-compiler/src/emhermesc.js

Lines changed: 0 additions & 31 deletions
This file was deleted.

packages/metro-hermes-compiler/src/emhermesc.js.flow

Lines changed: 0 additions & 59 deletions
This file was deleted.

packages/metro-hermes-compiler/src/index.js

Lines changed: 0 additions & 196 deletions
This file was deleted.

packages/metro-runtime/src/modules/types.flow.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,13 @@
1212
'use strict';
1313

1414
export type ModuleMap = $ReadOnlyArray<[number, string]>;
15-
export type BytecodeModuleMap = $ReadOnlyArray<[number, Array<Buffer>]>;
1615

1716
export type Bundle = {
1817
+modules: ModuleMap,
1918
+post: string,
2019
+pre: string,
2120
};
2221

23-
export type BytecodeBundle = {
24-
+modules: BytecodeModuleMap,
25-
+post: Array<Buffer>,
26-
+pre: Array<Buffer>,
27-
};
28-
2922
export type DeltaBundle = {
3023
+added: ModuleMap,
3124
+modified: ModuleMap,

packages/metro-transform-worker/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"metro-babel-transformer": "0.76.0",
2323
"metro-cache": "0.76.0",
2424
"metro-cache-key": "0.76.0",
25-
"metro-hermes-compiler": "0.76.0",
2625
"metro-source-map": "0.76.0",
2726
"metro-transform-plugins": "0.76.0",
2827
"nullthrows": "^1.1.1"

0 commit comments

Comments
 (0)