Skip to content

Commit 260125e

Browse files
tido64facebook-github-bot
authored andcommitted
feat!: use Terser's default for comments (#972)
Summary: By default, Terser keeps JSDoc-style comments that contain `license` or `preserve`: https://terser.org/docs/api-reference#format-options Note that this is potentially a breaking change as it may change the output bundle (increase in size). Pull Request resolved: #972 Test Plan: All current tests should pass. Reviewed By: motiz88 Differential Revision: D46591290 Pulled By: jacdebug fbshipit-source-id: a94fcd635a9ac2d0d87ddd0bf3fe82f0c6436c82
1 parent 166477e commit 260125e

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

packages/metro-config/src/__tests__/__snapshots__/loadConfig-test.js.snap

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ Object {
132132
},
133133
"output": Object {
134134
"ascii_only": true,
135-
"comments": false,
136135
"quote_style": 3,
137136
"wrap_iife": true,
138137
},
@@ -311,7 +310,6 @@ Object {
311310
},
312311
"output": Object {
313312
"ascii_only": true,
314-
"comments": false,
315313
"quote_style": 3,
316314
"wrap_iife": true,
317315
},
@@ -490,7 +488,6 @@ Object {
490488
},
491489
"output": Object {
492490
"ascii_only": true,
493-
"comments": false,
494491
"quote_style": 3,
495492
"wrap_iife": true,
496493
},
@@ -669,7 +666,6 @@ Object {
669666
},
670667
"output": Object {
671668
"ascii_only": true,
672-
"comments": false,
673669
"quote_style": 3,
674670
"wrap_iife": true,
675671
},

packages/metro-config/src/defaults/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ const getDefaultValues = (projectRoot: ?string): ConfigT => ({
112112
},
113113
output: {
114114
ascii_only: true,
115-
comments: false,
116115
quote_style: 3,
117116
wrap_iife: true,
118117
},

0 commit comments

Comments
 (0)