Hoist skip_proguard flag so it can be provided by the caller

Summary: This was the last property I had to hoist before making proguard run in the java_binary rule. While this isn't android-specific, it's not part of the java_binary rule properties, and the value of it does seem to be android-specific. We can always provide it via java_binary later if we need it there as well, since now it's just passed in rather than fetched from a context.

Reviewed By: hick209

Differential Revision: D72092338

fbshipit-source-id: 99ef3e5f5c3b5410f9d5acf9367f371d9f925a0b

Author: Travis-Meta

prelude/android/android_binary.bzl

@@ -150,6 +150,7 @@ def get_binary_info(ctx: AnalysisContext, use_proto_format: bool) -> AndroidBina
                 ctx.attrs.android_sdk_proguard_config,
                 android_toolchain.proguard_config,
                 android_toolchain.optimized_proguard_config,
+                ctx.attrs.skip_proguard,
             )
             materialized_artifacts.extend(proguard_output.proguard_artifacts)
             jars_to_owners = proguard_output.jars_to_owners

prelude/java/proguard.bzl

@@ -137,13 +137,14 @@ def get_proguard_output(
         additional_jars: list[Artifact],
         sdk_proguard_config_mode: str | None,
         sdk_proguard_config: Artifact | None,
-        sdk_optimized_proguard_config: Artifact | None) -> ProguardOutput:
+        sdk_optimized_proguard_config: Artifact | None,
+        skip_proguard: bool = False) -> ProguardOutput:
     proguard_configs = [packaging_dep.proguard_config for packaging_dep in java_packaging_deps if packaging_dep.proguard_config]
     if ctx.attrs.proguard_config:
         proguard_configs.append(ctx.attrs.proguard_config)
     proguard_configs.extend(additional_proguard_configs)
 
-    if ctx.attrs.skip_proguard:
+    if skip_proguard:
         input_jars_to_output_jars = {input_jar: input_jar for input_jar in input_jars.keys()}
         mapping = ctx.actions.write("proguard/mapping.txt", [])
         configuration = None
@@ -174,7 +175,7 @@ def get_proguard_output(
 
     command_line_args_file = ctx.actions.write("proguard/command-line.txt", command_line_args)
 
-    if ctx.attrs.skip_proguard:
+    if skip_proguard:
         return ProguardOutput(
             jars_to_owners = input_jars,
             proguard_configuration_output_file = None,