Delete dead cells code

Summary: Missed it in D87300266

Reviewed By: get9

Differential Revision: D87717943

fbshipit-source-id: ebbf1affc958c2f77fd1fcc9396364315b80897b

Author: JakobDegen

app/buck2_core/src/cells.rs

@@ -95,7 +95,6 @@ use std::fmt::Debug;
 use std::sync::Arc;
 
 use allocative::Allocative;
-use buck2_error::BuckErrorContext;
 use buck2_fs::paths::abs_path::AbsPath;
 use buck2_fs::paths::file_name::FileNameBuf;
 use dupe::Dupe;
@@ -457,27 +456,6 @@ impl CellResolver {
 
         CellResolver::new(instances, root_aliases).unwrap()
     }
-
-    pub(crate) fn resolve_path_crossing_cell_boundaries<'a>(
-        &self,
-        mut path: CellPathRef<'a>,
-    ) -> buck2_error::Result<CellPathRef<'a>> {
-        let mut rem: u32 = 1000;
-        loop {
-            // Sanity check. Should never happen.
-            rem = rem
-                .checked_sub(1)
-                .buck_error_context("Overflow computing cell boundaries")?;
-
-            let nested_cells = self.get(path.cell())?.nested_cells();
-            match nested_cells.matches_checked(path.path()) {
-                None => return Ok(path),
-                Some((_, new_cell_path)) => {
-                    path = new_cell_path;
-                }
-            }
-        }
-    }
 }
 
 #[cfg(test)]
@@ -570,90 +548,4 @@ mod tests {
 
         Ok(())
     }
-
-    #[test]
-    fn test_resolve_path_crossing_cell_boundaries() {
-        let cell_resolver = CellResolver::testing_with_names_and_paths(&[
-            (
-                CellName::testing_new("fbsource"),
-                CellRootPathBuf::testing_new(""),
-            ),
-            (
-                CellName::testing_new("fbcode"),
-                CellRootPathBuf::testing_new("fbcode"),
-            ),
-            (
-                CellName::testing_new("fbcode_macros"),
-                CellRootPathBuf::testing_new("fbcode/something/macros"),
-            ),
-        ]);
-        // Test starting with `fbsource//`.
-        assert_eq!(
-            CellPathRef::testing_new("fbsource//"),
-            cell_resolver
-                .resolve_path_crossing_cell_boundaries(CellPathRef::testing_new("fbsource//"))
-                .unwrap()
-        );
-        assert_eq!(
-            CellPathRef::testing_new("fbcode//"),
-            cell_resolver
-                .resolve_path_crossing_cell_boundaries(CellPathRef::testing_new("fbsource//fbcode"))
-                .unwrap()
-        );
-        assert_eq!(
-            CellPathRef::testing_new("fbcode//something"),
-            cell_resolver
-                .resolve_path_crossing_cell_boundaries(CellPathRef::testing_new(
-                    "fbsource//fbcode/something"
-                ))
-                .unwrap()
-        );
-        assert_eq!(
-            CellPathRef::testing_new("fbcode_macros//"),
-            cell_resolver
-                .resolve_path_crossing_cell_boundaries(CellPathRef::testing_new(
-                    "fbsource//fbcode/something/macros"
-                ))
-                .unwrap()
-        );
-        assert_eq!(
-            CellPathRef::testing_new("fbcode_macros//xx"),
-            cell_resolver
-                .resolve_path_crossing_cell_boundaries(CellPathRef::testing_new(
-                    "fbsource//fbcode/something/macros/xx"
-                ))
-                .unwrap()
-        );
-        // Now test starting with `fbcode//`.
-        assert_eq!(
-            CellPathRef::testing_new("fbcode//"),
-            cell_resolver
-                .resolve_path_crossing_cell_boundaries(CellPathRef::testing_new("fbcode//"))
-                .unwrap()
-        );
-        assert_eq!(
-            CellPathRef::testing_new("fbcode//something"),
-            cell_resolver
-                .resolve_path_crossing_cell_boundaries(CellPathRef::testing_new(
-                    "fbcode//something"
-                ))
-                .unwrap()
-        );
-        assert_eq!(
-            CellPathRef::testing_new("fbcode_macros//"),
-            cell_resolver
-                .resolve_path_crossing_cell_boundaries(CellPathRef::testing_new(
-                    "fbcode//something/macros"
-                ))
-                .unwrap()
-        );
-        assert_eq!(
-            CellPathRef::testing_new("fbcode_macros//xx"),
-            cell_resolver
-                .resolve_path_crossing_cell_boundaries(CellPathRef::testing_new(
-                    "fbcode//something/macros/xx"
-                ))
-                .unwrap()
-        );
-    }
 }

app/buck2_core/src/cells/nested.rs

@@ -10,7 +10,6 @@
 
 use allocative::Allocative;
 
-use crate::cells::cell_path::CellPathRef;
 use crate::cells::cell_root_path::CellRootPath;
 use crate::cells::name::CellName;
 use crate::cells::paths::CellRelativePath;
@@ -84,19 +83,6 @@ impl NestedCells {
         None
     }
 
-    pub(crate) fn matches_checked<'a, 'b>(
-        &'a self,
-        path: &'b CellRelativePath,
-    ) -> Option<(&'a CellRelativePath, CellPathRef<'b>)> {
-        self.matches(UncheckedCellRelativePath::new(path))
-            .map(|(cell_path, cell_name, rem)| {
-                (
-                    cell_path,
-                    CellPathRef::new(cell_name, CellRelativePath::unchecked_new(rem.as_str())),
-                )
-            })
-    }
-
     pub(crate) fn check_empty(&self) -> Option<CellName> {
         self.paths.first().map(|(_, cell_name)| *cell_name)
     }