Support custom line separators (#132)

Author: gastaldi

src/main/java/io/fabric8/maven/XMLFormat.java

@@ -30,10 +30,13 @@ public class XMLFormat {
 
     private final TextMode textMode;
 
+    private final String lineSeparator;
+
     private XMLFormat(Builder builder) {
         this.indent = builder.indent;
         this.insertLineBreakBetweenMajorSections = builder.insertLineBreakBetweenMajorSections;
         this.textMode = builder.textMode;
+        this.lineSeparator = builder.lineSeparator;
     }
 
     /**
@@ -90,7 +93,7 @@ XMLOutputter createXmlOutputter() {
         XMLOutputter xmlOutputter = new XMLOutputter();
         Format format = Format.getRawFormat();
         format.setIndent(indent);
-        format.setLineSeparator(LineSeparator.UNIX);
+        format.setLineSeparator(lineSeparator);
         format.setTextMode(Format.TextMode.valueOf(textMode.name()));
         if (insertLineBreakBetweenMajorSections) {
             // Insert line breaks between major sections
@@ -177,6 +180,8 @@ public static class Builder {
 
         private TextMode textMode = TextMode.TRIM;
 
+        private String lineSeparator = LineSeparator.UNIX.value();
+
         Builder() {
         }
 
@@ -199,6 +204,11 @@ public Builder textMode(TextMode textMode) {
             return this;
         }
 
+        public Builder lineSeparator(String lineSeparator) {
+            this.lineSeparator = lineSeparator;
+            return this;
+        }
+
         public XMLFormat build() {
             return new XMLFormat(this);
         }

src/test/approvals/io/fabric8/maven/MavenTest.should_support_no_line_separator.approved.txt

@@ -0,0 +1 @@
+<?xml version="1.0" encoding="UTF-8"?><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"><modelVersion>4.0.0</modelVersion></project>

src/test/approvals/io/fabric8/maven/MavenTest.should_use_line_separator.approved.txt

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+
+  <modelVersion>4.0.0</modelVersion>
+
+</project>
+

src/test/java/io/fabric8/maven/MavenTest.java

@@ -333,4 +333,20 @@ void should_write_attributes() throws Exception {
         Approvals.verify(sw.toString());
     }
 
+    @Test
+    void should_use_line_separator() {
+        Model model = Maven.newModel();
+        StringWriter sw = new StringWriter();
+        Maven.writeModel(model, sw, XMLFormat.builder().lineSeparator("\n\n").build());
+        Approvals.verify(sw.toString());
+    }
+
+    @Test
+    void should_support_no_line_separator() {
+        Model model = Maven.newModel();
+        StringWriter sw = new StringWriter();
+        Maven.writeModel(model, sw, XMLFormat.builder().lineSeparator(null).build());
+        Approvals.verify(sw.toString());
+    }
+
 }