Enable hermes debugger on all build variants (#42)

Kudo · gabrieldonadel · commit 84d7b341739d · 2025-08-27T13:02:56.000-03:00
diff --git a/packages/react-native/ReactCommon/jsinspector-modern/CMakeLists.txt b/packages/react-native/ReactCommon/jsinspector-modern/CMakeLists.txt
@@ -28,6 +28,9 @@ target_link_libraries(jsinspector
 )
 target_compile_reactnative_options(jsinspector PRIVATE)
 target_compile_options(jsinspector PRIVATE
-        $<$<CONFIG:Debug>:-DREACT_NATIVE_DEBUGGER_ENABLED=1>
-        $<$<CONFIG:Debug>:-DREACT_NATIVE_DEBUGGER_ENABLED_DEVONLY=1>
+        # Expo Go requires debugging on release builds
+        -DREACT_NATIVE_DEBUGGER_ENABLED=1
+        -DREACT_NATIVE_DEBUGGER_ENABLED_DEVONLY=1
+        # $<$<CONFIG:Debug>:-DREACT_NATIVE_DEBUGGER_ENABLED=1>
+        # $<$<CONFIG:Debug>:-DREACT_NATIVE_DEBUGGER_ENABLED_DEVONLY=1>
 )

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,9 @@ target_link_libraries(jsinspector`
`28`	`28`	`)`
`29`	`29`	`target_compile_reactnative_options(jsinspector PRIVATE)`
`30`	`30`	`target_compile_options(jsinspector PRIVATE`
`31`		`- $<$<CONFIG:Debug>:-DREACT_NATIVE_DEBUGGER_ENABLED=1>`
`32`		`- $<$<CONFIG:Debug>:-DREACT_NATIVE_DEBUGGER_ENABLED_DEVONLY=1>`
	`31`	`+ # Expo Go requires debugging on release builds`
	`32`	`+ -DREACT_NATIVE_DEBUGGER_ENABLED=1`
	`33`	`+ -DREACT_NATIVE_DEBUGGER_ENABLED_DEVONLY=1`
	`34`	`+ # $<$<CONFIG:Debug>:-DREACT_NATIVE_DEBUGGER_ENABLED=1>`
	`35`	`+ # $<$<CONFIG:Debug>:-DREACT_NATIVE_DEBUGGER_ENABLED_DEVONLY=1>`
`33`	`36`	`)`