Allow to disable web notifications (noticed_notifications)

[javierav]

Hi @excid3!

I want to use the v2 version in my project but I have found a limitation: you cannot disable the insertion of the "web notification" (old delivery_by :database) into the database.

I'll give you an example. When I perform a certain action I want to notify the user by slack, email and mobile but I don't want the notification to appear in the list of web notifications.

I understand that to make these notifications the record is inserted into the noticed_events table, but why is it mandatory that it also be inserted into the noticed_notifications table? Shouldn't it be optional and user configurable?

In the current form, it is always required to remain as a web notification.

Regards!

[excid3]

Already supported with the Noticed::Ephemeral class. We just don't have docs on it yet.

[javierav]

Interesting! I'll try it then! Thanks!

[excid3]

Let me know how it goes. Will try and get our docs updated for that soon. I thought it was already in there somewhere.

[javierav]

I have started testing Ephemeral and have detected that in the context of an instance of Noticed::Ephemeral, record is nil. On the other hand, in Noticed::Event it does have the appropriate value. Is it for some reason?

[excid3]

I think you need to access it through params because that's a special case for the Event notifications to save in the polymorphic association.

[excid3]

We might be able to add a delegate :record, to: :params in Ephemeral to make that a bit more similar, but they are not guaranteed to be 100% compatible since they are different implementations.

[excid3]

Give #448 a try.

[javierav]

Yeah, thats works! Thank you for your involvement!

[excid3]

Great! Thanks for finding that. I totally missed that.