Skip to content

Conversation

@jbcaillau
Copy link
Contributor

hi @sshin23 just to fix what looks like a (very) minor issue as dt should T/N (or 1/N, depending in any case on N as, otherwise, changing the grid size implies changing the time horizon)

BTW: the mayer term in the cost is a bit strange (just looks like the reweighted final grid point of the Lagrange quadrature, but for the control):

    objective(c, 0.5 * Qf * (x[N+1, j] - d)^2 for (j, Qf, d) in itr2)

do you have a detailed ref. towards the problem?

cc: @amontoison

Copy link
Member

@frapac frapac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sshin23
Copy link
Collaborator

sshin23 commented May 17, 2025

Thank you, @jbcaillau for reporting this

@sshin23 sshin23 merged commit c8bb0e7 into exanauts:main May 17, 2025
5 checks passed
@jbcaillau
Copy link
Contributor Author

LGTM!

Looks Good To Me? Let’s Get To Merge… 🙂?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants