Skip to content

Commit 1a51af8

Browse files
committed
Prevent mutating transactions when signing (#4789).
1 parent fc66b8a commit 1a51af8

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src.ts/wallet/base-wallet.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { getAddress, resolveAddress } from "../address/index.js";
22
import { hashMessage, TypedDataEncoder } from "../hash/index.js";
3-
import { AbstractSigner } from "../providers/index.js";
3+
import { AbstractSigner, copyRequest } from "../providers/index.js";
44
import { computeAddress, Transaction } from "../transaction/index.js";
55
import {
66
defineProperties, resolveProperties, assert, assertArgument
@@ -69,6 +69,7 @@ export class BaseWallet extends AbstractSigner {
6969
}
7070

7171
async signTransaction(tx: TransactionRequest): Promise<string> {
72+
tx = copyRequest(tx);
7273

7374
// Replace any Addressable or ENS name with an address
7475
const { to, from } = await resolveProperties({

0 commit comments

Comments
 (0)