simulators/ethereum/engine: Fix running tests with multiple sync modes (#628)

asdacap · web-flow · commit 70913f3b07f4 · 2022-08-08T09:05:03.000-05:00
Fix wrong sync mode run
diff --git a/simulators/ethereum/engine/suites/sync/tests.go b/simulators/ethereum/engine/suites/sync/tests.go
@@ -63,6 +63,8 @@ func AddSyncTestsToSuite(sim *hivesim.Simulation, suite *hivesim.Suite, tests []
 				// Add the new file to be loaded as chain.rlp
 			}
 			for _, variant := range clientSyncVariantGenerator.Configure(big.NewInt(ttd), genesisPath, currentTest.ChainFile) {
+				variant := variant
+				clientDef := clientDef
 				suite.Add(hivesim.TestSpec{
 					Name:        fmt.Sprintf("%s (%s, sync/%s)", currentTest.Name, clientDef.Name, variant.Name),
 					Description: currentTest.About,

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,8 @@ func AddSyncTestsToSuite(sim hivesim.Simulation, suite hivesim.Suite, tests []`
`63`	`63`	`// Add the new file to be loaded as chain.rlp`
`64`	`64`	`}`
`65`	`65`	`for _, variant := range clientSyncVariantGenerator.Configure(big.NewInt(ttd), genesisPath, currentTest.ChainFile) {`
	`66`	`+ variant := variant`
	`67`	`+ clientDef := clientDef`
`66`	`68`	`suite.Add(hivesim.TestSpec{`
`67`	`69`	`Name: fmt.Sprintf("%s (%s, sync/%s)", currentTest.Name, clientDef.Name, variant.Name),`
`68`	`70`	`Description: currentTest.About,`