Replies: 1 comment 3 replies
-
I'm sure you all are very busy, and I appreciate the hard work you are doing (just by the way). Just really wanna get this over the line |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Feedback
Slow to review PRs on ethereum-optimism.github.io repo
It's frustrating. My last PR to this repo (merged) took 10+ days to review and approve. Current one has been more than two weeks.
Additional Information
Hi, I opened PR #1143 (update: add optimism and optimism-sepolia addresses for BTREE token) on the ethereum-optimism.github.io repo. It has been open for 2 weeks and still needs review. It might be deprioritized because some CI check failed, which I investigated locally and left notes on in the PR.
The PR is a basic update to the json in the data/BTREE/data.json file adding the L2 BTREE token contract address for optimism and optimism-sepolia. I have triple checked the formatting, and the contract addresses used in the PR, and the contracts onchain. I can't see a problem. The PR is marked as requiring review, not as auto-rejected, so I would appreciate the review.
The PR guidelines request that users not pack multiple chains into the same PR (https://github.com/ethereum-optimism/ethereum-optimism.github.io?tab=readme-ov-file#specifying-chains), hence me not doing that. Don't wanna open further PRs for other chains on the same file/token, as may get a merge conflict, further slowing things down. Want to get this (and future PRs) merged though please, as I have several more chains to add for this token in the optimism superchain ecosystem, and this is becoming a blocker.
Beta Was this translation helpful? Give feedback.
All reactions