perf: Fix caching in config loaders (#19042)

* perf: Fix caching in `LegacyConfigLoader`

* add comment

* refactor

* refactor

* fix caching in `ConfigLoader`

* add test

* add test for `getCachedConfigArrayForPath`

* add unit tests, remove eslint tests

* update error messages for promises in sync methods

Author: mdjermanovic