Fix clippy and tests

Author: michaelsproul

beacon_node/beacon_chain/src/schema_change/migration_schema_v24.rs

@@ -280,10 +280,12 @@ pub fn downgrade_from_v24<T: BeaconChainTypes>(
         .into_iter()
         .flat_map(|(_, summaries)| summaries)
     {
-        // If boundary state persist
+        // If boundary state persist.
+        // Do not cache these states as they are unlikely to be relevant later.
+        let update_cache = false;
         if summary.slot % T::EthSpec::slots_per_epoch() == 0 {
             let (state, _) = db
-                .load_hot_state(&state_root)?
+                .load_hot_state(&state_root, update_cache)?
                 .ok_or(Error::MissingState(state_root))?;
 
             // Immediately commit the state. Otherwise we will OOM and it's stored in a different

beacon_node/beacon_chain/tests/store_tests.rs

@@ -518,14 +518,14 @@ async fn epoch_boundary_state_attestation_processing() {
             .expect("block exists");
         // Use get_state as the state may be finalized by this point
         let mut epoch_boundary_state = store
-            .get_state(&block.state_root(), None)
+            .get_state(&block.state_root(), None, CACHE_STATE_IN_TESTS)
             .expect("no error")
             .unwrap_or_else(|| {
                 panic!("epoch boundary state should exist {:?}", block.state_root())
             });
         let ebs_state_root = epoch_boundary_state.update_tree_hash_cache().unwrap();
         let mut ebs_of_ebs = store
-            .get_state(&ebs_state_root, None)
+            .get_state(&ebs_state_root, None, CACHE_STATE_IN_TESTS)
             .expect("no error")
             .unwrap_or_else(|| panic!("ebs of ebs should exist {ebs_state_root:?}"));
         ebs_of_ebs.apply_pending_mutations().unwrap();

beacon_node/store/src/hdiff.rs

@@ -654,10 +654,10 @@ impl HierarchyConfig {
 impl HierarchyModuli {
     /// * `slot` - Slot of the storage strategy
     /// * `start_slot` - Slot before which states are not available. Initial snapshot point, which
-    ///                  may not be aligned to the hierarchy moduli values. Given an example of
-    ///                  exponents [5,13,21], to reconstruct state at slot 3,000,003: if start = 3,000,002
-    ///                  layer 2 diff will point to the start snapshot instead of the layer 1 diff at
-    ///                  2998272.
+    ///   may not be aligned to the hierarchy moduli values. Given an example of
+    ///   exponents [5,13,21], to reconstruct state at slot 3,000,003: if start = 3,000,002
+    ///   layer 2 diff will point to the start snapshot instead of the layer 1 diff at
+    ///   2998272.
     pub fn storage_strategy(&self, slot: Slot, start_slot: Slot) -> Result<StorageStrategy, Error> {
         match slot.cmp(&start_slot) {
             Ordering::Less => return Err(Error::LessThanStart(slot, start_slot)),