Response's aclose/close function should NOT set status so earlier. #3650
Unanswered
yuedai
asked this question in
Potential Issue
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
https://github.com/encode/httpx/blob/89102021fcb44f6c3fab6304e5f951692723c908/httpx/_models.py#L1065C1-L1077C1
In the close/aclose function of Response, current implementation do this:
I am wondering if self.stream.aclose() failed for the first time, we would have a half state connection and would never be closed?
Should we change it to
Beta Was this translation helpful? Give feedback.
All reactions