Skip to content

Conversation

@mr-c
Copy link
Contributor

@mr-c mr-c commented Jul 10, 2024

@mr-c
Copy link
Contributor Author

mr-c commented Jul 10, 2024

@sbc100 @tlively Looks like some tests need to be rebaseline; is that easy for you to do?

@sbc100
Copy link
Collaborator

sbc100 commented Jul 10, 2024

If this file is purely coming from simde repo should we include as a git submodule perhaps? (That can be a separate change of course).

@mr-c
Copy link
Contributor Author

mr-c commented Jul 10, 2024

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly rubberstamp LGTM

@sbc100
Copy link
Collaborator

sbc100 commented Jul 10, 2024

@sbc100 The file is modified from the SIMDe repo via https://github.com/emscripten-core/emscripten/blob/main/tools/maint/simde_update.py

Ah yes, thanks for the reminder. I wonder if we should mention that script both the file content, and also in PR descriptions when we update it. e.g. This changes was generated using ...?

@mr-c
Copy link
Contributor Author

mr-c commented Jul 10, 2024

@sbc100 The file is modified from the SIMDe repo via https://github.com/emscripten-core/emscripten/blob/main/tools/maint/simde_update.py

Ah yes, thanks for the reminder. I wonder if we should mention that script both the file content, and also in PR descriptions when we update it. e.g. This changes was generated using ...?

Sure. I can amend the commit message after the tests pass ( or the merger can do so 👍)

@sbc100 sbc100 enabled auto-merge (squash) July 10, 2024 19:20
@sbc100 sbc100 merged commit 6223c43 into emscripten-core:main Jul 10, 2024
@mr-c mr-c deleted the simde_0.8.2 branch July 10, 2024 21:59
verhovsky pushed a commit to verhovsky/emscripten that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants