Force native compilation from the Makefile

[DamienCassou]

I'm just discovering Emacs 28. After I cleaned all byte compiled files, I ran make (which took some time) and then started Emacs 28. After Emacs had started, I got some messages in the *Warnings* buffer which seemed to indicate that Emacs was compiling my packages. I was wondering if make could do that so Emacs wouldn't have to do that interactively.

[tarsius]

I ran make (which took some time)

If we add native compilation here, then it is going to take much longer.

After Emacs had started, I got some messages in the *Warnings* buffer which seemed to indicate that Emacs was compiling my packages.

This is controlled by native-comp-verbose, though the default is to not show any warnings. And the warnings are supposed to go into *Native-compile-Log* buffer I think. I am currently on 29, so maybe this is different in 28. That would surprise me though; are you maybe on an old 28 build?

I was wondering if make could do that so Emacs wouldn't have to do that interactively.

Looks like it would be as simple as replacing batch-byte-compile with batch-native-compile, so I should probably at least make this configurable.

[Eason0210]

(when (native-comp-available-p)
  (setq borg-compile-function #'native-compile))

I set this in my etc/borg/config.el, and run make all , but I always got failed report ( Done (Total of 0 files compiled, 2 failed)).
Do I miss something else ?

--- [borg] ---
  Loading c:/Users/Aqua/.emacs.d/etc/borg/config.el...
 Creating c:/Users/Aqua/.emacs.d/lib/borg/borg-autoloads.el...
Compiling c:/Users/Aqua/.emacs.d/lib/borg/borg-elpa.el...
Compiling c:/Users/Aqua/.emacs.d/lib/borg/borg.el...
Done (Total of 0 files compiled, 2 failed)
  Running `makeinfo --no-split borg.texi -o borg.info'...
  Running `makeinfo --no-split borg.texi -o borg.info'...done
  Running `install-info borg.info --dir=dir'...
  Running `install-info borg.info --dir=dir'...done
... more packages ...

[tarsius]

I can reproduce it with recent 28 and 29 and even the older 28.0.90. So maybe this never worked. Could also be a regression though (in Emacs or Borg).

I don't really have the time or interest to investigate this, but would be interested in the results if you could investigate this yourself.

[Eason0210]

I can reproduce it with recent 28 and 29 and even the older 28.0.90. So maybe this never worked. Could also be a regression though (in Emacs or Borg).

I don't really have the time or interest to investigate this, but would be interested in the results if you could investigate this yourself.

Hi @tarsius ,

I known why we got the wrong compile message now.

Because byte-compile-file will return t when compile success , but native-compile will return the filename of the
compiled object , not t. So the fail-count is actually success compile + failed compile.

And when native-compile failed, it will not return nil, I don't known how to handle this.

The bug is in here:
https://github.com/emacscollective/borg/blob/master/borg.el#L749-L750

native-compile is a native compiled Lisp function in ‘comp.el’.

(native-compile FUNCTION-OR-FILE &optional OUTPUT)

Compile FUNCTION-OR-FILE into native code.
This is the synchronous entry-point for the Emacs Lisp native
compiler.
FUNCTION-OR-FILE is a function symbol, a form, or the filename of
an Emacs Lisp source file.
If OUTPUT is non-nil, use it as the filename for the compiled
object.
If FUNCTION-OR-FILE is a filename, return the filename of the
compiled object.  If FUNCTION-OR-FILE is a function symbol or a
form, return the compiled function.

  Probably introduced at or before Emacs version 28.1.

Tested on macOS with latest commit of Emacs

[tarsius]

Thanks!

820e526 should fix it.

[Eason0210]

Great, I tested and It works well now. Thanks!