chore: bump node to v20.19.0 (34-x-y) (#46037)

* chore: bump node in DEPS to v20.19.0

* deps, src: simplifying base64 encoding

nodejs/node#52714

* module: simplify --inspect-brk handling

nodejs/node#55679

* test: make test-crypto-hash compatible with OpenSSL > 3.4.0

nodejs/node#56160

* module: refactor ESM loader for adding future synchronous hooks

nodejs/node#54769

* module: detect ESM syntax by trying to recompile as SourceTextModule

nodejs/node#52413

* worker: add postMessageToThread

nodejs/node#53682

* backport unflagging of require(esm) to v20

nodejs/node#56927

* module: detect ESM syntax by trying to recompile as SourceTextModule

nodejs/node#52413

* chore: fixup patch indices

* chore: handle filename.json changes

- nodejs/node#51711
- nodejs/node#53573

* src: refactor embedded entrypoint loading

nodejs/node#53573

* lib: allow CJS source map cache to be reclaimed

nodejs/node#51711

* test: make eval snapshot tests more flexible

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>

Author: electron-roller[bot]

DEPS

@@ -4,7 +4,7 @@ vars = {
   'chromium_version':
     '132.0.6834.210',
   'node_version':
-    'v20.18.3',
+    'v20.19.0',
   'nan_version':
     'e14bdcd1f72d62bca1d541b66da43130384ec213',
   'squirrel.mac_version':

patches/node/.patches

@@ -54,3 +54,4 @@ build_restore_clang_as_default_compiler_on_macos.patch
 esm_drop_support_for_import_assertions.patch
 build_remove_explicit_linker_call_to_libm_on_macos.patch
 build_define_nominmax_in_common_gypi.patch
+test_make_eval_snapshot_tests_more_flexible.patch

patches/node/build_add_gn_build_files.patch

@@ -11,7 +11,7 @@ really in 20/21. We have to wait until 22 is released to be able to
 build with upstream GN files.
 
 diff --git a/BUILD.gn b/BUILD.gn
-index 1ed186b597eece7c34cb69c8e1e20870555a040d..2ce1e8a7dcca2ba153d387d11970c72b5f43c167 100644
+index 1ed186b597eece7c34cb69c8e1e20870555a040d..4171613ba865bb3ba82a2e3a219def63bb7abdc1 100644
 --- a/BUILD.gn
 +++ b/BUILD.gn
 @@ -1,14 +1,406 @@
@@ -284,7 +284,6 @@ index 1ed186b597eece7c34cb69c8e1e20870555a040d..2ce1e8a7dcca2ba153d387d11970c72b
 +    ":node_js2c_exec",
 +    "deps/googletest:gtest",
 +    "deps/ada",
-+    "deps/base64",
 +    "deps/simdutf",
 +    "deps/uvwasi",
 +    "//third_party/zlib",
@@ -333,6 +332,7 @@ index 1ed186b597eece7c34cb69c8e1e20870555a040d..2ce1e8a7dcca2ba153d387d11970c72b
 +    "-Wno-sometimes-uninitialized",
 +    "-Wno-string-plus-int",
 +    "-Wno-unused-function",
++    "-Wno-unreachable-code-return",
 +    "-Wno-unused-label",
 +    "-Wno-unused-private-field",
 +    "-Wno-unused-variable",
@@ -458,84 +458,6 @@ index e92ac3a3beac143dced2efb05304ed8ba832b067..1ce69e9deba1a9b191e8d95f4c82e0ec
 -ada_gn_build("ada") {
 +  public_configs = [ ":ada_config" ]
  }
-diff --git a/deps/base64/unofficial.gni b/deps/base64/unofficial.gni
-index 0e69d7383762f6b81c5b57698aa9d121d5a9c401..35bbeb37acc7ccb14b4b8a644ec3d4c76ca5c61c 100644
---- a/deps/base64/unofficial.gni
-+++ b/deps/base64/unofficial.gni
-@@ -12,6 +12,10 @@ template("base64_gn_build") {
-     }
-   }
- 
-+  # FIXME(zcbenz): ASM on win/x86 compiles perfectly in upstream Node, figure
-+  # out why it does not work in Electron's build configs.
-+  support_x86_asm = current_cpu == "x64" || (current_cpu == "x86" && !is_win)
-+
-   config("base64_internal_config") {
-     include_dirs = [ "base64/lib" ]
-     if (is_component_build) {
-@@ -19,7 +23,7 @@ template("base64_gn_build") {
-     } else {
-       defines = []
-     }
--    if (current_cpu == "x86" || current_cpu == "x64") {
-+    if (support_x86_asm) {
-       defines += [
-         "HAVE_SSSE3=1",
-         "HAVE_SSE41=1",
-@@ -69,7 +73,7 @@ template("base64_gn_build") {
-   source_set("base64_ssse3") {
-     configs += [ ":base64_internal_config" ]
-     sources = [ "base64/lib/arch/ssse3/codec.c" ]
--    if (current_cpu == "x86" || current_cpu == "x64") {
-+    if (support_x86_asm) {
-       if (is_clang || !is_win) {
-         cflags_c = [ "-mssse3" ]
-       }
-@@ -79,7 +83,7 @@ template("base64_gn_build") {
-   source_set("base64_sse41") {
-     configs += [ ":base64_internal_config" ]
-     sources = [ "base64/lib/arch/sse41/codec.c" ]
--    if (current_cpu == "x86" || current_cpu == "x64") {
-+    if (support_x86_asm) {
-       if (is_clang || !is_win) {
-         cflags_c = [ "-msse4.1" ]
-       }
-@@ -89,7 +93,7 @@ template("base64_gn_build") {
-   source_set("base64_sse42") {
-     configs += [ ":base64_internal_config" ]
-     sources = [ "base64/lib/arch/sse42/codec.c" ]
--    if (current_cpu == "x86" || current_cpu == "x64") {
-+    if (support_x86_asm) {
-       if (is_clang || !is_win) {
-         cflags_c = [ "-msse4.2" ]
-       }
-@@ -99,7 +103,7 @@ template("base64_gn_build") {
-   source_set("base64_avx") {
-     configs += [ ":base64_internal_config" ]
-     sources = [ "base64/lib/arch/avx/codec.c" ]
--    if (current_cpu == "x86" || current_cpu == "x64") {
-+    if (support_x86_asm) {
-       if (is_clang || !is_win) {
-         cflags_c = [ "-mavx" ]
-       } else if (is_win) {
-@@ -111,7 +115,7 @@ template("base64_gn_build") {
-   source_set("base64_avx2") {
-     configs += [ ":base64_internal_config" ]
-     sources = [ "base64/lib/arch/avx2/codec.c" ]
--    if (current_cpu == "x86" || current_cpu == "x64") {
-+    if (support_x86_asm) {
-       if (is_clang || !is_win) {
-         cflags_c = [ "-mavx2" ]
-       } else if (is_win) {
-@@ -123,7 +127,7 @@ template("base64_gn_build") {
-   source_set("base64_avx512") {
-     configs += [ ":base64_internal_config" ]
-     sources = [ "base64/lib/arch/avx512/codec.c" ]
--    if (current_cpu == "x86" || current_cpu == "x64") {
-+    if (support_x86_asm) {
-       if (is_clang || !is_win) {
-         cflags_c = [
-           "-mavx512vl",
 diff --git a/deps/cares/BUILD.gn b/deps/cares/BUILD.gn
 index ac19ac73ed1e24c61cb679f3851685b79cfc8b39..ef745c19f2b1cd433cc43c834a18db7eaa8e5162 100644
 --- a/deps/cares/BUILD.gn
@@ -1281,7 +1203,7 @@ index 0000000000000000000000000000000000000000..af9cbada10203b387fb9732b346583b1
 +}
 diff --git a/filenames.json b/filenames.json
 new file mode 100644
-index 0000000000000000000000000000000000000000..c429d4cbfff605ff78c7c8ee3c5ad046594163f3
+index 0000000000000000000000000000000000000000..72ddbe405908109ab7563e0c8f2e61c75cac88fc
 --- /dev/null
 +++ b/filenames.json
 @@ -0,0 +1,740 @@
@@ -1649,6 +1571,7 @@ index 0000000000000000000000000000000000000000..c429d4cbfff605ff78c7c8ee3c5ad046
 +    "lib/internal/source_map/prepare_stack_trace.js",
 +    "lib/internal/source_map/source_map.js",
 +    "lib/internal/source_map/source_map_cache.js",
++    "lib/internal/source_map/source_map_cache_map.js",
 +    "lib/internal/stream_base_commons.js",
 +    "lib/internal/streams/add-abort-signal.js",
 +    "lib/internal/streams/compose.js",
@@ -1696,10 +1619,8 @@ index 0000000000000000000000000000000000000000..c429d4cbfff605ff78c7c8ee3c5ad046
 +    "lib/internal/util/colors.js",
 +    "lib/internal/util/comparisons.js",
 +    "lib/internal/util/debuglog.js",
-+    "lib/internal/util/embedding.js",
 +    "lib/internal/util/inspect.js",
 +    "lib/internal/util/inspector.js",
-+    "lib/internal/util/iterable_weak_map.js",
 +    "lib/internal/util/parse_args/parse_args.js",
 +    "lib/internal/util/parse_args/utils.js",
 +    "lib/internal/util/types.js",
@@ -1725,6 +1646,7 @@ index 0000000000000000000000000000000000000000..c429d4cbfff605ff78c7c8ee3c5ad046
 +    "lib/internal/worker.js",
 +    "lib/internal/worker/io.js",
 +    "lib/internal/worker/js_transferable.js",
++    "lib/internal/worker/messaging.js",
 +    "lib/module.js",
 +    "lib/net.js",
 +    "lib/os.js",

patches/node/build_compile_with_c_20_support.patch

@@ -10,7 +10,7 @@ V8 requires C++20 support as of https://chromium-review.googlesource.com/c/v8/v8
 This can be removed when Electron upgrades to a version of Node.js containing the required V8 version.
 
 diff --git a/common.gypi b/common.gypi
-index 690068f093f12b6831f8ccce41289d02d7047a7a..5a3df388773ad288553bf036be42dc1a0ba75c09 100644
+index 3b26f0e9c8a16135d6c614374cfb943ebc07f992..4a79378a6633b33f86f6576c27659df18193ed46 100644
 --- a/common.gypi
 +++ b/common.gypi
 @@ -305,7 +305,7 @@

patches/node/build_define_nominmax_in_common_gypi.patch

@@ -18,7 +18,7 @@ significant.
 PR-URL: https://github.com/nodejs/node/pull/52794
 
 diff --git a/common.gypi b/common.gypi
-index 9bbf1b277eb17d78ca385643c3177638fd75866a..959ee74af88b44d31f2e6fa65c6f260820bd8c46 100644
+index 2f0dab65717ac59a32bd91dbac6a0b9ded5c93e6..cd3700f5290e69ec60fc22bd5fa32b54565aa049 100644
 --- a/common.gypi
 +++ b/common.gypi
 @@ -480,6 +480,10 @@

patches/node/build_ensure_native_module_compilation_fails_if_not_using_a_new.patch

@@ -7,7 +7,7 @@ Subject: build: ensure native module compilation fails if not using a new
 This should not be upstreamed, it is a quality-of-life patch for downstream module builders.
 
 diff --git a/common.gypi b/common.gypi
-index 776a6dcf3a729a65b367fb5b4c5685f841089eea..690068f093f12b6831f8ccce41289d02d7047a7a 100644
+index 46761b75327826b1f608670a1511be01df9be08e..3b26f0e9c8a16135d6c614374cfb943ebc07f992 100644
 --- a/common.gypi
 +++ b/common.gypi
 @@ -86,6 +86,8 @@

patches/node/build_remove_explicit_linker_call_to_libm_on_macos.patch

@@ -40,10 +40,10 @@ index 5e07e106672a04508a77584c109c97a67926c858..91001fa43ea4807d061f296eaeccb751
      }
      if (is_clang || !is_win) {
 diff --git a/deps/uv/unofficial.gni b/deps/uv/unofficial.gni
-index 7a73f891e3fc3261b77af97af63fca2eade49849..bda1b5dc899558c2b4a22377dde9fb3bcce5488c 100644
+index 348d2f0703e47ca7c5326a4b4c1d6ae31157eeb5..0944d6ddd241b113970ab6aa5804f9534fde882a 100644
 --- a/deps/uv/unofficial.gni
 +++ b/deps/uv/unofficial.gni
-@@ -82,11 +82,11 @@ template("uv_gn_build") {
+@@ -87,11 +87,11 @@ template("uv_gn_build") {
        ]
      }
      if (is_posix) {

patches/node/build_restore_clang_as_default_compiler_on_macos.patch

@@ -11,7 +11,7 @@ node-gyp will use the result of `process.config` that reflects the environment
 in which the binary got built.
 
 diff --git a/common.gypi b/common.gypi
-index 5a3df388773ad288553bf036be42dc1a0ba75c09..9bbf1b277eb17d78ca385643c3177638fd75866a 100644
+index 4a79378a6633b33f86f6576c27659df18193ed46..2f0dab65717ac59a32bd91dbac6a0b9ded5c93e6 100644
 --- a/common.gypi
 +++ b/common.gypi
 @@ -125,6 +125,7 @@

patches/node/cherry-pick_src_remove_calls_to_recently_deprecated_v8_apis.patch

@@ -15,27 +15,37 @@ This patch is expected to be deleted once we catch up with a Node.js
 upgrade that includes the original Node.js commit above.
 
 diff --git a/src/module_wrap.cc b/src/module_wrap.cc
-index ff658ec88e5161cd66536ee6e95dba675b16eccc..9bbb8ab908d8d992abb43254860d51f57f56387b 100644
+index 0f0b16fcdd8a97bba60faeff09300dd8102cf02c..094d12ffe99500af700a591f5cb33e7d7b247ed1 100644
 --- a/src/module_wrap.cc
 +++ b/src/module_wrap.cc
-@@ -202,8 +202,7 @@ void ModuleWrap::New(const FunctionCallbackInfo<Value>& args) {
-       }
- 
-       Local<String> source_text = args[2].As<String>();
--      ScriptOrigin origin(isolate,
--                          url,
-+      ScriptOrigin origin(url,
-                           line_offset,
-                           column_offset,
-                           true,                             // is cross origin
-@@ -464,7 +463,6 @@ void ModuleWrap::Evaluate(const FunctionCallbackInfo<Value>& args) {
+@@ -304,8 +304,7 @@ MaybeLocal<Module> ModuleWrap::CompileSourceTextModule(
+     bool* cache_rejected) {
+   Isolate* isolate = realm->isolate();
+   EscapableHandleScope scope(isolate);
+-  ScriptOrigin origin(isolate,
+-                      url,
++  ScriptOrigin origin(url,
+                       line_offset,
+                       column_offset,
+                       true,            // is cross origin
+@@ -500,7 +499,6 @@ void ModuleWrap::Evaluate(const FunctionCallbackInfo<Value>& args) {
 
    ShouldNotAbortOnUncaughtScope no_abort_scope(realm->env());
    TryCatchScope try_catch(realm->env());
 -  Isolate::SafeForTerminationScope safe_for_termination(isolate);
 
    bool timed_out = false;
    bool received_signal = false;
+@@ -1009,8 +1007,7 @@ void ModuleWrap::CreateRequiredModuleFacade(
+   ASSIGN_OR_RETURN_UNWRAP(&original, wrap);
+ 
+   // Use the same facade source and URL to hit the compilation cache.
+-  ScriptOrigin origin(isolate,
+-                      env->required_module_facade_url_string(),
++  ScriptOrigin origin(env->required_module_facade_url_string(),
+                       0,               // line offset
+                       0,               // column offset
+                       true,            // is cross origin
 diff --git a/src/node_builtins.cc b/src/node_builtins.cc
 index 4bf80aa6cc6385dc376fd0a3538efc27fe5bd0a2..3e37aa8b0c9696cceb3f3cfab9721f38c74a2fba 100644
 --- a/src/node_builtins.cc
@@ -50,36 +60,20 @@ index 4bf80aa6cc6385dc376fd0a3538efc27fe5bd0a2..3e37aa8b0c9696cceb3f3cfab9721f38
    BuiltinCodeCacheData cached_data{};
    {
 diff --git a/src/node_contextify.cc b/src/node_contextify.cc
-index 6456d87d4202c013aafe071adbac06852b3ae2c1..28ba7dbe66a44a43c39e3d75edf0be9513bcf732 100644
+index c8ccf38eaaeaccf3715b742e7e64cf7803dbb392..a3f70f6cba773d0a7a00aca96a1687c1e2ae38e6 100644
 --- a/src/node_contextify.cc
 +++ b/src/node_contextify.cc
-@@ -877,16 +877,15 @@ void ContextifyScript::New(const FunctionCallbackInfo<Value>& args) {
+@@ -878,8 +878,7 @@ void ContextifyScript::New(const FunctionCallbackInfo<Value>& args) {
    host_defined_options->Set(
        isolate, loader::HostDefinedOptions::kID, id_symbol);
 
 -  ScriptOrigin origin(isolate,
 -                      filename,
--                      line_offset,                          // line offset
--                      column_offset,                        // column offset
--                      true,                                 // is cross origin
--                      -1,                                   // script id
--                      Local<Value>(),                       // source map URL
--                      false,                                // is opaque (?)
--                      false,                                // is WASM
--                      false,                                // is ES Module
 +  ScriptOrigin origin(filename,
-+                      line_offset,     // line offset
-+                      column_offset,   // column offset
-+                      true,            // is cross origin
-+                      -1,              // script id
-+                      Local<Value>(),  // source map URL
-+                      false,           // is opaque (?)
-+                      false,           // is WASM
-+                      false,           // is ES Module
-                       host_defined_options);
-   ScriptCompiler::Source source(code, origin, cached_data);
-   ScriptCompiler::CompileOptions compile_options =
-@@ -998,7 +997,7 @@ MaybeLocal<Function> CompileFunction(Local<Context> context,
+                       line_offset,                          // line offset
+                       column_offset,                        // column offset
+                       true,                                 // is cross origin
+@@ -999,7 +998,7 @@ MaybeLocal<Function> CompileFunction(Local<Context> context,
                                       Local<String> filename,
                                       Local<String> content,
                                       std::vector<Local<String>>* parameters) {
@@ -88,81 +82,34 @@ index 6456d87d4202c013aafe071adbac06852b3ae2c1..28ba7dbe66a44a43c39e3d75edf0be95
    ScriptCompiler::Source script_source(content, script_origin);
 
    return ScriptCompiler::CompileFunction(context,
-@@ -1108,7 +1107,6 @@ bool ContextifyScript::EvalMachine(Local<Context> context,
+@@ -1109,7 +1108,6 @@ bool ContextifyScript::EvalMachine(Local<Context> context,
    }
 
    TryCatchScope try_catch(env);
 -  Isolate::SafeForTerminationScope safe_for_termination(env->isolate());
    ContextifyScript* wrapped_script;
    ASSIGN_OR_RETURN_UNWRAP(&wrapped_script, args.This(), false);
    Local<UnboundScript> unbound_script =
-@@ -1286,8 +1284,7 @@ void ContextifyContext::CompileFunction(
+@@ -1278,8 +1276,7 @@ void ContextifyContext::CompileFunction(
    Local<PrimitiveArray> host_defined_options =
-       GetHostDefinedOptions(isolate, id_symbol);
-   ScriptCompiler::Source source =
--      GetCommonJSSourceInstance(isolate,
--                                code,
-+      GetCommonJSSourceInstance(code,
-                                 filename,
-                                 line_offset,
-                                 column_offset,
-@@ -1342,15 +1339,13 @@ void ContextifyContext::CompileFunction(
- }
+       loader::ModuleWrap::GetHostDefinedOptions(isolate, id_symbol);
 
- ScriptCompiler::Source ContextifyContext::GetCommonJSSourceInstance(
--    Isolate* isolate,
-     Local<String> code,
-     Local<String> filename,
-     int line_offset,
-     int column_offset,
-     Local<PrimitiveArray> host_defined_options,
-     ScriptCompiler::CachedData* cached_data) {
 -  ScriptOrigin origin(isolate,
 -                      filename,
 +  ScriptOrigin origin(filename,
                        line_offset,     // line offset
                        column_offset,   // column offset
                        true,            // is cross origin
-@@ -1528,7 +1523,7 @@ void ContextifyContext::ContainsModuleSyntax(
-   Local<PrimitiveArray> host_defined_options =
-       GetHostDefinedOptions(isolate, id_symbol);
-   ScriptCompiler::Source source = GetCommonJSSourceInstance(
--      isolate, code, filename, 0, 0, host_defined_options, nullptr);
-+      code, filename, 0, 0, host_defined_options, nullptr);
-   ScriptCompiler::CompileOptions options = GetCompileOptions(source);
- 
-   std::vector<Local<String>> params = GetCJSParameters(env->isolate_data());
-@@ -1576,7 +1571,7 @@ void ContextifyContext::ContainsModuleSyntax(
-               code,
-               String::NewFromUtf8(isolate, "})();").ToLocalChecked());
-           ScriptCompiler::Source wrapped_source = GetCommonJSSourceInstance(
--              isolate, code, filename, 0, 0, host_defined_options, nullptr);
-+              code, filename, 0, 0, host_defined_options, nullptr);
-           std::ignore = ScriptCompiler::CompileFunction(
-               context,
-               &wrapped_source,
-@@ -1629,8 +1624,7 @@ static void CompileFunctionForCJSLoader(
- 
+@@ -1466,8 +1463,7 @@ static MaybeLocal<Function> CompileFunctionForCJSLoader(
    Local<Symbol> symbol = env->vm_dynamic_import_default_internal();
-   Local<PrimitiveArray> hdo = GetHostDefinedOptions(isolate, symbol);
+   Local<PrimitiveArray> hdo =
+       loader::ModuleWrap::GetHostDefinedOptions(isolate, symbol);
 -  ScriptOrigin origin(isolate,
 -                      filename,
 +  ScriptOrigin origin(filename,
                        0,               // line offset
                        0,               // column offset
                        true,            // is cross origin
-diff --git a/src/node_contextify.h b/src/node_contextify.h
-index 517e3f44d324900222e1da961a4cd60bbb4a85f9..10715c7eb07715cc11e49734bd54747dad95f6a4 100644
---- a/src/node_contextify.h
-+++ b/src/node_contextify.h
-@@ -99,7 +99,6 @@ class ContextifyContext : public BaseObject {
-       v8::Local<v8::Symbol> id_symbol,
-       const errors::TryCatchScope& try_catch);
-   static v8::ScriptCompiler::Source GetCommonJSSourceInstance(
--      v8::Isolate* isolate,
-       v8::Local<v8::String> code,
-       v8::Local<v8::String> filename,
-       int line_offset,
 diff --git a/test/cctest/test_environment.cc b/test/cctest/test_environment.cc
 index 64e38c83006a004ebc3519a5e9f8b04263244514..14e82cc80ff73084fb43b2ef07febfd2667a0abc 100644
 --- a/test/cctest/test_environment.cc