Skip to content

Commit 01444e0

Browse files
committed
Fixup InternalCallbackScope patch
nodejs/node#30236
1 parent 6acaac5 commit 01444e0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

patches/node/fix_expose_internalcallbackscope.patch

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Subject: fix: expose InternalCallbackScope
66
This commit exposes InternalCallbackScope in order to allow us access to kAllowEmptyResource for usage https://github.com/electron/electron/blob/master/atom/common/api/atom_bindings.cc\#L108. We should look to accomplish this another way so we no longer need to do this, as in verbose mode the regular CallBack Scope doesn't swallow errors and so we can otherwise use it.
77

88
diff --git a/src/node_internals.h b/src/node_internals.h
9-
index 0fff2e6111e53f99ca8e92d6966d9847570d01bd..e8d6705e0197aad55b931910bb5221dd33b37fb0 100644
9+
index 114498458a9fd69e636a8e68c30e4b93937406d7..c5b4a084e85b48d5e2121a1ebcfd0c4e4b081852 100644
1010
--- a/src/node_internals.h
1111
+++ b/src/node_internals.h
1212
@@ -203,7 +203,7 @@ v8::MaybeLocal<v8::Value> InternalMakeCallback(
@@ -16,5 +16,5 @@ index 0fff2e6111e53f99ca8e92d6966d9847570d01bd..e8d6705e0197aad55b931910bb5221dd
1616
-class InternalCallbackScope {
1717
+class NODE_EXTERN InternalCallbackScope {
1818
public:
19-
// Tell the constructor whether its `object` parameter may be empty or not.
20-
enum ResourceExpectation { kRequireResource, kAllowEmptyResource };
19+
enum Flags {
20+
kNoFlags = 0,

0 commit comments

Comments
 (0)