fix : notarization with an apple API key

bcomnes · bcomnes · commit bde20244b452 · 2023-12-19T20:52:39.000-08:00
Notarization wasn't actually running when the API key is set and notarize was set to true. The notarize tool library throws when a API key is provided and teamId is set, so you have to set notarize to true, but when you do currently, the step never runs.
diff --git a/packages/app-builder-lib/src/macPackager.ts b/packages/app-builder-lib/src/macPackager.ts
@@ -544,7 +544,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
       return proj
     }
     const { teamId } = options as NotarizeNotaryOptions
-    if (teamId && (legacyLogin || notaryToolLogin)) {
+    if ((teamId || options === true) && (legacyLogin || notaryToolLogin)) {
       const proj: NotaryToolStartOptions = {
         appPath,
         ...(legacyLogin ?? notaryToolLogin!),

Original file line number	Diff line number	Diff line change
`@@ -544,7 +544,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {`
`544`	`544`	`return proj`
`545`	`545`	`}`
`546`	`546`	`const { teamId } = options as NotarizeNotaryOptions`
`547`		`- if (teamId && (legacyLogin \|\| notaryToolLogin)) {`
	`547`	`+ if ((teamId \|\| options === true) && (legacyLogin \|\| notaryToolLogin)) {`
`548`	`548`	`const proj: NotaryToolStartOptions = {`
`549`	`549`	`appPath,`
`550`	`550`	`...(legacyLogin ?? notaryToolLogin!),`