Skip to content

Commit 8903c5d

Browse files
authored
fix(win): execute customUnInstall before atomicRMDir function in NSIS uninstaller (#8915)
fix #8874.
1 parent 065c6a4 commit 8903c5d

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

.changeset/spicy-cougars-type.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
fix: improve atomicRMDir function in NSIS uninstaller

packages/app-builder-lib/templates/nsis/uninstaller.nsh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,10 @@ Section "un.install"
141141

142142
!insertmacro setLinkVars
143143

144+
!ifmacrodef customUnInstall
145+
!insertmacro customUnInstall
146+
!endif
147+
144148
# delete the installed files
145149
!ifmacrodef customRemoveFiles
146150
!insertmacro customRemoveFiles
@@ -235,10 +239,6 @@ Section "un.install"
235239
!endif
236240
DeleteRegKey SHELL_CONTEXT "${INSTALL_REGISTRY_KEY}"
237241

238-
!ifmacrodef customUnInstall
239-
!insertmacro customUnInstall
240-
!endif
241-
242242
!ifdef ONE_CLICK
243243
!insertmacro quitSuccess
244244
!endif

0 commit comments

Comments
 (0)