Skip to content

Commit 70d7c85

Browse files
authored
docs: state detectUpdateChannel ignored when publishing to github (#8928)
1 parent f89fd20 commit 70d7c85

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

.changeset/slimy-ligers-dance.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
chore(docs): Document that detectUpdateChannel doesn't work when publishing to github

packages/app-builder-lib/scheme.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1756,7 +1756,7 @@
17561756
},
17571757
"detectUpdateChannel": {
17581758
"default": true,
1759-
"description": "Whether to infer update channel from application version pre-release components. e.g. if version `0.12.1-alpha.1`, channel will be set to `alpha`. Otherwise to `latest`.",
1759+
"description": "Whether to infer update channel from application version pre-release components. e.g. if version `0.12.1-alpha.1`, channel will be set to `alpha`. Otherwise to `latest`.\nThis does *not* apply to github publishing, which will [never auto-detect the update channel](https://github.com/electron-userland/electron-builder/issues/8589).",
17601760
"type": "boolean"
17611761
},
17621762
"disableDefaultIgnoredFiles": {
@@ -2437,7 +2437,7 @@
24372437
},
24382438
"detectUpdateChannel": {
24392439
"default": true,
2440-
"description": "Whether to infer update channel from application version pre-release components. e.g. if version `0.12.1-alpha.1`, channel will be set to `alpha`. Otherwise to `latest`.",
2440+
"description": "Whether to infer update channel from application version pre-release components. e.g. if version `0.12.1-alpha.1`, channel will be set to `alpha`. Otherwise to `latest`.\nThis does *not* apply to github publishing, which will [never auto-detect the update channel](https://github.com/electron-userland/electron-builder/issues/8589).",
24412441
"type": "boolean"
24422442
},
24432443
"disableDefaultIgnoredFiles": {
@@ -3069,7 +3069,7 @@
30693069
},
30703070
"detectUpdateChannel": {
30713071
"default": true,
3072-
"description": "Whether to infer update channel from application version pre-release components. e.g. if version `0.12.1-alpha.1`, channel will be set to `alpha`. Otherwise to `latest`.",
3072+
"description": "Whether to infer update channel from application version pre-release components. e.g. if version `0.12.1-alpha.1`, channel will be set to `alpha`. Otherwise to `latest`.\nThis does *not* apply to github publishing, which will [never auto-detect the update channel](https://github.com/electron-userland/electron-builder/issues/8589).",
30733073
"type": "boolean"
30743074
},
30753075
"disableDefaultIgnoredFiles": {
@@ -6274,7 +6274,7 @@
62746274
},
62756275
"detectUpdateChannel": {
62766276
"default": true,
6277-
"description": "Whether to infer update channel from application version pre-release components. e.g. if version `0.12.1-alpha.1`, channel will be set to `alpha`. Otherwise to `latest`.",
6277+
"description": "Whether to infer update channel from application version pre-release components. e.g. if version `0.12.1-alpha.1`, channel will be set to `alpha`. Otherwise to `latest`.\nThis does *not* apply to github publishing, which will [never auto-detect the update channel](https://github.com/electron-userland/electron-builder/issues/8589).",
62786278
"type": "boolean"
62796279
},
62806280
"disableDefaultIgnoredFiles": {
@@ -6960,7 +6960,7 @@
69606960
},
69616961
"detectUpdateChannel": {
69626962
"default": true,
6963-
"description": "Whether to infer update channel from application version pre-release components. e.g. if version `0.12.1-alpha.1`, channel will be set to `alpha`. Otherwise to `latest`.",
6963+
"description": "Whether to infer update channel from application version pre-release components. e.g. if version `0.12.1-alpha.1`, channel will be set to `alpha`. Otherwise to `latest`.\nThis does *not* apply to github publishing, which will [never auto-detect the update channel](https://github.com/electron-userland/electron-builder/issues/8589).",
69646964
"type": "boolean"
69656965
},
69666966
"directories": {

packages/app-builder-lib/src/options/PlatformSpecificBuildOptions.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ export interface PlatformSpecificBuildOptions extends TargetSpecificOptions, Fil
170170

171171
/**
172172
* Whether to infer update channel from application version pre-release components. e.g. if version `0.12.1-alpha.1`, channel will be set to `alpha`. Otherwise to `latest`.
173+
* This does *not* apply to github publishing, which will [never auto-detect the update channel](https://github.com/electron-userland/electron-builder/issues/8589).
173174
* @default true
174175
*/
175176
readonly detectUpdateChannel?: boolean

0 commit comments

Comments
 (0)