Fix download settings reload (#10993)

* log proxy URL and proxy disable settings

* refresh artifactDownloader when settings change

Author: pchila

changelog/fragments/1762196103-recreate-artifactdownloader-with-updated-settings.yaml

@@ -0,0 +1,45 @@
+# REQUIRED
+# Kind can be one of:
+# - breaking-change: a change to previously-documented behavior
+# - deprecation: functionality that is being removed in a later release
+# - bug-fix: fixes a problem in a previous version
+# - enhancement: extends functionality but does not break or fix existing behavior
+# - feature: new functionality
+# - known-issue: problems that we are aware of in a given version
+# - security: impacts on the security of a product or a user’s deployment.
+# - upgrade: important information for someone upgrading from a prior version
+# - other: does not fit into any of the other categories
+kind: bug-fix
+
+# REQUIRED for all kinds
+# Change summary; a 80ish characters long description of the change.
+summary: Reload agent binary source settings as configured in Fleet
+
+# REQUIRED for breaking-change, deprecation, known-issue
+# Long description; in case the summary is not enough to describe the change
+# this field accommodate a description without length limits.
+# description:
+
+# REQUIRED for breaking-change, deprecation, known-issue
+# impact:
+
+# REQUIRED for breaking-change, deprecation, known-issue
+# action:
+
+# REQUIRED for all kinds
+# Affected component; usually one of "elastic-agent", "fleet-server", "filebeat", "metricbeat", "auditbeat", "all", etc.
+component: elastic-agent
+
+# AUTOMATED
+# OPTIONAL to manually add other PR URLs
+# PR URL: A link the PR that added the changeset.
+# If not present is automatically filled by the tooling finding the PR where this changelog fragment has been added.
+# NOTE: the tooling supports backports, so it's able to fill the original PR number instead of the backport PR number.
+# Please provide it if you are adding a fragment for a different PR.
+# pr: https://github.com/owner/repo/1234
+
+# AUTOMATED
+# OPTIONAL to manually add other issue URLs
+# Issue URL; optional; the GitHub issue related to this changeset (either closes or is part of).
+# If not present is automatically filled by the tooling with the issue linked to the PR number.
+# issue: https://github.com/owner/repo/1234

internal/pkg/agent/application/upgrade/step_download.go

@@ -113,7 +113,7 @@ func (a *artifactDownloader) downloadArtifact(ctx context.Context, parsedVersion
 		factory = newDownloader
 		a.log.Infow("Downloading upgrade artifact", "version", parsedVersion,
 			"source_uri", settings.SourceURI, "drop_path", settings.DropPath,
-			"target_path", settings.TargetDirectory, "install_path", settings.InstallPath)
+			"target_path", settings.TargetDirectory, "install_path", settings.InstallPath, "proxy_uri", settings.Proxy.URL, "proxy_disable", settings.Proxy.Disable)
 	}
 	if downloaderFunc == nil {
 		downloaderFunc = a.downloadWithRetries

internal/pkg/agent/application/upgrade/upgrade.go

@@ -227,6 +227,8 @@ func (u *Upgrader) Reload(rawConfig *config.Config) error {
 	u.settings = cfg.Settings.DownloadConfig
 	u.upgradeSettings = cfg.Settings.Upgrade
 
+	u.artifactDownloader = newArtifactDownloader(u.settings, u.log)
+
 	return nil
 }