Skip to content

Commit 8dae866

Browse files
GH-508: Adopt the upstream lsp4j snapshot for call hierarchy
Signed-off-by: Jinbo Wang <[email protected]>
1 parent 897221d commit 8dae866

File tree

3 files changed

+8
-16
lines changed

3 files changed

+8
-16
lines changed

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CallHierarchyHandler.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,7 @@ private List<CallHierarchyIncomingCall> getIncomingCallItemsAt(String uri, int l
190190
}
191191
CallHierarchyItem symbol = toCallHierarchyItem(call.getMember());
192192
List<Range> ranges = toCallRanges(call.getMethodCall().getCallLocations());
193-
CallHierarchyIncomingCall incomingCall = new CallHierarchyIncomingCall();
194-
incomingCall.setFrom(symbol);
195-
incomingCall.setFromRanges(ranges.toArray(new Range[0]));
196-
result.add(incomingCall);
193+
result.add(new CallHierarchyIncomingCall(symbol, ranges));
197194
}
198195

199196
return result;
@@ -225,10 +222,7 @@ private List<CallHierarchyOutgoingCall> getOutgoingCallItemsAt(String uri, int l
225222
}
226223
CallHierarchyItem symbol = toCallHierarchyItem(call.getMember());
227224
List<Range> ranges = toCallRanges(call.getMethodCall().getCallLocations());
228-
CallHierarchyOutgoingCall outgoingCall = new CallHierarchyOutgoingCall();
229-
outgoingCall.setTo(symbol);
230-
outgoingCall.setFromRanges(ranges.toArray(new Range[0]));
231-
result.add(outgoingCall);
225+
result.add(new CallHierarchyOutgoingCall(symbol, ranges));
232226
}
233227

234228
return result;
@@ -271,7 +265,7 @@ private CallHierarchyItem toCallHierarchyItem(IMember member) throws JavaModelEx
271265
IType declaringType = member.getDeclaringType();
272266
item.setDetail(declaringType == null ? null : declaringType.getFullyQualifiedName());
273267
if (JDTUtils.isDeprecated(member)) {
274-
item.setTags(new SymbolTag[] { SymbolTag.Deprecated });
268+
item.setTags(Arrays.asList(SymbolTag.Deprecated));
275269
}
276270

277271
return item;

org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
<repository location="https://download.jboss.org/jbosstools/updates/m2e-extensions/m2e-apt/1.5.3-2019-11-08_11-04-22-H22/"/>
4444
</location>
4545
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
46-
<repository location="https://github.com/testforstephen/lsp4j/raw/p2/p2/"/>
46+
<repository location="https://download.eclipse.org/lsp4j/builds/master-new/"/>
4747
<unit id="org.eclipse.lsp4j.sdk.feature.group" version="0.0.0"/>
4848
</location>
4949
</locations>

org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CallHierarchyHandlerTest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -240,9 +240,9 @@ static CallHierarchyItem assertItem(CallHierarchyItem item, String name, SymbolK
240240
assertEquals(detail, item.getDetail());
241241
if (deprecated) {
242242
assertNotNull(item.getTags());
243-
assertTrue(Stream.of(item.getTags()).anyMatch(tag -> tag == SymbolTag.Deprecated));
243+
assertTrue(item.getTags().stream().anyMatch(tag -> tag == SymbolTag.Deprecated));
244244
} else {
245-
assertTrue(item.getTags() == null || item.getTags().length == 0 || !Stream.of(item.getTags()).anyMatch(tag -> tag == SymbolTag.Deprecated));
245+
assertTrue(item.getTags() == null || item.getTags().isEmpty() || !item.getTags().stream().anyMatch(tag -> tag == SymbolTag.Deprecated));
246246
}
247247

248248
assertEquals(selectionStartLine, item.getSelectionRange().getStart().getLine());
@@ -255,14 +255,12 @@ static List<CallHierarchyItem> prepareCallHierarchy(String uri, int line, int ch
255255
}
256256

257257
static List<CallHierarchyIncomingCall> getIncomingCalls(CallHierarchyItem item) {
258-
CallHierarchyIncomingCallsParams params = new CallHierarchyIncomingCallsParams();
259-
params.setItem(item);
258+
CallHierarchyIncomingCallsParams params = new CallHierarchyIncomingCallsParams(item);
260259
return new CallHierarchyHandler().callHierarchyIncomingCalls(params, new NullProgressMonitor());
261260
}
262261

263262
static List<CallHierarchyOutgoingCall> getOutgoings(CallHierarchyItem item) {
264-
CallHierarchyOutgoingCallsParams params = new CallHierarchyOutgoingCallsParams();
265-
params.setItem(item);
263+
CallHierarchyOutgoingCallsParams params = new CallHierarchyOutgoingCallsParams(item);
266264
return new CallHierarchyHandler().callHierarchyOutgoingCalls(params, new NullProgressMonitor());
267265
}
268266

0 commit comments

Comments
 (0)