[#381] use only system dependent line separator as seprator (#382)

* [#381] use only system dependent line separator as seprator

...for clangd options. And no spaces anymore, because they lead to
trouble when file path used in options contains spaces.
- fix invalid repo path in target as well

fixes #381

Author: ghentschke

bundles/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/clangd/internal/config/ClangdPreferredOptions.java

@@ -72,7 +72,7 @@ public List<String> additionalOptions() {
 		if (options.isBlank()) {
 			return new ArrayList<>();
 		}
-		return Arrays.asList(options.split("\\s+")); //$NON-NLS-1$
+		return Arrays.asList(options.split(System.lineSeparator()));
 	}
 
 	private String stringValue(PreferenceMetadata<?> meta) {

bundles/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/clangd/internal/ui/LspEditorUiMessages.properties

@@ -21,7 +21,7 @@ LspEditorPreferencePage_pretty_print=Pretty-print JSON output
 LspEditorPreferencePage_drivers=Drivers
 LspEditorPreferencePage_drivers_description=Comma separated list of globs for white-listing gcc-compatible drivers that are safe to execute
 LspEditorPreferencePage_additional=Additional
-LspEditorPreferencePage_additional_description=Newline or space separated list of additional options for clangd
+LspEditorPreferencePage_additional_description=Newline separated list of additional options for clangd
 LspEditorPreferencePage_browse_button=Browse...
 LspEditorPreferencePage_clangd_options_label=clangd options
 LspEditorPreferencePage_enable_project_specific=Enable project-specific settings

releng/org.eclipse.cdt.lsp.target/org.eclipse.cdt.lsp.target.target

@@ -7,7 +7,7 @@
 			<unit id="org.eclipse.license.feature.group" version="0.0.0" />
 		</location>
 		<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
-			<repository location="https://download.eclipse.org/eclipse/updates/4.34-I-builds/" />
+			<repository location="https://download.eclipse.org/eclipse/updates/4.33/" />
 			<unit id="org.eclipse.equinox.executable.feature.group" version="0.0.0" />
 			<unit id="org.eclipse.jdt.annotation" version="0.0.0" />
 			<unit id="org.eclipse.sdk.feature.group" version="0.0.0" />