Skip to content

Commit 468fc23

Browse files
committed
fix typo
1 parent d0ceff6 commit 468fc23

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/lib/homeblks_impl.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -381,9 +381,7 @@ void HomeBlocksImpl::on_hb_meta_blk_found(sisl::byte_view const& buf, void* cook
381381
}
382382

383383
++sb_->boot_cnt;
384-
385384
our_uuid_ = sb_->svc_id;
386-
387385
LOGI("HomeBlks superblock loaded, boot_cnt: {}, svc_id: {}", sb_->boot_cnt, boost::uuids::to_string(our_uuid_));
388386

389387
// avoid doing sb meta blk write in callback which will cause deadlock;

src/lib/homeblks_impl.hpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ class HomeBlocksImpl : public HomeBlocks, public VolumeManager, public std::enab
7373
std::unordered_map< std::string, shared< VolumeIndexTable > > idx_tbl_map_;
7474

7575
bool recovery_done_{false};
76-
std::mutex sb_lock_;
76+
std::mutex sb_lock_; // this lock is only used when FC is triggered;
7777
superblk< homeblks_sb_t > sb_;
7878
peer_id_t our_uuid_;
7979
shared< VolumeChunkSelector > chunk_selector_;
@@ -84,7 +84,6 @@ class HomeBlocksImpl : public HomeBlocks, public VolumeManager, public std::enab
8484
std::atomic< bool > is_restricted_{false}; // avoid taking lock in IO path;
8585

8686
folly::Promise< folly::Unit > shutdown_promise_;
87-
iomgr::io_fiber_t reaper_fiber_;
8887
iomgr::timer_handle_t vol_gc_timer_hdl_{iomgr::null_timer_handle};
8988
iomgr::timer_handle_t shutdown_timer_hdl_{iomgr::null_timer_handle};
9089

@@ -226,7 +225,7 @@ class HBFCSvcCB : public homestore::FaultContainmentCallback {
226225

227226
void on_fault_containment(const homestore::FaultContainmentEvent event, void* cookie,
228227
const std::string& reason) override {
229-
if (event == homestore::FaultContainmentEvent::ENTER_GLOABLE) {
228+
if (event == homestore::FaultContainmentEvent::ENTER_GLOBAL) {
230229
hb_->fault_containment(nullptr);
231230
LOGI("Global fault containment event received, reason: {}", reason);
232231
DEBUG_ASSERT(cookie == nullptr, "Global fault containment event should not have a cookie");

0 commit comments

Comments
 (0)