let's try a simpler MR to clean this up

Author: djeebus

packages/orchestrator/internal/template/build/hash_index.go

@@ -63,8 +63,7 @@ func saveLayerMeta(ctx context.Context, s storage.StorageProvider, cacheScope st
 		return fmt.Errorf("error marshalling layer metadata: %w", err)
 	}
 
-	buf := bytes.NewBuffer(marshaled)
-	_, err = obj.ReadFrom(buf)
+	_, err = obj.ReadFrom(marshaled)
 	if err != nil {
 		return fmt.Errorf("error writing layer metadata to object: %w", err)
 	}

packages/orchestrator/internal/template/build/template_metadata.go

@@ -77,8 +77,7 @@ func saveTemplateMetadata(ctx context.Context, s storage.StorageProvider, buildI
 		return fmt.Errorf("error marshalling template metadata: %w", err)
 	}
 
-	buf := bytes.NewBuffer(marshaled)
-	_, err = obj.ReadFrom(buf)
+	_, err = obj.ReadFrom(marshaled)
 	if err != nil {
 		return fmt.Errorf("error writing template metadata to object: %w", err)
 	}

packages/shared/pkg/storage/header/serialization.go

@@ -41,7 +41,7 @@ func (m *Metadata) NextGeneration(buildID uuid.UUID) *Metadata {
 	}
 }
 
-func Serialize(metadata *Metadata, mappings []*BuildMap) (io.Reader, error) {
+func Serialize(metadata *Metadata, mappings []*BuildMap) ([]byte, error) {
 	var buf bytes.Buffer
 
 	err := binary.Write(&buf, binary.LittleEndian, metadata)
@@ -56,7 +56,7 @@ func Serialize(metadata *Metadata, mappings []*BuildMap) (io.Reader, error) {
 		}
 	}
 
-	return &buf, nil
+	return buf.Bytes(), nil
 }
 
 func Deserialize(in io.WriterTo) (*Header, error) {

packages/shared/pkg/storage/storage.go

@@ -37,7 +37,7 @@ type StorageObjectProvider interface {
 	WriteTo(dst io.Writer) (int64, error)
 	WriteFromFileSystem(path string) error
 
-	ReadFrom(src io.Reader) (int64, error)
+	ReadFrom(data []byte) (int64, error)
 	ReadAt(buff []byte, off int64) (n int, err error)
 
 	Size() (int64, error)