Merge pull request #9 from drand/fix_signbe

fix signBE old behavior

Author: nikkolasg

.circleci/config.yml

@@ -7,8 +7,6 @@ jobs:
     docker:
       # specify the version
       - image: circleci/golang:latest
-        environment:
-          GO111MODULE: "ON"
 
       # Specify service dependencies here if necessary
       # CircleCI maintains a library of pre-built images
@@ -18,10 +16,5 @@ jobs:
     working_directory: /go/src/github.com/drand/bls12-381
     steps:
       - checkout
-      - run: 
-          name: "Setup custom environment variables"
-          command: |
-            echo 'export GO111MODULE=on' >> $BASH_ENV # Redirect MY_ENV_VAR into $BASH_ENV
-      # specify any bash command here prefixed with `run: `
       - run: go get -v -t -d ./...
       - run: go test -v ./...

kyber_test.go

@@ -327,8 +327,10 @@ func TestKyberMap(t *testing.T) {
 	expBuff := []byte{181, 210, 28, 109, 17, 179, 69, 136, 116, 26, 243, 48, 174, 161, 221, 170, 166, 117, 230, 82, 140, 126, 110, 159, 57, 19, 243, 7, 38, 137, 81, 34, 174, 180, 182, 210, 238, 114, 101, 200, 81, 127, 63, 170, 73, 213, 21, 85, 18, 61, 232, 226, 86, 7, 172, 113, 197, 213, 56, 135, 54, 170, 169, 14, 222, 79, 241, 126, 195, 10, 81, 174, 166, 210, 93, 156, 49, 6, 180, 236, 64, 89, 160, 46, 10, 167, 130, 6, 164, 183, 65, 210, 206, 221, 206, 246}
 	require.Equal(t, expBuff, g2Buff)
 
-	g1 := suite.G1().Point().(Hashable).Hash(msg)
-	g1Buff, _ := g1.MarshalBinary()
-	expBuff = []byte{150, 231, 171, 210, 107, 209, 224, 216, 101, 98, 109, 77, 204, 113, 126, 73, 8, 124, 185, 124, 96, 92, 42, 107, 94, 144, 249, 53, 19, 125, 129, 233, 243, 253, 146, 1, 74, 38, 20, 245, 206, 63, 87, 254, 52, 237, 14, 1, 227}
+	//g1 := suite.G1().Point().(Hashable).Hash(msg)
+	p, _ := NewG1().HashToCurve(msg, Domain)
+	g1Buff := NewG1().ToCompressed(p)
+
+	expBuff = []byte{150, 231, 171, 210, 107, 209, 224, 216, 101, 98, 109, 77, 204, 113, 126, 73, 8, 124, 185, 124, 96, 92, 42, 107, 94, 144, 249, 53, 19, 125, 129, 233, 243, 253, 146, 174, 38, 20, 245, 206, 63, 87, 254, 52, 237, 14, 1, 227}
 	require.Equal(t, expBuff, g1Buff)
 }

swu.go

@@ -45,7 +45,7 @@ func swuMapG1(u *fe) (*fe, *fe) {
 	}
 	y := new(fe)
 	sqrt(y, y2)
-	if y.sign() != u.sign() {
+	if y.signBE() != u.signBE() {
 		neg(y, y)
 	}
 	return x, y
@@ -109,7 +109,7 @@ func swuMapG2(e *fp2, u *fe2) (*fe2, *fe2) {
 	}
 	y := e.new()
 	e.sqrt(y, y2)
-	if y.sign() != u.sign() {
+	if y.signBE() != u.signBE() {
 		e.neg(y, y)
 	}
 	return x, y