chore: Update double-conversion library (#1793)

Add double to string coversion tests.
Patch the library to avoid using locale - because freebsd c++ lib
does not have this symbol.

Signed-off-by: Roman Gershman <[email protected]>

Author: romange

src/CMakeLists.txt

@@ -47,7 +47,11 @@ endfunction()
 
 add_third_party(
   dconv
-  URL https://github.com/google/double-conversion/archive/refs/tags/v3.2.0.tar.gz
+  URL https://github.com/google/double-conversion/archive/refs/tags/v3.3.0.tar.gz
+  PATCH_COMMAND sed -i "/static const std::ctype/d"
+                <SOURCE_DIR>/double-conversion/string-to-double.cc
+  COMMAND sed -i "/std::use_facet</d" <SOURCE_DIR>/double-conversion/string-to-double.cc
+  COMMAND sed -i "s/cType.tolower/std::tolower/g" <SOURCE_DIR>/double-conversion/string-to-double.cc
   LIB libdouble-conversion.a
 )
 

src/facade/reply_builder_test.cc

@@ -1,5 +1,11 @@
+// Copyright 2023, DragonflyDB authors.  All rights reserved.
+// See LICENSE for licensing terms.
+//
+
 #include "facade/reply_builder.h"
 
+#include <random>
+
 #include "absl/strings/str_split.h"
 #include "base/gtest.h"
 #include "base/logging.h"
@@ -11,6 +17,7 @@
 // This will test the reply_builder RESP (Redis).
 
 using namespace testing;
+using namespace std;
 
 namespace facade {
 
@@ -848,4 +855,40 @@ TEST_F(RedisReplyBuilderTest, TestBasicCapture) {
   builder_->SetResp3(false);
 }
 
+TEST_F(RedisReplyBuilderTest, FormatDouble) {
+  char buf[64];
+
+  auto format = [&](double d) { return RedisReplyBuilder::FormatDouble(d, buf, sizeof(buf)); };
+
+  EXPECT_STREQ("0.1", format(0.1));
+  EXPECT_STREQ("0.2", format(0.2));
+  EXPECT_STREQ("0.8", format(0.8));
+  EXPECT_STREQ("1.1", format(1.1));
+  EXPECT_STREQ("inf", format(INFINITY));
+  EXPECT_STREQ("-inf", format(-INFINITY));
+  EXPECT_STREQ("0", format(-0.0));
+  EXPECT_STREQ("1e-7", format(0.0000001));
+  EXPECT_STREQ("111111111111111110000", format(111111111111111111111.0));
+  EXPECT_STREQ("1.1111111111111111e+21", format(1111111111111111111111.0));
+  EXPECT_STREQ("1e-23", format(1e-23));
+}
+
+static void BM_FormatDouble(benchmark::State& state) {
+  vector<double> values;
+  char buf[64];
+
+  uniform_real_distribution<double> unif(0, 1e9);
+  default_random_engine re;
+  for (unsigned i = 0; i < 100; i++) {
+    values.push_back(unif(re));
+  }
+
+  while (state.KeepRunning()) {
+    for (auto d : values) {
+      RedisReplyBuilder::FormatDouble(d, buf, sizeof(buf));
+    }
+  }
+}
+BENCHMARK(BM_FormatDouble);
+
 }  // namespace facade