chore: Add option to disable aws dependency (#3077)

Signed-off-by: Vladislav Oleshko <[email protected]>

Author: dranikpg

src/server/CMakeLists.txt

@@ -77,8 +77,12 @@ endif()
 
 find_library(ZSTD_LIB NAMES libzstd.a libzstdstatic.a zstd NAMES_PER_DIR REQUIRED)
 
+if (WITH_AWS)
+  SET(AWS_LIB awsv2_lib)
+endif()
+
 cxx_link(dfly_transaction dfly_core strings_lib TRDP::fast_float)
-cxx_link(dragonfly_lib dfly_transaction dfly_facade redis_lib awsv2_lib jsonpath
+cxx_link(dragonfly_lib dfly_transaction dfly_facade redis_lib ${AWS_LIB} jsonpath
          strings_lib html_lib
          http_client_lib absl::random_random TRDP::jsoncons ${ZSTD_LIB} TRDP::lz4
          TRDP::croncpp TRDP::flatbuffers)

src/server/detail/snapshot_storage.cc

@@ -5,21 +5,25 @@
 
 #include <absl/strings/str_replace.h>
 #include <absl/strings/strip.h>
+
+#ifdef WITH_AWS
 #include <aws/core/auth/AWSCredentialsProvider.h>
 #include <aws/s3/S3Client.h>
 #include <aws/s3/model/ListObjectsV2Request.h>
 #include <aws/s3/model/PutObjectRequest.h>
 
-#include <regex>
-
-#include "base/logging.h"
-#include "io/file_util.h"
-#include "server/engine_shard_set.h"
 #include "util/aws/aws.h"
 #include "util/aws/credentials_provider_chain.h"
 #include "util/aws/s3_endpoint_provider.h"
 #include "util/aws/s3_read_file.h"
 #include "util/aws/s3_write_file.h"
+#endif
+
+#include <regex>
+
+#include "base/logging.h"
+#include "io/file_util.h"
+#include "server/engine_shard_set.h"
 #include "util/fibers/fiber_file.h"
 
 namespace dfly {
@@ -173,6 +177,7 @@ io::Result<std::vector<std::string>, GenericError> FileSnapshotStorage::LoadPath
   return paths;
 }
 
+#ifdef WITH_AWS
 AwsS3SnapshotStorage::AwsS3SnapshotStorage(const std::string& endpoint, bool https,
                                            bool ec2_metadata, bool sign_payload) {
   shard_set->pool()->GetNextProactor()->Await([&] {
@@ -375,6 +380,7 @@ AwsS3SnapshotStorage::ListObjects(std::string_view bucket_name, std::string_view
   } while (!continuation_token.empty());
   return keys;
 }
+#endif
 
 #ifdef __linux__
 io::Result<size_t> LinuxWriteWrapper::WriteSome(const iovec* v, uint32_t len) {

src/server/detail/snapshot_storage.h

@@ -3,7 +3,9 @@
 
 #pragma once
 
+#ifdef WITH_AWS
 #include <aws/s3/S3Client.h>
+#endif
 
 #include <filesystem>
 #include <string>
@@ -70,6 +72,7 @@ class FileSnapshotStorage : public SnapshotStorage {
   util::fb2::FiberQueueThreadPool* fq_threadpool_;
 };
 
+#ifdef WITH_AWS
 class AwsS3SnapshotStorage : public SnapshotStorage {
  public:
   AwsS3SnapshotStorage(const std::string& endpoint, bool https, bool ec2_metadata,
@@ -104,6 +107,7 @@ class AwsS3SnapshotStorage : public SnapshotStorage {
 
 // Returns bucket_name, obj_path for an s3 path.
 std::optional<std::pair<std::string, std::string>> GetBucketPath(std::string_view path);
+#endif
 
 #ifdef __linux__
 // takes ownership over the file.

src/server/server_family.cc

@@ -770,10 +770,14 @@ void ServerFamily::Init(util::AcceptServer* acceptor, std::vector<facade::Listen
 
   string flag_dir = GetFlag(FLAGS_dir);
   if (IsCloudPath(flag_dir)) {
+#ifdef WITH_AWS
     shard_set->pool()->GetNextProactor()->Await([&] { util::aws::Init(); });
     snapshot_storage_ = std::make_shared<detail::AwsS3SnapshotStorage>(
         absl::GetFlag(FLAGS_s3_endpoint), absl::GetFlag(FLAGS_s3_use_https),
         absl::GetFlag(FLAGS_s3_ec2_metadata), absl::GetFlag(FLAGS_s3_sign_payload));
+#else
+    LOG(ERROR) << "Compiled without AWS support";
+#endif
   } else if (fq_threadpool_) {
     snapshot_storage_ = std::make_shared<detail::FileSnapshotStorage>(fq_threadpool_.get());
   } else {