Skip to content

Tidy up performance tests #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Tidy up performance tests #3230

merged 2 commits into from
Mar 24, 2025

Conversation

paulmedynski
Copy link
Contributor

  • Tidied up the existing Performance benchmarks.
  • Added environment variables to specify config files.
  • Removed Newtonsoft.Json as a dependency.
  • Simplified csproj a bit.

- Tidied up the existing Performance benchmarks.
- Added environment variables to specify config files.
- Removed Newtonsoft.Json as a dependency.
- Simplified csproj a bit.
@paulmedynski paulmedynski requested a review from Copilot March 19, 2025 17:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR tidies up the performance tests by refactoring configuration loading, removing the Newtonsoft.Json dependency, and simplifying project files.

  • Introduces a new JSON configuration loader using System.Text.Json.
  • Updates performance test configuration for benchmarks and data types across several files.
  • Revises the BUILDGUIDE to include instructions for setting up the runner configuration and an empty database.

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/Loader.cs Adds a utility to load JSON configs with environment variable overrides.
BUILDGUIDE.md Updates usage instructions for benchmarks and configuration management.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/DataTypes.cs Introduces a Load() method to load data types configuration.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/Config.cs Adds a Load() method for benchmark configuration.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/Program.cs Refactors config loading and benchmark execution from a static context to an instance context.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/BaseRunner.cs Replaces Newtonsoft.Json deserialization with the new Loader API.
Files not reviewed (2)
  • src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj: Language not supported
  • tools/props/Versions.props: Language not supported

@paulmedynski paulmedynski requested a review from a team March 19, 2025 17:19
@paulmedynski paulmedynski marked this pull request as ready for review March 19, 2025 17:20
@paulmedynski paulmedynski added this to the 7.0-preview1 milestone Mar 19, 2025
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.92%. Comparing base (f3ae72a) to head (55938e5).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3230      +/-   ##
==========================================
+ Coverage   72.73%   72.92%   +0.18%     
==========================================
  Files         288      303      +15     
  Lines       59527    59527              
==========================================
+ Hits        43298    43409     +111     
+ Misses      16229    16118     -111     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.33% <ø> (+0.14%) ⬆️
netfx 71.51% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Improved benchmark running instructions.
@paulmedynski paulmedynski requested a review from a team March 20, 2025 11:50
This was referenced Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants