JIT: Remove old loop code #97232
JIT: Remove old loop code #97232
Conversation
All dependencies on old loop finding have been removed, so remove all old code associated with it.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAll dependencies on old loop finding have been removed, so remove all old code associated with it. No diffs expected. Some TP improvements expected from removing old loop finding and from removing a DFS of the flow graph.
|
|
No asm diffs; significant TP improvements. |
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
Congrats on getting this far so quickly!
| void Compiler::fgDebugCheckLoopTable() | ||
| { | ||
| if ((m_loops != nullptr) && optLoopsRequirePreHeaders) | ||
| if (m_loops == nullptr) |
There was a problem hiding this comment.
Looks like the header comment above needs to be updated?
There was a problem hiding this comment.
Done. Also rephrased a few other things (removed references to "loop table") and deleted the loop flag enum that had been left over.
|
cc @dotnet/jit-contrib |
Thanks! There's still some regressions to investigate, but overall I'm happy with how this ended up, and now I have a very good understanding of how all the pieces fit together :-) |
All dependencies on old loop finding have been removed, so remove all old code associated with it.
2 participants
All dependencies on old loop finding have been removed, so remove all old code associated with it.
No diffs expected. Some TP improvements expected from removing old loop finding and from removing a DFS of the flow graph.