[RISC-V] Atomics #92102
Merged
[RISC-V] Atomics #92102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAdd atomic instructions (RV64A) to JIT. Part of #84834
|
Member
Author
|
@jakobbotsch @jkotas PR ready for review. |
t-mustafin
reviewed
Sep 18, 2023
t-mustafin
approved these changes
Sep 19, 2023
Member
Author
|
@jakobbotsch @jkotas Could you look at this, please? |
Member
|
cc @dotnet/jit-contrib |
jakobbotsch
reviewed
Sep 19, 2023
jakobbotsch
reviewed
Sep 19, 2023
jakobbotsch
reviewed
Sep 19, 2023
jakobbotsch
reviewed
Sep 19, 2023
jakobbotsch
reviewed
Sep 19, 2023
clamp03
suggested changes
Sep 19, 2023
Member
clamp03
left a comment
clamp03
left a comment
There was a problem hiding this comment.
Could you share tests to fix?
Please check the style and naming of existing sources? Please~~~
Member
Author
I stumbled on lack of atomics in JIT looking for Yes, I'll adjust style as per remarks in comments. |
Member
To be clear, this is just an optimization, right? Not recognizing these as intrinsics should usually just result in the managed fallback, so these tests aren't broken on RISC-V. |
Member
Author
Exactly. |
clamp03
approved these changes
Sep 20, 2023
Member
clamp03
left a comment
clamp03
left a comment
There was a problem hiding this comment.
Thank you so much.
I know my initial codes are not good enough. I am so sorry for that. But that is the reason why we need you. Thank you for all your hard work.
jakobbotsch
reviewed
Sep 20, 2023
Co-authored-by: Jakob Botsch Nielsen <[email protected]>
jakobbotsch
approved these changes
Sep 20, 2023
Member
|
Please check CI build failures before merging. |
Member
|
SPMI failures are the out-of-space ones we have been hitting recently. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add atomic instructions (RV64A) to JIT.
Intrinsify calls to Interlocked.ExchangeAdd|Exchange|And|Or|CompareExchange.
Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov @clamp03 @sirntar @yurai007