Skip to content

[browser] Use Wasm SDK in browser template #85311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

[browser] Use Wasm SDK in browser template #85311

wants to merge 10 commits into from

Conversation

@maraf
Copy link
Member

@maraf maraf commented Apr 25, 2023 •
edited
Loading

  • Update browser template to use Wasm SDK
  • Use Blazor DevServer to run browser template
  • Rename mono-config to blazor.boot.json to unify location where to load config from
  • Update Wasm.Build.Tests

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels Apr 25, 2023
@maraf maraf added this to the 8.0.0 milestone Apr 25, 2023
@maraf maraf self-assigned this Apr 25, 2023
@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Update browser template to use Wasm SDK
  • Use Blazor DevServer to run browser template
  • Update Wasm.Build.Tests
Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono
Milestone: 8.0.0

@maraf maraf changed the title [browser] User Wasm SDK in browser template [browser] Use Wasm SDK in browser template Apr 25, 2023
maraf
maraf commented Apr 25, 2023
View reviewed changes
src/mono/wasm/templates/templates/browser/browser.0.csproj Outdated
Copy link
Member Author

@maraf maraf Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radical @lewing Is there a way to manage this version?

Copy link
Member

@lewing lewing Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of a good one at the moment :/

Copy link
Member

@lambdageek lambdageek Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aspnetcore uses .csproj.in template files and fills them in with a generated version. https://github.com/dotnet/aspnetcore/blob/015ceab6aeec700fbfb71cdfe9ff8fb51831d555/src/ProjectTemplates/Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj

Copy link
Member Author

@maraf maraf Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does our versions always match?

@maraf maraf marked this pull request as draft April 25, 2023 13:13
maraf
maraf commented Apr 25, 2023
View reviewed changes
src/mono/wasm/templates/templates/browser/wwwroot/main.js Outdated
Copy link
Member Author

@maraf maraf Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporal and shouldn't be in template

This was referenced Apr 25, 2023
Closed
Closed
@radical radical mentioned this pull request Apr 28, 2023
Closed
@maraf maraf force-pushed the WasmSdkTemplate branch from 9ce4c0b to 0521238 Compare April 30, 2023 05:28
This was referenced Apr 30, 2023
Closed
Closed
@maraf
Copy link
Member Author

maraf commented May 4, 2023

Closed in favor of #85498

@maraf maraf closed this May 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2023
@maraf maraf deleted the WasmSdkTemplate branch January 18, 2024 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageek lambdageek lambdageek left review comments

@radical radical Awaiting requested review from radical

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@kg kg Awaiting requested review from kg

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger will be requested when the pull request is marked ready for review akoeplinger is a code owner

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy will be requested when the pull request is marked ready for review ilonatommy is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@maraf @lewing @lambdageek