Re-enable some binary specifier tests (#117304)

stephentoub · web-flow · commit 9960415cd5b1 · 2025-07-04T07:45:45.000-04:00
diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Int128Tests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Int128Tests.cs
@@ -365,8 +365,7 @@ public static IEnumerable<object[]> Parse_Invalid_TestData()
             foreach (object[] objs in Int32Tests.Parse_Invalid_TestData())
             {
                 if ((Type)objs[3] == typeof(OverflowException) &&
-                    (((NumberStyles)objs[1] & NumberStyles.AllowBinarySpecifier) != 0 || // TODO https://github.com/dotnet/runtime/issues/83619: Remove once BigInteger supports binary parsing
-                     !BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) ||
+                    (!BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) ||
                      (bi >= Int128.MinValue && bi <= Int128.MaxValue)))
                 {
                     continue;
diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Int64Tests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Int64Tests.cs
@@ -303,8 +303,7 @@ public static IEnumerable<object[]> Parse_Invalid_TestData()
             foreach (object[] objs in Int32Tests.Parse_Invalid_TestData())
             {
                 if ((Type)objs[3] == typeof(OverflowException) &&
-                    (((NumberStyles)objs[1] & NumberStyles.AllowBinarySpecifier) != 0 || // TODO https://github.com/dotnet/runtime/issues/83619: Remove once BigInteger supports binary parsing
-                     !BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) ||
+                    (!BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) ||
                      (bi >= long.MinValue && bi <= long.MaxValue)))
                 {
                     continue;
diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/UInt128Tests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/UInt128Tests.cs
@@ -294,8 +294,7 @@ public static IEnumerable<object[]> Parse_Invalid_TestData()
             foreach (object[] objs in Int128Tests.Parse_Invalid_TestData())
             {
                 if ((Type)objs[3] == typeof(OverflowException) &&
-                    (((NumberStyles)objs[1] & NumberStyles.AllowBinarySpecifier) != 0 || // TODO https://github.com/dotnet/runtime/issues/83619: Remove once BigInteger supports binary parsing
-                     !BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) ||
+                    (!BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) ||
                      bi <= UInt128.MaxValue))
                 {
                     continue;
diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/UInt64Tests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/UInt64Tests.cs
@@ -276,8 +276,7 @@ public static IEnumerable<object[]> Parse_Invalid_TestData()
             foreach (object[] objs in Int64Tests.Parse_Invalid_TestData())
             {
                 if ((Type)objs[3] == typeof(OverflowException) &&
-                    (((NumberStyles)objs[1] & NumberStyles.AllowBinarySpecifier) != 0 || // TODO https://github.com/dotnet/runtime/issues/83619: Remove once BigInteger supports binary parsing
-                     !BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) ||
+                    (!BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) ||
                      bi <= ulong.MaxValue))
                 {
                     continue;

Original file line number	Diff line number	Diff line change
`@@ -365,8 +365,7 @@ public static IEnumerable<object[]> Parse_Invalid_TestData()`
`365`	`365`	`foreach (object[] objs in Int32Tests.Parse_Invalid_TestData())`
`366`	`366`	`{`
`367`	`367`	`if ((Type)objs[3] == typeof(OverflowException) &&`
`368`		`- (((NumberStyles)objs[1] & NumberStyles.AllowBinarySpecifier) != 0 \|\| // TODO https://github.com/dotnet/runtime/issues/83619: Remove once BigInteger supports binary parsing`
`369`		`- !BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) \|\|`
	`368`	`+ (!BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) \|\|`
`370`	`369`	`(bi >= Int128.MinValue && bi <= Int128.MaxValue)))`
`371`	`370`	`{`
`372`	`371`	`continue;`
Original file line number	Diff line number	Diff line change
`@@ -303,8 +303,7 @@ public static IEnumerable<object[]> Parse_Invalid_TestData()`
`303`	`303`	`foreach (object[] objs in Int32Tests.Parse_Invalid_TestData())`
`304`	`304`	`{`
`305`	`305`	`if ((Type)objs[3] == typeof(OverflowException) &&`
`306`		`- (((NumberStyles)objs[1] & NumberStyles.AllowBinarySpecifier) != 0 \|\| // TODO https://github.com/dotnet/runtime/issues/83619: Remove once BigInteger supports binary parsing`
`307`		`- !BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) \|\|`
	`306`	`+ (!BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) \|\|`
`308`	`307`	`(bi >= long.MinValue && bi <= long.MaxValue)))`
`309`	`308`	`{`
`310`	`309`	`continue;`
Original file line number	Diff line number	Diff line change
`@@ -294,8 +294,7 @@ public static IEnumerable<object[]> Parse_Invalid_TestData()`
`294`	`294`	`foreach (object[] objs in Int128Tests.Parse_Invalid_TestData())`
`295`	`295`	`{`
`296`	`296`	`if ((Type)objs[3] == typeof(OverflowException) &&`
`297`		`- (((NumberStyles)objs[1] & NumberStyles.AllowBinarySpecifier) != 0 \|\| // TODO https://github.com/dotnet/runtime/issues/83619: Remove once BigInteger supports binary parsing`
`298`		`- !BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) \|\|`
	`297`	`+ (!BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) \|\|`
`299`	`298`	`bi <= UInt128.MaxValue))`
`300`	`299`	`{`
`301`	`300`	`continue;`
Original file line number	Diff line number	Diff line change
`@@ -276,8 +276,7 @@ public static IEnumerable<object[]> Parse_Invalid_TestData()`
`276`	`276`	`foreach (object[] objs in Int64Tests.Parse_Invalid_TestData())`
`277`	`277`	`{`
`278`	`278`	`if ((Type)objs[3] == typeof(OverflowException) &&`
`279`		`- (((NumberStyles)objs[1] & NumberStyles.AllowBinarySpecifier) != 0 \|\| // TODO https://github.com/dotnet/runtime/issues/83619: Remove once BigInteger supports binary parsing`
`280`		`- !BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) \|\|`
	`279`	`+ (!BigInteger.TryParse((string)objs[0], (NumberStyles)objs[1], null, out BigInteger bi) \|\|`
`281`	`280`	`bi <= ulong.MaxValue))`
`282`	`281`	`{`
`283`	`282`	`continue;`