Take process lock earlier (#105280)

Author: AaronRobinsonMSFT

src/coreclr/debug/di/divalue.cpp

@@ -2691,22 +2691,22 @@ HRESULT CordbObjectValue::GetFunctionHelper(ICorDebugFunction **ppFunction)
     if (hr != S_OK)
         return hr;
 
-    mdMethodDef functionMethodDef = 0;
-    VMPTR_DomainAssembly functionDomainAssembly;
-    NativeCodeFunctionData nativeCodeForDelFunc;
-
-    hr = pDAC->GetDelegateFunctionData(delType, pDelegateObj, &functionDomainAssembly, &functionMethodDef);
-    if (hr != S_OK)
-        return hr;
-
-    // TODO: How to ensure results are sanitized?
-    // Also, this is expensive. Do we really care that much about this?
-    pDAC->GetNativeCodeInfo(functionDomainAssembly, functionMethodDef, &nativeCodeForDelFunc);
-
-    RSSmartPtr<CordbModule> funcModule(GetProcess()->LookupOrCreateModule(functionDomainAssembly));
     RSSmartPtr<CordbFunction> func;
     {
         RSLockHolder lockHolder(GetProcess()->GetProcessLock());
+
+        VMPTR_DomainAssembly functionDomainAssembly;
+        mdMethodDef functionMethodDef = 0;
+        hr = pDAC->GetDelegateFunctionData(delType, pDelegateObj, &functionDomainAssembly, &functionMethodDef);
+        if (hr != S_OK)
+            return hr;
+
+        // TODO: How to ensure results are sanitized?
+        // Also, this is expensive. Do we really care that much about this?
+        NativeCodeFunctionData nativeCodeForDelFunc;
+        pDAC->GetNativeCodeInfo(functionDomainAssembly, functionMethodDef, &nativeCodeForDelFunc);
+
+        RSSmartPtr<CordbModule> funcModule(GetProcess()->LookupOrCreateModule(functionDomainAssembly));
         func.Assign(funcModule->LookupOrCreateFunction(functionMethodDef, nativeCodeForDelFunc.encVersion));
     }