Skip to content

Commit 332906e

Browse files
committed
Merge branch 'main' into zbs
Conflicts: src/coreclr/inc/jiteeversionguid.h src/coreclr/inc/readytoruninstructionset.h src/coreclr/tools/Common/Internal/Runtime/ReadyToRunInstructionSet.cs
2 parents 848c99e + 6278b81 commit 332906e

File tree

302 files changed

+8592
-3952
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

302 files changed

+8592
-3952
lines changed

docs/design/coreclr/botr/clr-abi.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,12 @@ To return `Continuation` we use a volatile/calee-trash register that cannot be u
116116
| risc-v | a2 |
117117

118118
### Passing `Continuation` argument
119-
The `Continuation` parameter is passed at the same position as generic instantiation parameter or immediately after, if both present.
119+
The `Continuation` parameter is passed at the same position as generic instantiation parameter or immediately after, if both present. For x86 the argument order is reversed.
120120

121121
```
122122
call(["this" pointer] [return buffer pointer] [generics context] [continuation] [userargs]) // not x86
123123
124-
call(["this" pointer] [return buffer pointer] [userargs] [generics context] [continuation]) // x86
124+
call(["this" pointer] [return buffer pointer] [userargs] [continuation] [generics context]) // x86
125125
```
126126

127127
## AMD64-only: by-value value types

eng/RuntimeIdentifier.props

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
<!-- On Windows, we can build for Windows and Mobile.
2424
For other TargetOSes, create a "win" build, built from TargetOS sources and "win" pre-built packages. -->
2525
<PortableOS Condition="'$(HostOS)' == 'win' and '$(TargetsMobile)' != 'true'">win</PortableOS>
26+
27+
<PortableTargetRid Condition="'$(PortableTargetRid)' == ''">$(PortableOS)-$(TargetArchitecture)</PortableTargetRid>
2628
</PropertyGroup>
2729

2830
<!-- TargetRid is used to name the target platform.

eng/Subsets.props

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,6 @@
8282
<DefaultSubsets Condition="'$(DotNetBuildPass)' == '2' and '$(TargetOS)' == 'windows' and '$(TargetArchitecture)' == 'x86'">crossdacpack</DefaultSubsets>
8383
</PropertyGroup>
8484

85-
<PropertyGroup>
86-
<!-- In .NET product build mode we want to build all of the assets even in a PGO-instrumented build as downstream repos will not be able to pull assets from a matching non-PGO-instrumented build. -->
87-
<BuildOnlyPgoInstrumentedAssets Condition="'$(PgoInstrument)' == 'true' and '$(DotNetBuild)' != 'true'">true</BuildOnlyPgoInstrumentedAssets>
88-
</PropertyGroup>
89-
9085
<PropertyGroup Condition="'$(BuildMonoAOTCrossCompilerOnly)' == 'true' or ('$(DotNetBuildAllRuntimePacks)' == 'true' and '$(MonoAOTCrossCompilerSupported)' == 'true')">
9186
<MonoCrossAOTTargetOS>android+browser+wasi</MonoCrossAOTTargetOS>
9287
<MonoCrossAOTTargetOS Condition="'$(TargetOS)' == 'osx'">$(MonoCrossAOTTargetOS)+tvos+ios+maccatalyst</MonoCrossAOTTargetOS>
@@ -522,7 +517,7 @@
522517
<ProjectToBuild Include="$(CoreClrProjectRoot)crossgen-corelib.proj" Category="clr" />
523518
</ItemGroup>
524519

525-
<ItemGroup Condition="$(_subset.Contains('+clr.packages+')) and '$(BuildOnlyPgoInstrumentedAssets)' != 'true'">
520+
<ItemGroup Condition="$(_subset.Contains('+clr.packages+'))">
526521
<ProjectToBuild Include="$(CoreClrProjectRoot).nuget\coreclr-packages.proj" Category="clr" />
527522
</ItemGroup>
528523

@@ -578,7 +573,7 @@
578573
<ProjectToBuild Include="@(ManagedProjectToBuild)" BuildInParallel="true" Category="host" />
579574
</ItemGroup>
580575

581-
<ItemGroup Condition="$(_subset.Contains('+host.pkg+')) and '$(BuildOnlyPgoInstrumentedAssets)' != 'true'">
576+
<ItemGroup Condition="$(_subset.Contains('+host.pkg+'))">
582577
<PkgprojProjectToBuild Include="$(InstallerProjectRoot)pkg\projects\host-packages.proj" />
583578
<ProjectToBuild Include="@(PkgprojProjectToBuild)" Category="host" />
584579
</ItemGroup>
@@ -635,11 +630,6 @@
635630
<Choose>
636631
<When Condition="$(_subset.Contains('+packs.product+'))">
637632
<Choose>
638-
<When Condition="'$(BuildOnlyPgoInstrumentedAssets)' == 'true'">
639-
<ItemGroup>
640-
<ProjectToBuild Include="$(InstallerProjectRoot)pkg\sfx\bundle\Microsoft.NETCore.App.Bundle.bundleproj" Category="packs" />
641-
</ItemGroup>
642-
</When>
643633
<When Condition="'$(BuildMonoAOTCrossCompilerOnly)' == 'true'">
644634
<ItemGroup Condition="'$(MonoCrossAOTTargetOS)' != ''">
645635
<ProjectToBuild Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\monocrossaot.proj" Category="packs" />
@@ -650,8 +640,7 @@
650640
<_BuildCoreCLRRuntimePack Condition="'$(RuntimeFlavor)' == 'CoreCLR' and '$(CoreCLRSupported)' == 'true'">true</_BuildCoreCLRRuntimePack>
651641
<_BuildMonoRuntimePack Condition="'$(RuntimeFlavor)' == 'Mono' and '$(MonoSupported)' == 'true'">true</_BuildMonoRuntimePack>
652642
<_BuildHostPack Condition="'$(RuntimeFlavor)' == '$(PrimaryRuntimeFlavor)' and '$(TargetsMobile)' != 'true'">true</_BuildHostPack>
653-
<_BuildCdacPack Condition="'$(_CDacToolsBuilt)' == 'true' and '$(RuntimeFlavor)' == 'CoreCLR' and '$(TargetsMobile)' != 'true' and '$(TargetsLinuxMusl)' != 'true' and ('$(TargetOS)' == 'windows' or '$(TargetOS)' == 'osx' or '$(TargetOS)' == 'linux')">true</_BuildCdacPack>
654-
<_BuildCdacPack Condition="'$(DotNetBuildSourceOnly)' == 'true' or '$(TargetArchitecture)' == 'arm' or '$(TargetArchitecture)' == 'armel' or '$(TargetArchitecture)' == 'x86' or '$(TargetArchitecture)' == 'riscv64'">false</_BuildCdacPack>
643+
<_BuildCdacPack Condition="'$(_CDacToolsBuilt)' == 'true' and '$(RuntimeFlavor)' == 'CoreCLR' and '$(TargetsMobile)' != 'true' and ('$(TargetOS)' == 'windows' or '$(TargetOS)' == 'osx' or '$(TargetOS)' == 'linux')">true</_BuildCdacPack>
655644
<_BuildBundle Condition="'$(RuntimeFlavor)' == '$(PrimaryRuntimeFlavor)' and '$(TargetsMobile)' != 'true'">true</_BuildBundle>
656645
</PropertyGroup>
657646

@@ -709,12 +698,12 @@
709698
</When>
710699
</Choose>
711700

712-
<ItemGroup Condition="$(_subset.Contains('+packs.installers+')) AND '$(BuildOnlyPgoInstrumentedAssets)' != 'true'">
701+
<ItemGroup Condition="$(_subset.Contains('+packs.installers+'))">
713702
<InstallerProjectToBuild Include="$(InstallerProjectRoot)pkg\sfx\installers.proj" />
714703
<ProjectToBuild Include="@(InstallerProjectToBuild)" Category="packs" />
715704
</ItemGroup>
716705

717-
<ItemGroup Condition="$(_subset.Contains('+packs.tests+')) AND '$(BuildOnlyPgoInstrumentedAssets)' != 'true'">
706+
<ItemGroup Condition="$(_subset.Contains('+packs.tests+'))">
718707
<TestProjectToBuild Include="$(InstallerProjectRoot)tests\Microsoft.DotNet.CoreSetup.Packaging.Tests\Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj" />
719708
<ProjectToBuild Include="@(TestProjectToBuild)" BuildInParallel="true" Test="true" Category="packs" />
720709
</ItemGroup>

0 commit comments

Comments
 (0)