Skip to content

Commit 1edca5a

Browse files
committed
NetCoreAppCurrentVersion, ProductVersion, ContinuousIntegrationBuild to CMake
1 parent fe0988b commit 1edca5a

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

eng/native/configurepaths.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ get_filename_component(CLR_REPO_ROOT_DIR ${CMAKE_CURRENT_LIST_DIR}/../.. ABSOLUT
22
set(CLR_ENG_NATIVE_DIR ${CMAKE_CURRENT_LIST_DIR})
33
get_filename_component(CLR_SRC_NATIVE_DIR ${CMAKE_CURRENT_LIST_DIR}/../../src/native ABSOLUTE)
44
set (CLR_ARTIFACTS_OBJ_DIR "${CLR_REPO_ROOT_DIR}/artifacts/obj")
5+
set (CLR_ARTIFACTS_BIN_DIR "${CLR_REPO_ROOT_DIR}/artifacts/bin")
56
set (CLR_SOURCELINK_FILE_PATH "${CLR_ARTIFACTS_OBJ_DIR}/native.sourcelink.json")
67
set(VERSION_HEADER_PATH "${CLR_ARTIFACTS_OBJ_DIR}/_version.h")
78
set(VERSION_FILE_PATH "${CLR_ARTIFACTS_OBJ_DIR}/_version.c")

src/coreclr/runtime.proj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@
5656
<_CoreClrBuildArg Condition="'$(HasCdacBuildTool)' == 'true'" Include="-cmakeargs &quot;-DCDAC_BUILD_TOOL_BINARY_PATH=$(RuntimeBinDir)cdac-build-tool\cdac-build-tool.dll&quot;" />
5757
<_CoreClrBuildArg Condition="'$(_IcuDir)' != ''" Include="-cmakeargs &quot;-DCMAKE_ICU_DIR=$(_IcuDir)&quot;" />
5858
<_CoreClrBuildArg Condition="'$(_TzdDir)' != ''" Include="-cmakeargs &quot;-DCMAKE_TZD_DIR=$(_TzdDir)&quot;" />
59+
<_CoreClrBuildArg Include="-cmakeargs &quot;-DCMAKE_NET_CORE_APP_CURRENT_VERSION=$(NetCoreAppCurrentVersion)&quot;" />
60+
<_CoreClrBuildArg Include="-cmakeargs &quot;-DCMAKE_PRODUCT_VERSION=$(ProductVersion)&quot;" />
61+
<_CoreClrBuildArg Include="-cmakeargs &quot;-DCMAKE_CONTINUOUS_INTEGRATION_BUILD=$(ContinuousIntegrationBuild)&quot;" />
5962
<_CoreClrBuildArg Condition="'$(FeatureXplatEventSource)' == 'false'" Include="-cmakeargs &quot;-DFEATURE_EVENTSOURCE_XPLAT=0&quot;" />
6063
</ItemGroup>
6164

src/native/libs/System.Native.Browser/CMakeLists.txt

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,19 +48,10 @@ set(ROLLUP_STAMP
4848
"${CLR_ARTIFACTS_OBJ_DIR}/coreclr/browser.wasm.${CMAKE_BUILD_TYPE}/corehost/.rollup.stamp"
4949
)
5050

51-
if(NOT PRODUCT_VERSION_JS)
52-
# WASM-TODO get dotnet ProductVersion from MSBuild
53-
set(PRODUCT_VERSION_JS "10.0.0-dev")
54-
endif()
55-
if(NOT CI_BUILD_JS)
56-
# WASM-TODO get ContinuousIntegrationBuild from MSBuild
57-
set(CI_BUILD_JS "false")
58-
endif()
59-
6051
add_custom_command(
6152
OUTPUT ${ROLLUP_STAMP}
6253
BYPRODUCTS ${ROLLUP_OUTPUTS}
63-
COMMAND npm run rollup:cmake -- "Configuration:${CMAKE_BUILD_TYPE},ProductVersion:${PRODUCT_VERSION_JS},ContinuousIntegrationBuild:${CI_BUILD_JS}"
54+
COMMAND npm run rollup:cmake -- "Configuration:${CMAKE_BUILD_TYPE},ProductVersion:${CMAKE_PRODUCT_VERSION},ContinuousIntegrationBuild:${CMAKE_CONTINUOUS_INTEGRATION_BUILD}"
6455
WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/../.."
6556
COMMENT "Running 'npm run rollup' to generate JavaScript bundles"
6657
DEPENDS ${ROLLUP_TS_SOURCES}

src/native/libs/build-native.proj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@
2020
<_CMakeArgs Condition="'$(WasmEnableThreads)' == 'true'">$(_CMakeArgs) -cmakeargs "-DCMAKE_USE_PTHREADS=1"</_CMakeArgs>
2121
<_CMakeArgs Condition="'$(_IcuDir)' != ''">$(_CMakeArgs) -cmakeargs "-DCMAKE_ICU_DIR=$(_IcuDir)"</_CMakeArgs>
2222
<_CMakeArgs Condition="'$(_TzdDir)' != ''">$(_CMakeArgs) -cmakeargs "-DCMAKE_TZD_DIR=$(_TzdDir)"</_CMakeArgs>
23+
<_CMakeArgs>$(_CMakeArgs) -cmakeargs "-DCMAKE_NET_CORE_APP_CURRENT_VERSION=$(NetCoreAppCurrentVersion)"</_CMakeArgs>
24+
<_CMakeArgs>$(_CMakeArgs) -cmakeargs "-DCMAKE_PRODUCT_VERSION=$(ProductVersion)"</_CMakeArgs>
25+
<_CMakeArgs>$(_CMakeArgs) -cmakeargs "-DCMAKE_CONTINUOUS_INTEGRATION_BUILD=$(ContinuousIntegrationBuild)"</_CMakeArgs>
2326

2427
<_BuildNativeArgs>$(_BuildNativeArgs)$(_CMakeArgs)</_BuildNativeArgs>
2528
</PropertyGroup>

0 commit comments

Comments
 (0)