Fix analyzer RCS1250: Don't suggest a collection expression for the Dictionary (#1652)

* Fix analyzer RCS1250: Don't suggest a collection expression for the Dictionary

* Update ChangeLog.md

* Update ChangeLog.md

---------

Co-authored-by: Josef Pihrt <[email protected]>

Author: aihnatiuk

ChangeLog.md

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Fix analyzer [RCS1264](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1264) ([PR](https://github.com/dotnet/roslynator/pull/1666))
 - Fix analyzer [RCS1229](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1229) ([PR](https://github.com/dotnet/roslynator/pull/1667))
+- Fix analyzer [RCS1250](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1250) ([PR](https://github.com/dotnet/roslynator/pull/1652) by @aihnatiuk)
 
 ## [4.13.1] - 2025-02-23
 

src/Analyzers/CSharp/Analysis/ObjectCreation/ImplicitOrExplicitObjectCreationAnalysis.cs

@@ -59,7 +59,10 @@ protected override bool UseCollectionExpressionFromImplicit(ref SyntaxNodeAnalys
         var implicitObjectCreation = (ImplicitObjectCreationExpressionSyntax)context.Node;
 
         return implicitObjectCreation.ArgumentList?.Arguments.Any() != true
-            && implicitObjectCreation.Initializer?.Expressions.Any(f => f.IsKind(SyntaxKind.SimpleAssignmentExpression)) != true
+            && implicitObjectCreation.Initializer?.Expressions
+                .Any(f => f.IsKind(
+                    SyntaxKind.SimpleAssignmentExpression,
+                    SyntaxKind.ComplexElementInitializerExpression)) != true
             && UseCollectionExpression(ref context);
     }
 

src/Tests/Analyzers.Tests/RCS1250UseImplicitOrExplicitObjectCreationTests.cs

@@ -1903,4 +1903,31 @@ void M2()
 """, options: Options.AddConfigOption(ConfigOptionKeys.ObjectCreationTypeStyle, ConfigOptionValues.ObjectCreationTypeStyle_Implicit)
             .AddConfigOption(ConfigOptionKeys.UseCollectionExpression, false));
     }
+
+    [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.UseImplicitOrExplicitObjectCreation)]
+    public async Task TestNoDiagnostic_ComplexElementInitializer()
+    {
+        await VerifyNoDiagnosticAsync("""
+using System;
+using System.Collections;
+using System.Collections.Generic;
+class C : IEnumerable<KeyValuePair<int, int>>
+{
+    public IEnumerator<KeyValuePair<int, int>> GetEnumerator() => throw new System.NotImplementedException();
+
+    IEnumerator IEnumerable.GetEnumerator() => throw new System.NotImplementedException();
+
+    public void Add(int arg1, int arg2)
+    {
+    }
+
+    static C M()
+    {
+        C c = new() { { 1, 2 } };
+        return c;
+    }
+}
+""", options: Options.AddConfigOption(ConfigOptionKeys.ObjectCreationTypeStyle, ConfigOptionValues.ObjectCreationTypeStyle_Implicit)
+            .AddConfigOption(ConfigOptionKeys.UseCollectionExpression, true));
+    }
 }