Feedback from analyzer loading change (#77780)

* Feedback from analyzer loading change

Few changes here:

1. Jason had suggested I add an assert into the shadow copy loader, I
   did but apparently forgot to save.
2. Rename the file to match type name

Follow up to #77004

* PR feedback

* Apply suggestions from code review

Co-authored-by: Jan Jones <[email protected]>

---------

Co-authored-by: Jan Jones <[email protected]>

Author: jaredpar

src/Compilers/Core/Portable/DiagnosticAnalyzer/ShadowCopyAnalyzerAssemblyLoader.cs renamed to src/Compilers/Core/Portable/DiagnosticAnalyzer/ShadowCopyAnalyzerPathResolver.cs

@@ -12,6 +12,7 @@
 using System.Collections.Immutable;
 using System.Reflection;
 using System.Globalization;
+using System.Diagnostics;
 
 namespace Microsoft.CodeAnalysis
 {
@@ -52,7 +53,7 @@ internal sealed class ShadowCopyAnalyzerPathResolver : IAnalyzerPathResolver
         /// is a map between the original path and the Task that completes when the shadow copy for that
         /// original path completes.
         /// </summary>
-        private ConcurrentDictionary<string, Task> CopyMap { get; } = new(AnalyzerAssemblyLoader.OriginalPathComparer);
+        private ConcurrentDictionary<string, Task<string>> CopyMap { get; } = new(AnalyzerAssemblyLoader.OriginalPathComparer);
 
         /// <summary>
         /// This is the number of shadow copies that have occurred in this instance.
@@ -198,15 +199,15 @@ private void ShadowCopyFile(string originalFilePath, string shadowCopyPath)
                 return;
             }
 
-            var tcs = new TaskCompletionSource<object?>();
+            var tcs = new TaskCompletionSource<string>();
             var task = CopyMap.GetOrAdd(originalFilePath, tcs.Task);
             if (object.ReferenceEquals(task, tcs.Task))
             {
                 // This thread won and we need to do the copy.
                 try
                 {
                     copyFile(originalFilePath, shadowCopyPath);
-                    tcs.SetResult(null);
+                    tcs.SetResult(shadowCopyPath);
                 }
                 catch (Exception ex)
                 {
@@ -218,6 +219,7 @@ private void ShadowCopyFile(string originalFilePath, string shadowCopyPath)
             {
                 // This thread lost and we need to wait for the winner to finish the copy.
                 task.Wait();
+                Debug.Assert(AnalyzerAssemblyLoader.GeneratedPathComparer.Equals(shadowCopyPath, task.Result));
             }
 
             static void copyFile(string originalPath, string shadowCopyPath)

src/Workspaces/Core/Portable/Microsoft.CodeAnalysis.Workspaces.csproj

@@ -37,7 +37,7 @@
     <Compile Include="..\..\..\Compilers\Core\Portable\DiagnosticAnalyzer\AnalyzerAssemblyLoader.cs" Link="Diagnostics\CompilerShared\AnalyzerAssemblyLoader.cs" />
     <Compile Include="..\..\..\Compilers\Core\Portable\DiagnosticAnalyzer\AnalyzerAssemblyLoader.Core.cs" Link="Diagnostics\CompilerShared\AnalyzerAssemblyLoader.Core.cs" />
     <Compile Include="..\..\..\Compilers\Core\Portable\DiagnosticAnalyzer\AnalyzerAssemblyLoader.Desktop.cs" Link="Diagnostics\CompilerShared\AnalyzerAssemblyLoader.Desktop.cs" />
-    <Compile Include="..\..\..\Compilers\Core\Portable\DiagnosticAnalyzer\ShadowCopyAnalyzerAssemblyLoader.cs" Link="Diagnostics\CompilerShared\ShadowCopyAnalyzerAssemblyLoader.cs" />
+    <Compile Include="..\..\..\Compilers\Core\Portable\DiagnosticAnalyzer\ShadowCopyAnalyzerPathResolver.cs" Link="Diagnostics\CompilerShared\ShadowCopyAnalyzerPathResolver.cs" />
     <Compile Include="..\..\..\Compilers\Core\Portable\DiagnosticAnalyzer\IAnalyzerAssemblyResolver.cs" Link="Diagnostics\CompilerShared\IAnalyzerAssemblyResolver.cs" />
     <Compile Include="..\..\..\Compilers\Core\Portable\DiagnosticAnalyzer\IAnalyzerPathResolver.cs" Link="Diagnostics\CompilerShared\IAnalyzerAssemblyResolver.cs" />
     <Compile Include="..\..\..\Compilers\Core\Portable\DiagnosticAnalyzer\ProgramFilesAnalyzerPathResolver.cs" Link="Diagnostics\CompilerShared\ProgramFilesAnalyzerPathResolver.cs" />