Add test

Author: SofusA

src/LanguageServer/ProtocolUnitTests/Diagnostics/DiagnosticRegistrationTests.cs

@@ -8,8 +8,10 @@
 using System.Text.Json;
 using System.Threading;
 using System.Threading.Tasks;
+using ICSharpCode.Decompiler.CSharp.Syntax;
 using Microsoft.CodeAnalysis.LanguageServer.Handler.Diagnostics;
 using Microsoft.CodeAnalysis.LanguageServer.Handler.Diagnostics.Public;
+using Microsoft.CodeAnalysis.UnitTests;
 using Roslyn.LanguageServer.Protocol;
 using Roslyn.Test.Utilities;
 using StreamJsonRpc;
@@ -25,15 +27,15 @@ public DiagnosticRegistrationTests(ITestOutputHelper? testOutputHelper) : base(t
     }
 
     [Theory, CombinatorialData]
-    public async Task TestPublicDiagnosticSourcesAreRegisteredWhenSupported(bool mutatingLspWorkspace)
+    public async Task TestPublicDiagnosticSourcesAreRegisteredWhenSupported(bool mutatingLspWorkspace, bool dynamicRegistration)
     {
         var clientCapabilities = new ClientCapabilities
         {
             TextDocument = new TextDocumentClientCapabilities
             {
                 Diagnostic = new DiagnosticSetting
                 {
-                    DynamicRegistration = true,
+                    DynamicRegistration = dynamicRegistration,
                 }
             }
         };
@@ -49,42 +51,54 @@ public async Task TestPublicDiagnosticSourcesAreRegisteredWhenSupported(bool mut
         await using var testLspServer = await CreateTestLspServerAsync(string.Empty, mutatingLspWorkspace, initializationOptions);
 
         var registrations = clientCallbackTarget.GetRegistrations();
+        var serverCapabilities = testLspServer.GetServerCapabilities();
 
         // Get all registrations for diagnostics (note that workspace registrations are registered against document method name).
         var diagnosticRegistrations = registrations
             .Where(r => r.Method == Methods.TextDocumentDiagnosticName)
             .Select(r => JsonSerializer.Deserialize<DiagnosticRegistrationOptions>((JsonElement)r.RegisterOptions!, ProtocolConversions.LspJsonSerializerOptions)!);
 
-        Assert.NotEmpty(diagnosticRegistrations);
-
-        string[] documentSources = [
-            PullDiagnosticCategories.DocumentCompilerSyntax,
-            PullDiagnosticCategories.DocumentCompilerSemantic,
-            PullDiagnosticCategories.DocumentAnalyzerSyntax,
-            PullDiagnosticCategories.DocumentAnalyzerSemantic,
-            PublicDocumentNonLocalDiagnosticSourceProvider.NonLocal
-        ];
-
-        string[] documentAndWorkspaceSources = [
-            PullDiagnosticCategories.EditAndContinue,
-            PullDiagnosticCategories.WorkspaceDocumentsAndProject
-        ];
-
-        // Verify document only sources are present (and do not set the workspace diagnostic option).
-        foreach (var documentSource in documentSources)
+        if (dynamicRegistration)
         {
-            var options = Assert.Single(diagnosticRegistrations, (r) => r.Identifier == documentSource);
-            Assert.False(options.WorkspaceDiagnostics);
-            Assert.True(options.InterFileDependencies);
-        }
+            Assert.NotEmpty(diagnosticRegistrations);
+
+            string[] documentSources = [
+                PullDiagnosticCategories.DocumentCompilerSyntax,
+                PullDiagnosticCategories.DocumentCompilerSemantic,
+                PullDiagnosticCategories.DocumentAnalyzerSyntax,
+                PullDiagnosticCategories.DocumentAnalyzerSemantic,
+                PublicDocumentNonLocalDiagnosticSourceProvider.NonLocal
+            ];
+
+            string[] documentAndWorkspaceSources = [
+                PullDiagnosticCategories.EditAndContinue,
+                PullDiagnosticCategories.WorkspaceDocumentsAndProject
+            ];
+
+            // Verify document only sources are present (and do not set the workspace diagnostic option).
+            foreach (var documentSource in documentSources)
+            {
+                var options = Assert.Single(diagnosticRegistrations, (r) => r.Identifier == documentSource);
+                Assert.False(options.WorkspaceDiagnostics);
+                Assert.True(options.InterFileDependencies);
+            }
 
-        // Verify workspace sources are present (and do set the workspace diagnostic option).
-        foreach (var workspaceSource in documentAndWorkspaceSources)
+            // Verify workspace sources are present (and do set the workspace diagnostic option).
+            foreach (var workspaceSource in documentAndWorkspaceSources)
+            {
+                var options = Assert.Single(diagnosticRegistrations, (r) => r.Identifier == workspaceSource);
+                Assert.True(options.WorkspaceDiagnostics);
+                Assert.True(options.InterFileDependencies);
+                Assert.True(options.WorkDoneProgress);
+            }
+        }
+        else
         {
-            var options = Assert.Single(diagnosticRegistrations, (r) => r.Identifier == workspaceSource);
-            Assert.True(options.WorkspaceDiagnostics);
-            Assert.True(options.InterFileDependencies);
-            Assert.True(options.WorkDoneProgress);
+            var diagnosticOptions = (DiagnosticOptions)serverCapabilities?.DiagnosticOptions;
+
+            Assert.Empty(diagnosticRegistrations);
+            Assert.NotNull(diagnosticOptions);
+            Assert.True(diagnosticOptions.InterFileDependencies);
         }
 
         // Verify task diagnostics are not present.