Skip to content

Commit df30c76

Browse files
committed
Address feedback
1 parent 2b43156 commit df30c76

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed

src/NetAnalyzers/VisualBasic/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/BasicOverrideEqualsOnOverloadingOperatorEquals.vb

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -51,27 +51,13 @@ Namespace Microsoft.CodeQuality.VisualBasic.Analyzers.ApiDesignGuidelines
5151
End If
5252

5353
' If there's a = operator...
54-
If Not HasEqualityOperator(type) Then
54+
If Not type.GetMembers(WellKnownMemberNames.EqualityOperatorName).OfType(Of IMethodSymbol).Any(Function(m) m.MethodKind = MethodKind.UserDefinedOperator) Then
5555
Return
5656
End If
5757

5858
symbolContext.ReportDiagnostic(type.CreateDiagnostic(Rule))
5959
End Sub,
6060
SymbolKind.NamedType)
6161
End Sub
62-
63-
Private Shared Function HasEqualityOperator(type As INamedTypeSymbol) As Boolean
64-
For Each member In type.GetMembers()
65-
Dim method = TryCast(member, IMethodSymbol)
66-
If method IsNot Nothing AndAlso
67-
method.MethodKind = MethodKind.UserDefinedOperator AndAlso
68-
CaseInsensitiveComparison.Equals(method.Name, WellKnownMemberNames.EqualityOperatorName) Then
69-
70-
Return True
71-
End If
72-
Next
73-
74-
Return False
75-
End Function
7662
End Class
7763
End Namespace

0 commit comments

Comments
 (0)