Merge pull request #1337 from dotnet/dev/bartde/rx_nullable_step1

bartdesmet · web-flow · commit 346807e8726e · 2020-10-01T10:51:57.000-07:00
Enable nullable in a few files.
diff --git a/Rx.NET/Source/src/System.Reactive/AnonymousObservable.cs b/Rx.NET/Source/src/System.Reactive/AnonymousObservable.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 using System.Reactive.Disposables;
 
 namespace System.Reactive
diff --git a/Rx.NET/Source/src/System.Reactive/AnonymousObserver.cs b/Rx.NET/Source/src/System.Reactive/AnonymousObserver.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/Concurrency/IScheduledItem.cs b/Rx.NET/Source/src/System.Reactive/Concurrency/IScheduledItem.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive.Concurrency
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/Concurrency/IStopwatch.cs b/Rx.NET/Source/src/System.Reactive/Concurrency/IStopwatch.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive.Concurrency
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/Concurrency/IStopwatchProvider.cs b/Rx.NET/Source/src/System.Reactive/Concurrency/IStopwatchProvider.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive.Concurrency
 {
     /*
diff --git a/Rx.NET/Source/src/System.Reactive/Concurrency/Thread.Stub.cs b/Rx.NET/Source/src/System.Reactive/Concurrency/Thread.Stub.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 #if NO_THREAD
 using System.Threading.Tasks;
 
diff --git a/Rx.NET/Source/src/System.Reactive/Disposables/ICancelable.cs b/Rx.NET/Source/src/System.Reactive/Disposables/ICancelable.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive.Disposables
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/EnlightenmentProvider.cs b/Rx.NET/Source/src/System.Reactive/EnlightenmentProvider.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive.PlatformServices
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/ExcludeFromCodeCoverageAttribute.cs b/Rx.NET/Source/src/System.Reactive/ExcludeFromCodeCoverageAttribute.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 #if NO_CODE_COVERAGE_ATTRIBUTE
 
 namespace System.Diagnostics.CodeAnalysis
diff --git a/Rx.NET/Source/src/System.Reactive/ExperimentalAttribute.cs b/Rx.NET/Source/src/System.Reactive/ExperimentalAttribute.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     /// <summary>
@@ -13,4 +11,4 @@ namespace System.Reactive
     public sealed class ExperimentalAttribute : Attribute
     {
     }
-}
+}
diff --git a/Rx.NET/Source/src/System.Reactive/GlobalSuppressions.cs b/Rx.NET/Source/src/System.Reactive/GlobalSuppressions.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 // This file is used by Code Analysis to maintain SuppressMessage 
 // attributes that are applied to this project.
 // Project-level suppressions either have no target or are given 
diff --git a/Rx.NET/Source/src/System.Reactive/IEventPattern.cs b/Rx.NET/Source/src/System.Reactive/IEventPattern.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/IEventPatternSource.cs b/Rx.NET/Source/src/System.Reactive/IEventPatternSource.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/IEventSource.cs b/Rx.NET/Source/src/System.Reactive/IEventSource.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/IObserver.Result.cs b/Rx.NET/Source/src/System.Reactive/IObserver.Result.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     /// <summary>
@@ -39,4 +37,4 @@ public interface IObserver<in TValue, out TResult>
         /// <returns>Result returned upon observation of the sequence completion.</returns>
         TResult OnCompleted();
     }
-}
+}
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/Constants.cs b/Rx.NET/Source/src/System.Reactive/Internal/Constants.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     // We can't make those based on the Strings_Core.resx file, because the ObsoleteAttribute needs a compile-time constant.
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServices.Default.cs b/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServices.Default.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 using System.Runtime.ExceptionServices;
 
 namespace System.Reactive.PlatformServices
@@ -17,4 +15,4 @@ internal class DefaultExceptionServices/*Impl*/ : IExceptionServices
     {
         public void Rethrow(Exception exception) => ExceptionDispatchInfo.Capture(exception).Throw();
     }
-}
+}
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/Helpers.cs b/Rx.NET/Source/src/System.Reactive/Internal/Helpers.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 using System.Collections.Generic;
 
 namespace System.Reactive
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/IConcatenatable.cs b/Rx.NET/Source/src/System.Reactive/Internal/IConcatenatable.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 using System.Collections.Generic;
 
 namespace System.Reactive
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/IEvaluatableObservable.cs b/Rx.NET/Source/src/System.Reactive/Internal/IEvaluatableObservable.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     internal interface IEvaluatableObservable<out T>
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/ISafeObserver.cs b/Rx.NET/Source/src/System.Reactive/Internal/ISafeObserver.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/IdentitySink.cs b/Rx.NET/Source/src/System.Reactive/Internal/IdentitySink.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     internal abstract class IdentitySink<T> : Sink<T, T>
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/StopwatchImpl.cs b/Rx.NET/Source/src/System.Reactive/Internal/StopwatchImpl.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 using System.Diagnostics;
 
 namespace System.Reactive.Concurrency
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/Stubs.cs b/Rx.NET/Source/src/System.Reactive/Internal/Stubs.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     internal static class Stubs<T>
diff --git a/Rx.NET/Source/src/System.Reactive/Linq/IGroupedObservable.cs b/Rx.NET/Source/src/System.Reactive/Linq/IGroupedObservable.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive.Linq
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/Linq/IQbservable.cs b/Rx.NET/Source/src/System.Reactive/Linq/IQbservable.cs
@@ -1,9 +1,7 @@
-// Licensed to the .NET Foundation under one or more agreements.
+﻿// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 using System.Linq.Expressions;
 
 namespace System.Reactive.Linq
diff --git a/Rx.NET/Source/src/System.Reactive/Linq/IQbservableProvider.cs b/Rx.NET/Source/src/System.Reactive/Linq/IQbservableProvider.cs
@@ -1,9 +1,7 @@
-// Licensed to the .NET Foundation under one or more agreements.
+﻿// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 using System.Linq.Expressions;
 
 namespace System.Reactive.Linq
diff --git a/Rx.NET/Source/src/System.Reactive/Linq/QueryDebugger.cs b/Rx.NET/Source/src/System.Reactive/Linq/QueryDebugger.cs
@@ -1,9 +1,7 @@
-// Licensed to the .NET Foundation under one or more agreements.
+﻿// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information.
 
-#nullable disable
-
 // Copyright (c) Microsoft Open Technologies, Inc. All rights reserved. See License.txt in the project root for license information.
 
 //
diff --git a/Rx.NET/Source/src/System.Reactive/Linq/QueryLanguage_.cs b/Rx.NET/Source/src/System.Reactive/Linq/QueryLanguage_.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive.Linq
 {
     internal partial class QueryLanguage : IQueryLanguage
diff --git a/Rx.NET/Source/src/System.Reactive/NamespaceDocs.cs b/Rx.NET/Source/src/System.Reactive/NamespaceDocs.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/ObservableBase.cs b/Rx.NET/Source/src/System.Reactive/ObservableBase.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 using System.Reactive.Concurrency;
 
 namespace System.Reactive
diff --git a/Rx.NET/Source/src/System.Reactive/Observer.Extensions.cs b/Rx.NET/Source/src/System.Reactive/Observer.Extensions.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 using System.Reactive.Concurrency;
 using System.Threading;
 
diff --git a/Rx.NET/Source/src/System.Reactive/ObserverBase.cs b/Rx.NET/Source/src/System.Reactive/ObserverBase.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 using System.Threading;
 
 namespace System.Reactive
diff --git a/Rx.NET/Source/src/System.Reactive/Platforms/Desktop/Internal/Constants.cs b/Rx.NET/Source/src/System.Reactive/Platforms/Desktop/Internal/Constants.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive
 {
     // We can't make those based on the Strings_WindowsThreading.resx file, because the ObsoleteAttribute needs a compile-time constant.
diff --git a/Rx.NET/Source/src/System.Reactive/Properties/InternalsVisibleTo.cs b/Rx.NET/Source/src/System.Reactive/Properties/InternalsVisibleTo.cs
@@ -2,9 +2,5 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
-
-
 [assembly: System.Runtime.CompilerServices.InternalsVisibleTo("Tests.System.Reactive, PublicKey=00240000048000009400000006020000002400005253413100040000010001008f5cff058631087031f8350f30a36fa078027e5df2316b564352dc9eb7af7ce856016d3c5e9d058036fe73bb5c83987bd3fc0793fbe25d633cc4f37c2bd5f1d717cd2a81661bec08f0971dc6078e17bde372b89005e7738a0ebd501b896ca3e8315270ff64df7809dd912c372df61785a5085b3553b7872e39b1b1cc0ff5a6bc")]
 [assembly: System.Runtime.CompilerServices.InternalsVisibleTo("Tests.System.Reactive.Uwp.DeviceRunner, PublicKey=00240000048000009400000006020000002400005253413100040000010001008f5cff058631087031f8350f30a36fa078027e5df2316b564352dc9eb7af7ce856016d3c5e9d058036fe73bb5c83987bd3fc0793fbe25d633cc4f37c2bd5f1d717cd2a81661bec08f0971dc6078e17bde372b89005e7738a0ebd501b896ca3e8315270ff64df7809dd912c372df61785a5085b3553b7872e39b1b1cc0ff5a6bc")]
diff --git a/Rx.NET/Source/src/System.Reactive/Subjects/IConnectableObservable.cs b/Rx.NET/Source/src/System.Reactive/Subjects/IConnectableObservable.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive.Subjects
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/Subjects/ISubject.Multi.cs b/Rx.NET/Source/src/System.Reactive/Subjects/ISubject.Multi.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive.Subjects
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/Subjects/ISubject.cs b/Rx.NET/Source/src/System.Reactive/Subjects/ISubject.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive.Subjects
 {
     /// <summary>
diff --git a/Rx.NET/Source/src/System.Reactive/Threading/Tasks/NamespaceDoc.cs b/Rx.NET/Source/src/System.Reactive/Threading/Tasks/NamespaceDoc.cs
@@ -2,8 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
-#nullable disable
-
 namespace System.Reactive.Threading.Tasks
 {
     /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,6 @@`
`2`	`2`	`// The .NET Foundation licenses this file to you under the MIT License.`
`3`	`3`	`// See the LICENSE file in the project root for more information.`
`4`	`4`
`5`		`-#nullable disable`
`6`		`-`
`7`	`5`	`namespace System.Reactive`
`8`	`6`	`{`
`9`	`7`	`/// <summary>`