Merge pull request #1378 from dotnet/dev/bartde/seal_things

bartdesmet · web-flow · commit 16c99938fe84 · 2020-10-06T18:07:16.000-07:00
Seal some types
diff --git a/Rx.NET/Source/src/System.Reactive/Concurrency/ConcurrencyAbstractionLayerImpl.Windows.cs b/Rx.NET/Source/src/System.Reactive/Concurrency/ConcurrencyAbstractionLayerImpl.Windows.cs
@@ -7,7 +7,7 @@
 
 namespace System.Reactive.Concurrency
 {
-    internal class /*Default*/ConcurrencyAbstractionLayerImpl : IConcurrencyAbstractionLayer
+    internal sealed class /*Default*/ConcurrencyAbstractionLayerImpl : IConcurrencyAbstractionLayer
     {
         public IDisposable StartTimer(Action<object?> action, object? state, TimeSpan dueTime)
         {
diff --git a/Rx.NET/Source/src/System.Reactive/Concurrency/ConcurrencyAbstractionLayerImpl.cs b/Rx.NET/Source/src/System.Reactive/Concurrency/ConcurrencyAbstractionLayerImpl.cs
@@ -13,7 +13,7 @@ namespace System.Reactive.Concurrency
     //          Another copy is kept in System.Reactive.PlatformServices to enlighten the default lowest common denominator
     //          behavior of Rx for PLIB when used on a more capable platform.
     //
-    internal class /*Default*/ConcurrencyAbstractionLayerImpl : IConcurrencyAbstractionLayer
+    internal sealed class /*Default*/ConcurrencyAbstractionLayerImpl : IConcurrencyAbstractionLayer
     {
         private sealed class WorkItem
         {
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServices.Default.cs b/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServices.Default.cs
@@ -12,7 +12,7 @@ namespace System.Reactive.PlatformServices
     //          Another copy is kept in System.Reactive.PlatformServices to enlighten the default lowest common denominator
     //          behavior of Rx for PLIB when used on a more capable platform.
     //
-    internal class DefaultExceptionServices/*Impl*/ : IExceptionServices
+    internal sealed class DefaultExceptionServices/*Impl*/ : IExceptionServices
     {
 #pragma warning disable CS8763 // NB: On down-level platforms, Throw is not marked as DoesNotReturn.
         [DoesNotReturn]
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServicesImpl.cs b/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServicesImpl.cs
@@ -12,7 +12,7 @@ namespace System.Reactive.PlatformServices
     //          Another copy is kept in System.Reactive.PlatformServices to enlighten the default lowest common denominator
     //          behavior of Rx for PLIB when used on a more capable platform.
     //
-    internal class /*Default*/ExceptionServicesImpl : IExceptionServices
+    internal sealed class /*Default*/ExceptionServicesImpl : IExceptionServices
     {
 #pragma warning disable CS8763 // NB: On down-level platforms, Throw is not marked as DoesNotReturn.
         [DoesNotReturn]
diff --git a/Rx.NET/Source/src/System.Reactive/Internal/HostLifecycleNotifications.Windows.cs b/Rx.NET/Source/src/System.Reactive/Internal/HostLifecycleNotifications.Windows.cs
@@ -8,7 +8,7 @@
 
 namespace System.Reactive.PlatformServices
 {
-    internal class HostLifecycleNotifications : IHostLifecycleNotifications
+    internal sealed class HostLifecycleNotifications : IHostLifecycleNotifications
     {
         private EventHandler<SuspendingEventArgs>? _suspending;
         private EventHandler<object>? _resuming;
diff --git a/Rx.NET/Source/src/System.Reactive/Joins/ActivePlan.cs b/Rx.NET/Source/src/System.Reactive/Joins/ActivePlan.cs
@@ -36,7 +36,7 @@ protected void Dequeue()
         }
     }
 
-    internal class ActivePlan<T1> : ActivePlan
+    internal sealed class ActivePlan<T1> : ActivePlan
     {
         private readonly Action<T1> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -67,7 +67,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2> : ActivePlan
+    internal sealed class ActivePlan<T1, T2> : ActivePlan
     {
         private readonly Action<T1, T2> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -106,7 +106,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3> : ActivePlan
     {
         private readonly Action<T1, T2, T3> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -152,7 +152,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -205,7 +205,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -266,7 +266,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5, T6> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5, T6> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -335,7 +335,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5, T6, T7> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -411,7 +411,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -496,7 +496,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -589,7 +589,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -689,7 +689,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -796,7 +796,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -911,7 +911,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -1033,7 +1033,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -1162,7 +1162,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15> _onNext;
         private readonly JoinObserver<T1> _first;
@@ -1299,7 +1299,7 @@ internal override void Match()
         }
     }
 
-    internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16> : ActivePlan
+    internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16> : ActivePlan
     {
         private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16> _onNext;
         private readonly JoinObserver<T1> _first;
diff --git a/Rx.NET/Source/src/System.Reactive/Joins/Plan.cs b/Rx.NET/Source/src/System.Reactive/Joins/Plan.cs
@@ -38,7 +38,7 @@ internal static JoinObserver<TSource> CreateObserver<TSource>(
         }
     }
 
-    internal class Plan<T1, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, TResult> : Plan<TResult>
     {
         internal Pattern<T1> Expression { get; }
 
@@ -83,7 +83,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2> Expression { get; }
 
@@ -131,7 +131,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, T3, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3> Expression { get; }
 
@@ -183,7 +183,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, T3, T4, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4> Expression { get; }
 
@@ -238,7 +238,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, T3, T4, T5, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5> Expression { get; }
 
@@ -296,7 +296,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, T3, T4, T5, T6, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, T6, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5, T6> Expression { get; }
 
@@ -358,7 +358,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, T3, T4, T5, T6, T7, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5, T6, T7> Expression { get; }
 
@@ -423,7 +423,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8> Expression { get; }
 
@@ -491,7 +491,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9> Expression { get; }
 
@@ -562,7 +562,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10> Expression { get; }
 
@@ -636,7 +636,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11> Expression { get; }
 
@@ -714,7 +714,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12> Expression { get; }
 
@@ -797,7 +797,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
     }
 
 
-    internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13> Expression { get; }
 
@@ -883,7 +883,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
     }
 
 
-    internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14> Expression { get; }
 
@@ -975,7 +975,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
         }
     }
 
-    internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15> Expression { get; }
 
@@ -1069,7 +1069,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external
             return activePlan;
         }
     }
-    internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, TResult> : Plan<TResult>
+    internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, TResult> : Plan<TResult>
     {
         internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16> Expression { get; }
 
diff --git a/Rx.NET/Source/src/System.Reactive/ObservableQuery.cs b/Rx.NET/Source/src/System.Reactive/ObservableQuery.cs
@@ -73,18 +73,7 @@ IQueryable<TElement> IQueryProvider.CreateQuery<TElement>(Expression expression)
 
         private static MethodInfo? _staticAsQueryable;
 
-        private static MethodInfo AsQueryable
-        {
-            get
-            {
-                if (_staticAsQueryable == null)
-                {
-                    _staticAsQueryable = Qbservable.InfoOf<object>(() => Queryable.AsQueryable<object>(null)).GetGenericMethodDefinition();
-                }
-
-                return _staticAsQueryable;
-            }
-        }
+        private static MethodInfo AsQueryable => _staticAsQueryable ??=  Qbservable.InfoOf<object>(() => Queryable.AsQueryable<object>(null!)).GetGenericMethodDefinition();
 
         IQueryable IQueryProvider.CreateQuery(Expression expression)
         {
diff --git a/Rx.NET/Source/src/System.Reactive/Subjects/ConnectableObservable.cs b/Rx.NET/Source/src/System.Reactive/Subjects/ConnectableObservable.cs
@@ -11,7 +11,7 @@ namespace System.Reactive.Subjects
     /// </summary>
     /// <typeparam name="TSource">The type of the elements in the source sequence.</typeparam>
     /// <typeparam name="TResult">The type of the elements in the resulting sequence, after transformation through the subject.</typeparam>
-    internal class ConnectableObservable<TSource, TResult> : IConnectableObservable<TResult>
+    internal sealed class ConnectableObservable<TSource, TResult> : IConnectableObservable<TResult>
     {
         private readonly ISubject<TSource, TResult> _subject;
         private readonly IObservable<TSource> _source;

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`
`8`	`8`	`namespace System.Reactive.Concurrency`
`9`	`9`	`{`
`10`		`- internal class /Default/ConcurrencyAbstractionLayerImpl : IConcurrencyAbstractionLayer`
	`10`	`+ internal sealed class /Default/ConcurrencyAbstractionLayerImpl : IConcurrencyAbstractionLayer`
`11`	`11`	`{`
`12`	`12`	`public IDisposable StartTimer(Action<object?> action, object? state, TimeSpan dueTime)`
`13`	`13`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ namespace System.Reactive.Concurrency`
`13`	`13`	`// Another copy is kept in System.Reactive.PlatformServices to enlighten the default lowest common denominator`
`14`	`14`	`// behavior of Rx for PLIB when used on a more capable platform.`
`15`	`15`	`//`
`16`		`- internal class /Default/ConcurrencyAbstractionLayerImpl : IConcurrencyAbstractionLayer`
	`16`	`+ internal sealed class /Default/ConcurrencyAbstractionLayerImpl : IConcurrencyAbstractionLayer`
`17`	`17`	`{`
`18`	`18`	`private sealed class WorkItem`
`19`	`19`	`{`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ namespace System.Reactive.PlatformServices`
`12`	`12`	`// Another copy is kept in System.Reactive.PlatformServices to enlighten the default lowest common denominator`
`13`	`13`	`// behavior of Rx for PLIB when used on a more capable platform.`
`14`	`14`	`//`
`15`		`- internal class DefaultExceptionServices/Impl/ : IExceptionServices`
	`15`	`+ internal sealed class DefaultExceptionServices/Impl/ : IExceptionServices`
`16`	`16`	`{`
`17`	`17`	`#pragma warning disable CS8763 // NB: On down-level platforms, Throw is not marked as DoesNotReturn.`
`18`	`18`	`[DoesNotReturn]`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`
`9`	`9`	`namespace System.Reactive.PlatformServices`
`10`	`10`	`{`
`11`		`- internal class HostLifecycleNotifications : IHostLifecycleNotifications`
	`11`	`+ internal sealed class HostLifecycleNotifications : IHostLifecycleNotifications`
`12`	`12`	`{`
`13`	`13`	`private EventHandler<SuspendingEventArgs>? _suspending;`
`14`	`14`	`private EventHandler<object>? _resuming;`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ protected void Dequeue()`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
`39`		`- internal class ActivePlan<T1> : ActivePlan`
	`39`	`+ internal sealed class ActivePlan<T1> : ActivePlan`
`40`	`40`	`{`
`41`	`41`	`private readonly Action<T1> _onNext;`
`42`	`42`	`private readonly JoinObserver<T1> _first;`
`@@ -67,7 +67,7 @@ internal override void Match()`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`
`70`		`- internal class ActivePlan<T1, T2> : ActivePlan`
	`70`	`+ internal sealed class ActivePlan<T1, T2> : ActivePlan`
`71`	`71`	`{`
`72`	`72`	`private readonly Action<T1, T2> _onNext;`
`73`	`73`	`private readonly JoinObserver<T1> _first;`
`@@ -106,7 +106,7 @@ internal override void Match()`
`106`	`106`	`}`
`107`	`107`	`}`
`108`	`108`
`109`		`- internal class ActivePlan<T1, T2, T3> : ActivePlan`
	`109`	`+ internal sealed class ActivePlan<T1, T2, T3> : ActivePlan`
`110`	`110`	`{`
`111`	`111`	`private readonly Action<T1, T2, T3> _onNext;`
`112`	`112`	`private readonly JoinObserver<T1> _first;`
`@@ -152,7 +152,7 @@ internal override void Match()`
`152`	`152`	`}`
`153`	`153`	`}`
`154`	`154`
`155`		`- internal class ActivePlan<T1, T2, T3, T4> : ActivePlan`
	`155`	`+ internal sealed class ActivePlan<T1, T2, T3, T4> : ActivePlan`
`156`	`156`	`{`
`157`	`157`	`private readonly Action<T1, T2, T3, T4> _onNext;`
`158`	`158`	`private readonly JoinObserver<T1> _first;`
`@@ -205,7 +205,7 @@ internal override void Match()`
`205`	`205`	`}`
`206`	`206`	`}`
`207`	`207`
`208`		`- internal class ActivePlan<T1, T2, T3, T4, T5> : ActivePlan`
	`208`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5> : ActivePlan`
`209`	`209`	`{`
`210`	`210`	`private readonly Action<T1, T2, T3, T4, T5> _onNext;`
`211`	`211`	`private readonly JoinObserver<T1> _first;`
`@@ -266,7 +266,7 @@ internal override void Match()`
`266`	`266`	`}`
`267`	`267`	`}`
`268`	`268`
`269`		`- internal class ActivePlan<T1, T2, T3, T4, T5, T6> : ActivePlan`
	`269`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6> : ActivePlan`
`270`	`270`	`{`
`271`	`271`	`private readonly Action<T1, T2, T3, T4, T5, T6> _onNext;`
`272`	`272`	`private readonly JoinObserver<T1> _first;`
`@@ -335,7 +335,7 @@ internal override void Match()`
`335`	`335`	`}`
`336`	`336`	`}`
`337`	`337`
`338`		`- internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7> : ActivePlan`
	`338`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7> : ActivePlan`
`339`	`339`	`{`
`340`	`340`	`private readonly Action<T1, T2, T3, T4, T5, T6, T7> _onNext;`
`341`	`341`	`private readonly JoinObserver<T1> _first;`
`@@ -411,7 +411,7 @@ internal override void Match()`
`411`	`411`	`}`
`412`	`412`	`}`
`413`	`413`
`414`		`- internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8> : ActivePlan`
	`414`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8> : ActivePlan`
`415`	`415`	`{`
`416`	`416`	`private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8> _onNext;`
`417`	`417`	`private readonly JoinObserver<T1> _first;`
`@@ -496,7 +496,7 @@ internal override void Match()`
`496`	`496`	`}`
`497`	`497`	`}`
`498`	`498`
`499`		`- internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9> : ActivePlan`
	`499`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9> : ActivePlan`
`500`	`500`	`{`
`501`	`501`	`private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9> _onNext;`
`502`	`502`	`private readonly JoinObserver<T1> _first;`
`@@ -589,7 +589,7 @@ internal override void Match()`
`589`	`589`	`}`
`590`	`590`	`}`
`591`	`591`
`592`		`- internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10> : ActivePlan`
	`592`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10> : ActivePlan`
`593`	`593`	`{`
`594`	`594`	`private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10> _onNext;`
`595`	`595`	`private readonly JoinObserver<T1> _first;`
`@@ -689,7 +689,7 @@ internal override void Match()`
`689`	`689`	`}`
`690`	`690`	`}`
`691`	`691`
`692`		`- internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11> : ActivePlan`
	`692`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11> : ActivePlan`
`693`	`693`	`{`
`694`	`694`	`private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11> _onNext;`
`695`	`695`	`private readonly JoinObserver<T1> _first;`
`@@ -796,7 +796,7 @@ internal override void Match()`
`796`	`796`	`}`
`797`	`797`	`}`
`798`	`798`
`799`		`- internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12> : ActivePlan`
	`799`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12> : ActivePlan`
`800`	`800`	`{`
`801`	`801`	`private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12> _onNext;`
`802`	`802`	`private readonly JoinObserver<T1> _first;`
`@@ -911,7 +911,7 @@ internal override void Match()`
`911`	`911`	`}`
`912`	`912`	`}`
`913`	`913`
`914`		`- internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13> : ActivePlan`
	`914`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13> : ActivePlan`
`915`	`915`	`{`
`916`	`916`	`private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13> _onNext;`
`917`	`917`	`private readonly JoinObserver<T1> _first;`
`@@ -1033,7 +1033,7 @@ internal override void Match()`
`1033`	`1033`	`}`
`1034`	`1034`	`}`
`1035`	`1035`
`1036`		`- internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14> : ActivePlan`
	`1036`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14> : ActivePlan`
`1037`	`1037`	`{`
`1038`	`1038`	`private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14> _onNext;`
`1039`	`1039`	`private readonly JoinObserver<T1> _first;`
`@@ -1162,7 +1162,7 @@ internal override void Match()`
`1162`	`1162`	`}`
`1163`	`1163`	`}`
`1164`	`1164`
`1165`		`- internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15> : ActivePlan`
	`1165`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15> : ActivePlan`
`1166`	`1166`	`{`
`1167`	`1167`	`private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15> _onNext;`
`1168`	`1168`	`private readonly JoinObserver<T1> _first;`
`@@ -1299,7 +1299,7 @@ internal override void Match()`
`1299`	`1299`	`}`
`1300`	`1300`	`}`
`1301`	`1301`
`1302`		`- internal class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16> : ActivePlan`
	`1302`	`+ internal sealed class ActivePlan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16> : ActivePlan`
`1303`	`1303`	`{`
`1304`	`1304`	`private readonly Action<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16> _onNext;`
`1305`	`1305`	`private readonly JoinObserver<T1> _first;`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ internal static JoinObserver<TSource> CreateObserver<TSource>(`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`
`41`		`- internal class Plan<T1, TResult> : Plan<TResult>`
	`41`	`+ internal sealed class Plan<T1, TResult> : Plan<TResult>`
`42`	`42`	`{`
`43`	`43`	`internal Pattern<T1> Expression { get; }`
`44`	`44`
`@@ -83,7 +83,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`83`	`83`	`}`
`84`	`84`	`}`
`85`	`85`
`86`		`- internal class Plan<T1, T2, TResult> : Plan<TResult>`
	`86`	`+ internal sealed class Plan<T1, T2, TResult> : Plan<TResult>`
`87`	`87`	`{`
`88`	`88`	`internal Pattern<T1, T2> Expression { get; }`
`89`	`89`
`@@ -131,7 +131,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`131`	`131`	`}`
`132`	`132`	`}`
`133`	`133`
`134`		`- internal class Plan<T1, T2, T3, TResult> : Plan<TResult>`
	`134`	`+ internal sealed class Plan<T1, T2, T3, TResult> : Plan<TResult>`
`135`	`135`	`{`
`136`	`136`	`internal Pattern<T1, T2, T3> Expression { get; }`
`137`	`137`
`@@ -183,7 +183,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`183`	`183`	`}`
`184`	`184`	`}`
`185`	`185`
`186`		`- internal class Plan<T1, T2, T3, T4, TResult> : Plan<TResult>`
	`186`	`+ internal sealed class Plan<T1, T2, T3, T4, TResult> : Plan<TResult>`
`187`	`187`	`{`
`188`	`188`	`internal Pattern<T1, T2, T3, T4> Expression { get; }`
`189`	`189`
`@@ -238,7 +238,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`238`	`238`	`}`
`239`	`239`	`}`
`240`	`240`
`241`		`- internal class Plan<T1, T2, T3, T4, T5, TResult> : Plan<TResult>`
	`241`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, TResult> : Plan<TResult>`
`242`	`242`	`{`
`243`	`243`	`internal Pattern<T1, T2, T3, T4, T5> Expression { get; }`
`244`	`244`
`@@ -296,7 +296,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`296`	`296`	`}`
`297`	`297`	`}`
`298`	`298`
`299`		`- internal class Plan<T1, T2, T3, T4, T5, T6, TResult> : Plan<TResult>`
	`299`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, T6, TResult> : Plan<TResult>`
`300`	`300`	`{`
`301`	`301`	`internal Pattern<T1, T2, T3, T4, T5, T6> Expression { get; }`
`302`	`302`
`@@ -358,7 +358,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`358`	`358`	`}`
`359`	`359`	`}`
`360`	`360`
`361`		`- internal class Plan<T1, T2, T3, T4, T5, T6, T7, TResult> : Plan<TResult>`
	`361`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, TResult> : Plan<TResult>`
`362`	`362`	`{`
`363`	`363`	`internal Pattern<T1, T2, T3, T4, T5, T6, T7> Expression { get; }`
`364`	`364`
`@@ -423,7 +423,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`423`	`423`	`}`
`424`	`424`	`}`
`425`	`425`
`426`		`- internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, TResult> : Plan<TResult>`
	`426`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, TResult> : Plan<TResult>`
`427`	`427`	`{`
`428`	`428`	`internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8> Expression { get; }`
`429`	`429`
`@@ -491,7 +491,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`491`	`491`	`}`
`492`	`492`	`}`
`493`	`493`
`494`		`- internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, TResult> : Plan<TResult>`
	`494`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, TResult> : Plan<TResult>`
`495`	`495`	`{`
`496`	`496`	`internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9> Expression { get; }`
`497`	`497`
`@@ -562,7 +562,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`562`	`562`	`}`
`563`	`563`	`}`
`564`	`564`
`565`		`- internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, TResult> : Plan<TResult>`
	`565`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, TResult> : Plan<TResult>`
`566`	`566`	`{`
`567`	`567`	`internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10> Expression { get; }`
`568`	`568`
`@@ -636,7 +636,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`636`	`636`	`}`
`637`	`637`	`}`
`638`	`638`
`639`		`- internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, TResult> : Plan<TResult>`
	`639`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, TResult> : Plan<TResult>`
`640`	`640`	`{`
`641`	`641`	`internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11> Expression { get; }`
`642`	`642`
`@@ -714,7 +714,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`714`	`714`	`}`
`715`	`715`	`}`
`716`	`716`
`717`		`- internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, TResult> : Plan<TResult>`
	`717`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, TResult> : Plan<TResult>`
`718`	`718`	`{`
`719`	`719`	`internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12> Expression { get; }`
`720`	`720`
`@@ -797,7 +797,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`797`	`797`	`}`
`798`	`798`
`799`	`799`
`800`		`- internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, TResult> : Plan<TResult>`
	`800`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, TResult> : Plan<TResult>`
`801`	`801`	`{`
`802`	`802`	`internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13> Expression { get; }`
`803`	`803`
`@@ -883,7 +883,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`883`	`883`	`}`
`884`	`884`
`885`	`885`
`886`		`- internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, TResult> : Plan<TResult>`
	`886`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, TResult> : Plan<TResult>`
`887`	`887`	`{`
`888`	`888`	`internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14> Expression { get; }`
`889`	`889`
`@@ -975,7 +975,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`975`	`975`	`}`
`976`	`976`	`}`
`977`	`977`
`978`		`- internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, TResult> : Plan<TResult>`
	`978`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, TResult> : Plan<TResult>`
`979`	`979`	`{`
`980`	`980`	`internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15> Expression { get; }`
`981`	`981`
`@@ -1069,7 +1069,7 @@ internal override ActivePlan Activate(Dictionary<object, IJoinObserver> external`
`1069`	`1069`	`return activePlan;`
`1070`	`1070`	`}`
`1071`	`1071`	`}`
`1072`		`- internal class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, TResult> : Plan<TResult>`
	`1072`	`+ internal sealed class Plan<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, TResult> : Plan<TResult>`
`1073`	`1073`	`{`
`1074`	`1074`	`internal Pattern<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16> Expression { get; }`
`1075`	`1075`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ namespace System.Reactive.Subjects`
`11`	`11`	`/// </summary>`
`12`	`12`	`/// <typeparam name="TSource">The type of the elements in the source sequence.</typeparam>`
`13`	`13`	`/// <typeparam name="TResult">The type of the elements in the resulting sequence, after transformation through the subject.</typeparam>`
`14`		`- internal class ConnectableObservable<TSource, TResult> : IConnectableObservable<TResult>`
	`14`	`+ internal sealed class ConnectableObservable<TSource, TResult> : IConnectableObservable<TResult>`
`15`	`15`	`{`
`16`	`16`	`private readonly ISubject<TSource, TResult> _subject;`
`17`	`17`	`private readonly IObservable<TSource> _source;`