Skip to content

Commit d233998

Browse files
committed
extracted binding id calculation into separate variable
1 parent 56f9cd7 commit d233998

File tree

1 file changed

+19
-9
lines changed

1 file changed

+19
-9
lines changed

src/Controls/tests/BindingSourceGen.UnitTests/IntegrationTests.cs

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ public void GenerateSimpleBinding()
1414
""";
1515

1616
var result = SourceGenHelpers.Run(source);
17+
var id = Math.Abs(result.Binding!.Location.GetHashCode());
18+
1719
AssertExtensions.AssertNoDiagnostics(result);
1820
AssertExtensions.CodeIsEqual(
1921
$$"""
@@ -39,7 +41,7 @@ internal static partial class GeneratedBindableObjectExtensions
3941
4042
{{BindingCodeWriter.GeneratedCodeAttribute}}
4143
[InterceptsLocationAttribute(@"Path\To\Program.cs", 3, 7)]
42-
public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
44+
public static void SetBinding{{id}}(
4345
this BindableObject bindableObject,
4446
BindableProperty bindableProperty,
4547
Func<string, int> getter,
@@ -107,6 +109,7 @@ public class B
107109
""";
108110

109111
var result = SourceGenHelpers.Run(source);
112+
var id = Math.Abs(result.Binding!.Location.GetHashCode());
110113
AssertExtensions.AssertNoDiagnostics(result);
111114
AssertExtensions.CodeIsEqual(
112115
$$"""
@@ -132,7 +135,7 @@ internal static partial class GeneratedBindableObjectExtensions
132135
133136
{{BindingCodeWriter.GeneratedCodeAttribute}}
134137
[InterceptsLocationAttribute(@"Path\To\Program.cs", 6, 7)]
135-
public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
138+
public static void SetBinding{{id}}(
136139
this BindableObject bindableObject,
137140
BindableProperty bindableProperty,
138141
Func<global::MyNamespace.A?, int> getter,
@@ -209,6 +212,7 @@ public class B
209212
""";
210213

211214
var result = SourceGenHelpers.Run(source);
215+
var id = Math.Abs(result.Binding!.Location.GetHashCode());
212216
AssertExtensions.AssertNoDiagnostics(result);
213217
AssertExtensions.CodeIsEqual(
214218
$$"""
@@ -234,7 +238,7 @@ internal static partial class GeneratedBindableObjectExtensions
234238
235239
{{BindingCodeWriter.GeneratedCodeAttribute}}
236240
[InterceptsLocationAttribute(@"Path\To\Program.cs", 7, 7)]
237-
public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
241+
public static void SetBinding{{id}}(
238242
this BindableObject bindableObject,
239243
BindableProperty bindableProperty,
240244
Func<global::MyNamespace.A?, int> getter,
@@ -416,6 +420,7 @@ public class C
416420
public void GenerateSimpleBindingWhenNullableDisabledAndPropertyNullable(string source)
417421
{
418422
var result = SourceGenHelpers.Run(source);
423+
var id = Math.Abs(result.Binding!.Location.GetHashCode());
419424
AssertExtensions.AssertNoDiagnostics(result);
420425
AssertExtensions.CodeIsEqual(
421426
$$"""
@@ -441,7 +446,7 @@ internal static partial class GeneratedBindableObjectExtensions
441446
442447
{{BindingCodeWriter.GeneratedCodeAttribute}}
443448
[InterceptsLocationAttribute(@"Path\To\Program.cs", 7, 7)]
444-
public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
449+
public static void SetBinding{{id}}(
445450
this BindableObject bindableObject,
446451
BindableProperty bindableProperty,
447452
Func<global::MyNamespace.A?, global::MyNamespace.C?> getter,
@@ -532,6 +537,7 @@ public class D {
532537
""";
533538

534539
var result = SourceGenHelpers.Run(source);
540+
var id = Math.Abs(result.Binding!.Location.GetHashCode());
535541
AssertExtensions.AssertNoDiagnostics(result);
536542
AssertExtensions.CodeIsEqual(
537543
$$"""
@@ -557,7 +563,7 @@ internal static partial class GeneratedBindableObjectExtensions
557563
558564
{{BindingCodeWriter.GeneratedCodeAttribute}}
559565
[InterceptsLocationAttribute(@"Path\To\Program.cs", 7, 7)]
560-
public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
566+
public static void SetBinding{{id}}(
561567
this BindableObject bindableObject,
562568
BindableProperty bindableProperty,
563569
Func<global::MyNamespace.A?, global::MyNamespace.D?> getter,
@@ -648,6 +654,7 @@ public class MyPropertyClass
648654
""";
649655

650656
var result = SourceGenHelpers.Run(source);
657+
var id = Math.Abs(result.Binding!.Location.GetHashCode());
651658

652659
AssertExtensions.AssertNoDiagnostics(result);
653660
AssertExtensions.CodeIsEqual(
@@ -674,7 +681,7 @@ internal static partial class GeneratedBindableObjectExtensions
674681
675682
{{BindingCodeWriter.GeneratedCodeAttribute}}
676683
[InterceptsLocationAttribute(@"Path\To\Program.cs", 4, 7)]
677-
public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
684+
public static void SetBinding{{id}}(
678685
this BindableObject bindableObject,
679686
BindableProperty bindableProperty,
680687
Func<global::MyNamespace.MySourceClass, global::MyNamespace.MyPropertyClass?> getter,
@@ -770,6 +777,7 @@ public class MyPropertyClass
770777
""";
771778

772779
var result = SourceGenHelpers.Run(source);
780+
var id = Math.Abs(result.Binding!.Location.GetHashCode());
773781

774782
AssertExtensions.AssertNoDiagnostics(result);
775783
AssertExtensions.CodeIsEqual(
@@ -796,7 +804,7 @@ internal static partial class GeneratedBindableObjectExtensions
796804
797805
{{BindingCodeWriter.GeneratedCodeAttribute}}
798806
[InterceptsLocationAttribute(@"Path\To\Program.cs", 4, 7)]
799-
public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
807+
public static void SetBinding{{id}}(
800808
this BindableObject bindableObject,
801809
BindableProperty bindableProperty,
802810
Func<global::MyNamespace.MySourceClass, global::MyNamespace.MyPropertyClass> getter,
@@ -879,6 +887,7 @@ public class Wrapper
879887
""";
880888

881889
var result = SourceGenHelpers.Run(source);
890+
var id = Math.Abs(result.Binding!.Location.GetHashCode());
882891

883892
AssertExtensions.AssertNoDiagnostics(result);
884893
AssertExtensions.CodeIsEqual(
@@ -904,7 +913,7 @@ internal static partial class GeneratedBindableObjectExtensions
904913
{
905914
{{BindingCodeWriter.GeneratedCodeAttribute}}
906915
[InterceptsLocationAttribute(@"Path\To\Program.cs", 3, 7)]
907-
public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
916+
public static void SetBinding{{id}}(
908917
this BindableObject bindableObject,
909918
BindableProperty bindableProperty,
910919
Func<global::MyNamespace.A, int> getter,
@@ -984,6 +993,7 @@ public class MyPropertyClass
984993
""";
985994

986995
var result = SourceGenHelpers.Run(source);
996+
var id = Math.Abs(result.Binding!.Location.GetHashCode());
987997

988998
AssertExtensions.AssertNoDiagnostics(result);
989999
AssertExtensions.CodeIsEqual(
@@ -1010,7 +1020,7 @@ internal static partial class GeneratedBindableObjectExtensions
10101020
10111021
{{BindingCodeWriter.GeneratedCodeAttribute}}
10121022
[InterceptsLocationAttribute(@"Path\To\Program.cs", 6, 7)]
1013-
public static void SetBinding{{Math.Abs(result.Binding!.Location.GetHashCode())}}(
1023+
public static void SetBinding{{id}}(
10141024
this BindableObject bindableObject,
10151025
BindableProperty bindableProperty,
10161026
Func<global::MyNamespace.MySourceClass, global::MyNamespace.MyPropertyClass?> getter,

0 commit comments

Comments
 (0)