[Testing] Enabling some UITests from Issues folder in Appium-1 (#27036)

LogishaSelvarajSF4525 · web-flow · commit 2478901a5b74 · 2025-01-11T21:37:57.000+01:00
* remove FailsOnIOS attributes

* removed fails attributes in 11 issues

* revert changes in issue10563

* modified changes

* modified

* update issue18623
diff --git a/src/Controls/tests/TestCases.HostApp/Issues/Issue1683.cs b/src/Controls/tests/TestCases.HostApp/Issues/Issue1683.cs
@@ -151,6 +151,8 @@ protected override void Init()
 			StackLayout content = new StackLayout();
 			content.Children.Add(new ScrollView()
 			{
+				//Set the ScrollView height to adjust its layout to ensure the Rotate button remains visible on Android.
+				HeightRequest=600,
 				Content = layout
 			});
 
diff --git a/src/Controls/tests/TestCases.HostApp/Issues/Issue1700.cs b/src/Controls/tests/TestCases.HostApp/Issues/Issue1700.cs
@@ -9,15 +9,21 @@ public class Issue1700 : TestContentPage
 		protected override void Init()
 		{
 			var stack = new StackLayout();
-			var url = "https://github.com/xamarin/Xamarin.Forms/raw/main/Microsoft.Maui.Controls.ControlGallery.Android/Resources/drawable/Legumes.jpg?a=bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb";
-			var url2 = "https://github.com/xamarin/Xamarin.Forms/raw/main/Microsoft.Maui.Controls.ControlGallery.Android/Resources/drawable/Vegetables.jpg?a=bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbasdasdasdasdasasdasdasdasdasd";
+			var url = "https://github.com/dotnet/maui/raw/main/src/Compatibility/ControlGallery/src/Android/Resources/drawable/Legumes.jpg?a=bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb";
+			var url2 = "https://github.com/dotnet/maui/raw/main/src/Compatibility/ControlGallery/src/Android/Resources/drawable/Vegetables.jpg?a=bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbasdasdasdasdasasdasdasdasdasd";
 			var img = new Image
 			{
+				AutomationId="Legumes",
+				HeightRequest= 100,
+				WidthRequest= 100,
 				Source = new UriImageSource { Uri = new Uri(url) }
 			};
 			stack.Children.Add(img);
 			var img2 = new Image
 			{
+				AutomationId="Vegetables",
+				HeightRequest= 100,
+				WidthRequest= 100,
 				Source = new UriImageSource { Uri = new Uri(url2) }
 			};
 			stack.Children.Add(img2);
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla38978.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla38978.cs
@@ -13,7 +13,6 @@ public Bugzilla38978(TestDevice testDevice) : base(testDevice)
 	public override string Issue => "Cell.ForceUpdateSize issues with row selection/deselection (ViewCell)";
 
 	[Test]
-	[FailsOnIOSWhenRunningOnXamarinUITest]
 	[Category(UITestCategories.ManualReview)]
 	public void Bugzilla38978Test()
 	{
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue11209.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue11209.cs
@@ -19,7 +19,6 @@ public Issue11209(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.SwipeView)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
 		public void TapSwipeViewAndNavigateTest()
 		{
 			App.WaitForElement(SwipeViewContent);
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1146.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1146.cs
@@ -15,13 +15,9 @@ public Issue1146(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.Switch)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnAndroidWhenRunningOnXamarinUITest]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		public void TestSwitchDisable()
 		{
 			App.WaitForElement("switch");
-			App.Screenshot();
 		}
 	}
 }
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue12153.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue12153.cs
@@ -15,8 +15,6 @@ public Issue12153(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.Label)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		public void InvalidFontDoesntCauseAppToCrash()
 		{
 			App.WaitForElement("Success");
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1590.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1590.cs
@@ -15,12 +15,9 @@ public Issue1590(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.ListView)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
-		[FailsOnWindowsWhenRunningOnXamarinUITest]
 		public void ListViewIsGroupingEnabledDoesNotCrash()
 		{
-			App.WaitForNoElement("First");
+			App.WaitForElement("First");
 		}
 	}
 }
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1601.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1601.cs
@@ -15,16 +15,11 @@ public Issue1601(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.Layout)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
-		[FailsOnWindowsWhenRunningOnXamarinUITest]
 		public void Issue1601Test()
 		{
-			App.Screenshot("Start G1601");
 			App.WaitForElement("CrashButton");
-			App.Screenshot("I see the button");
 			App.Tap("CrashButton");
-			App.Screenshot("Didn't crash!");
+			App.WaitForNoElement("CrashButton");
 		}
 	}
 }
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1667.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1667.cs
@@ -16,8 +16,6 @@ public Issue1667(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.Entry)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		public void TestCursorPositionAndSelection()
 		{
 			App.WaitForElement("CursorTextEntry");
@@ -28,13 +26,14 @@ public void TestCursorPositionAndSelection()
 			App.EnterText("SelectionLength", "3");
 			App.DismissKeyboard();
 			App.Tap("Update");
-			App.Screenshot("Text selection from char 2 length 3.");
-
 			App.Tap("CursorTextEntry");
 			var result = App.WaitForElement("SelectionLength").GetText();
-			ClassicAssert.AreEqual("0", result);
+			Assert.That(result, Is.EqualTo("0"));
 		}
 
+// This test is iOS-specific due to platform-specific cursor color setting in the sample.
+		// Note: Visual validation of cursor color is required as automation is challenging
+		// due to cursor blinking, which prevents reliable image comparison.
 		[Test]
 		[Category(UITestCategories.Entry)]
 		[FailsOnAllPlatformsWhenRunningOnXamarinUITest]
@@ -53,5 +52,6 @@ public void TestCursorColorOniOS()
 			App.Tap("CursorTextEntry");
 			App.Screenshot("Cursor is default color.");
 		}
+
 	}
 }
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1683.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1683.cs
@@ -15,9 +15,6 @@ public Issue1683(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.Entry)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnAndroidWhenRunningOnXamarinUITest]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		public void Issue1683Test()
 		{
 			App.WaitForElement("Rotation");
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1700.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1700.cs
@@ -18,15 +18,13 @@ public Issue1700(TestDevice testDevice) : base(testDevice)
 	[Test]
 	[Category(UITestCategories.Image)]
 	[Category(UITestCategories.Compatibility)]
-	[FailsOnIOSWhenRunningOnXamarinUITest]
-	[FailsOnMacWhenRunningOnXamarinUITest]
-	[FailsOnWindowsWhenRunningOnXamarinUITest]
 	public void LongImageURLsShouldNotCrash()
 	{
 		// Give the images some time to load (or fail)
 		Task.Delay(3000).Wait();
-
+		App.WaitForElement("Legumes");
+		App.WaitForElement("Vegetables");
 		// If we can see this label at all, it means we didn't crash and the test is successful
-		App.WaitForNoElement(Success);
+		App.WaitForElement(Success);
 	}
 }
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1747.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1747.cs
@@ -19,9 +19,6 @@ public Issue1747(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.Switch)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnAndroidWhenRunningOnXamarinUITest]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		public void Issue1747Test()
 		{
 			App.WaitForElement(ToggleButtonAutomationId);
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1799.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1799.cs
@@ -19,7 +19,6 @@ public Issue1799(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.ListView)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
 		public void ListViewWithoutDataDoesNotCrash()
 		{
 			var result = App.WaitForElement(ListView);
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1851.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1851.cs
@@ -15,15 +15,13 @@ public Issue1851(TestDevice testDevice) : base(testDevice)
 	[Test]
 	[Category(UITestCategories.ListView)]
 	[Category(UITestCategories.Compatibility)]
-	[FailsOnIOSWhenRunningOnXamarinUITest]
-	[FailsOnMacWhenRunningOnXamarinUITest]
-	[FailsOnWindowsWhenRunningOnXamarinUITest]
 	public void Issue1851Test()
 	{
 		App.WaitForElement("btn");
+		App.WaitForElement("number");
 		App.Tap("btn");
-		App.WaitForElement("btn");
+		App.WaitForNoElement("number");
 		App.Tap("btn");
-		App.WaitForElement("btn");
+		App.WaitForElement("number");
 	}
 }
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18623.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18623.cs
@@ -1,3 +1,6 @@
+#if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST 
+// On MacCatalyst, pressing the ESC key during screenshot capture clears the text. This causes the image generated in CI to differ from local runs.
+//In IOS App.EnterText not working with iOS password for more information : https://github.com/dotnet/maui/issues/18981
 using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
@@ -15,7 +18,6 @@ public Issue18623(TestDevice device) : base(device)
 		[Test]
 		[Category(UITestCategories.Entry)]
 		[FailsOnIOSWhenRunningOnXamarinUITest("Currently fails on iOS; see https://github.com/dotnet/maui/issues/18981")]
-		[FailsOnMacWhenRunningOnXamarinUITest("VerifyScreenshot method not implemented on macOS")]
 		public async Task EntryIsPasswordObscureText()
 		{
 			App.WaitForElement("WaitForStubControl");
@@ -35,3 +37,4 @@ public async Task EntryIsPasswordObscureText()
 		}
 	}
 }
+#endif

Original file line number	Diff line number	Diff line change
`@@ -151,6 +151,8 @@ protected override void Init()`
`151`	`151`	`StackLayout content = new StackLayout();`
`152`	`152`	`content.Children.Add(new ScrollView()`
`153`	`153`	`{`
	`154`	`+ //Set the ScrollView height to adjust its layout to ensure the Rotate button remains visible on Android.`
	`155`	`+ HeightRequest=600,`
`154`	`156`	`Content = layout`
`155`	`157`	`});`
`156`	`158`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,6 @@ public Bugzilla38978(TestDevice testDevice) : base(testDevice)`
`13`	`13`	`public override string Issue => "Cell.ForceUpdateSize issues with row selection/deselection (ViewCell)";`
`14`	`14`
`15`	`15`	`[Test]`
`16`		`- [FailsOnIOSWhenRunningOnXamarinUITest]`
`17`	`16`	`[Category(UITestCategories.ManualReview)]`
`18`	`17`	`public void Bugzilla38978Test()`
`19`	`18`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ public Issue11209(TestDevice testDevice) : base(testDevice)`
`19`	`19`	`[Test]`
`20`	`20`	`[Category(UITestCategories.SwipeView)]`
`21`	`21`	`[Category(UITestCategories.Compatibility)]`
`22`		`- [FailsOnIOSWhenRunningOnXamarinUITest]`
`23`	`22`	`public void TapSwipeViewAndNavigateTest()`
`24`	`23`	`{`
`25`	`24`	`App.WaitForElement(SwipeViewContent);`
Original file line number	Diff line number	Diff line change
`@@ -15,13 +15,9 @@ public Issue1146(TestDevice testDevice) : base(testDevice)`
`15`	`15`	`[Test]`
`16`	`16`	`[Category(UITestCategories.Switch)]`
`17`	`17`	`[Category(UITestCategories.Compatibility)]`
`18`		`- [FailsOnAndroidWhenRunningOnXamarinUITest]`
`19`		`- [FailsOnIOSWhenRunningOnXamarinUITest]`
`20`		`- [FailsOnMacWhenRunningOnXamarinUITest]`
`21`	`18`	`public void TestSwitchDisable()`
`22`	`19`	`{`
`23`	`20`	`App.WaitForElement("switch");`
`24`		`- App.Screenshot();`
`25`	`21`	`}`
`26`	`22`	`}`
`27`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,6 @@ public Issue12153(TestDevice testDevice) : base(testDevice)`
`15`	`15`	`[Test]`
`16`	`16`	`[Category(UITestCategories.Label)]`
`17`	`17`	`[Category(UITestCategories.Compatibility)]`
`18`		`- [FailsOnIOSWhenRunningOnXamarinUITest]`
`19`		`- [FailsOnMacWhenRunningOnXamarinUITest]`
`20`	`18`	`public void InvalidFontDoesntCauseAppToCrash()`
`21`	`19`	`{`
`22`	`20`	`App.WaitForElement("Success");`
Original file line number	Diff line number	Diff line change
`@@ -15,12 +15,9 @@ public Issue1590(TestDevice testDevice) : base(testDevice)`
`15`	`15`	`[Test]`
`16`	`16`	`[Category(UITestCategories.ListView)]`
`17`	`17`	`[Category(UITestCategories.Compatibility)]`
`18`		`- [FailsOnIOSWhenRunningOnXamarinUITest]`
`19`		`- [FailsOnMacWhenRunningOnXamarinUITest]`
`20`		`- [FailsOnWindowsWhenRunningOnXamarinUITest]`
`21`	`18`	`public void ListViewIsGroupingEnabledDoesNotCrash()`
`22`	`19`	`{`
`23`		`- App.WaitForNoElement("First");`
	`20`	`+ App.WaitForElement("First");`
`24`	`21`	`}`
`25`	`22`	`}`
`26`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,16 +15,11 @@ public Issue1601(TestDevice testDevice) : base(testDevice)`
`15`	`15`	`[Test]`
`16`	`16`	`[Category(UITestCategories.Layout)]`
`17`	`17`	`[Category(UITestCategories.Compatibility)]`
`18`		`- [FailsOnIOSWhenRunningOnXamarinUITest]`
`19`		`- [FailsOnMacWhenRunningOnXamarinUITest]`
`20`		`- [FailsOnWindowsWhenRunningOnXamarinUITest]`
`21`	`18`	`public void Issue1601Test()`
`22`	`19`	`{`
`23`		`- App.Screenshot("Start G1601");`
`24`	`20`	`App.WaitForElement("CrashButton");`
`25`		`- App.Screenshot("I see the button");`
`26`	`21`	`App.Tap("CrashButton");`
`27`		`- App.Screenshot("Didn't crash!");`
	`22`	`+ App.WaitForNoElement("CrashButton");`
`28`	`23`	`}`
`29`	`24`	`}`
`30`	`25`	`}`