Re-enabled flaky UI test TextInEditorShouldScroll (#29167)

* Fixed flaky editor test

* Added scroll down again to double check

* Optimized code changes and added new test snapshots

* Added missing WinUI snap

Author: NirmalKumarYuvaraj

src/Controls/tests/TestCases.Android.Tests/snapshots/android/TextInEditorShouldScroll.png

@@ -0,0 +1,80 @@
+#if MACCATALYST
+using UIKit;
+using Microsoft.Maui.Platform;
+#endif
+
+namespace Maui.Controls.Sample.Issues;
+
+[Issue(IssueTracker.Github, 19500, "[iOS] Editor is not be able to scroll if IsReadOnly is true", PlatformAffected.iOS)]
+public partial class Issue19500 : TestContentPage
+{
+	const string BaseEditorText = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nulla porttitor mauris non ornare ultrices. Ut semper ultrices justo eget semper.Ut imperdiet dolor ut vestibulum molestie. Duis a libero ex. Etiam mi urna, lobortis sed tincidunt in, tempus eget magna. Aenean quis malesuada eros. Phasellus felis eros, condimentum et tortor sed, condimentum convallis turpis. Sed in varius metus, at auctor orci. Maecenas luctus nibh nibh, nec aliquam est fermentum in. Etiam consectetur lectus erat, sed placerat sapien rutrum eu. Suspendisse tincidunt fermentum tempor.Maecenas egestas neque nec lacinia fringilla.";
+
+	protected override void Init()
+	{
+		var rootLayout = new VerticalStackLayout
+		{
+			Spacing = 10,
+			Padding = 10
+		};
+
+		var descriptionLabel = CreateLabel(
+				"This test case is to verify that the Editor is scrollable when IsReadOnly is set to true.",
+				"descriptionLabel");
+
+		var yPositionLabel = CreateLabel("0", "yPositionLabel");
+
+		var editor = CreateEditor(yPositionLabel);
+
+		rootLayout.Children.Add(descriptionLabel);
+		rootLayout.Children.Add(editor);
+		rootLayout.Children.Add(yPositionLabel);
+
+		Content = rootLayout;
+	}
+
+	Label CreateLabel(string text, string automationId) =>
+		new Label
+		{
+			Text = text,
+			AutomationId = automationId
+		};
+
+	Editor CreateEditor(Label yPositionLabel)
+	{
+		var editor = new Editor
+		{
+			HeightRequest = 100,
+			IsReadOnly = true,
+			AutomationId = "editor",
+			Text = GetEditorText()
+		};
+
+#if MACCATALYST
+		editor.HandlerChanged += (_, _) =>
+		{
+			if (editor.Handler?.PlatformView is MauiTextView mauiTextView)
+			{
+				mauiTextView.Scrolled += (s, e) =>
+				{
+					if (s is UIScrollView scrollView)
+					{
+						yPositionLabel.Text = scrollView.ContentOffset.Y.ToString();
+					}
+				};
+			}
+		};
+#endif
+
+		return editor;
+	}
+
+	private string GetEditorText()
+	{
+#if MACCATALYST
+		return BaseEditorText + " " + BaseEditorText;
+#else
+		return BaseEditorText;
+#endif
+	}
+}

src/Controls/tests/TestCases.HostApp/Issues/Issue19500.cs

@@ -1,29 +1,31 @@
-#if TEST_FAILS_ON_CATALYST // Since this test verifies the scrolling behavior in the editor control and the App.ScrollDown function is inconsistent, relying on screenshot verification causes flakiness in CI. It needs to be validated using an alternative approach, or else it would be better to consider this for manual testing.
-// Issue for reenable: https://github.com/dotnet/maui/issues/29025
 using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
 
-namespace Microsoft.Maui.TestCases.Tests.Issues
+namespace Microsoft.Maui.TestCases.Tests.Issues;
+public class Issue19500 : _IssuesUITest
 {
-	public class Issue19500 : _IssuesUITest
-	{
-		public override string Issue => "[iOS] Editor is not be able to scroll if IsReadOnly is true";
+	public override string Issue => "[iOS] Editor is not be able to scroll if IsReadOnly is true";
 
-		public Issue19500(TestDevice device) : base(device)
-		{
-		}
+	const string yPositionLabel = "yPositionLabel";
 
-		[Test]
-		[Category(UITestCategories.Editor)]
-		public void TextInEditorShouldScroll()
-		{
-			_ = App.WaitForElement("editor");
-			App.ScrollDown("editor");
+	public Issue19500(TestDevice device) : base(device)
+	{
+	}
 
-			// The test passes if the text inside the editor scrolls down
-			VerifyScreenshot();
-		}
+	[Test]
+	[Category(UITestCategories.Editor)]
+	public void TextInEditorShouldScroll()
+	{
+		var yPosLabel = App.WaitForElement(yPositionLabel);
+		App.ScrollDown("editor");
+#if MACCATALYST
+		App.ScrollDown("editor"); // To make sure the editor is scrolled down
+		var yPos = yPosLabel.GetText();
+		Assert.That(yPos,Is.GreaterThan("0")); // The Y position should be greater than 0 after scrolling down
+#else
+		// The test passes if the text inside the editor scrolls down
+		VerifyScreenshot();
+#endif
 	}
-}
-#endif
+}