Implement stored procedure update mapping (#28553)

* Remove transaction suppression metadata

* Implement stored procedure update mapping

Closes #245
Closes #28435

Co-authored-by: Andriy Svyryd <[email protected]>

Co-authored-by: Andriy Svyryd <[email protected]>

Author: roji

src/EFCore.Relational/Design/Internal/RelationalCSharpRuntimeAnnotationCodeGenerator.cs

@@ -491,8 +491,7 @@ private void Create(IStoredProcedure storedProcedure, string sprocVariable, CSha
             .Append(parameters.TargetName).AppendLine(",")
             .Append(code.Literal(storedProcedure.Name)).AppendLine(",")
             .Append(code.Literal(storedProcedure.Schema)).AppendLine(",")
-            .Append(code.Literal(storedProcedure.IsRowsAffectedReturned)).AppendLine(",")
-            .Append(code.Literal(storedProcedure.AreTransactionsSuppressed))
+            .Append(code.Literal(storedProcedure.IsRowsAffectedReturned))
             .AppendLine(");")
             .DecrementIndent()
             .AppendLine();

src/EFCore.Relational/Extensions/RelationalPropertyExtensions.cs

@@ -1153,7 +1153,7 @@ private static bool IsOptionalSharingDependent(
 
         return optional ?? (entityType.BaseType != null && entityType.FindDiscriminatorProperty() != null);
     }
-    
+
     /// <summary>
     ///     Returns the comment for the column this property is mapped to.
     /// </summary>

src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs

@@ -361,6 +361,16 @@ private static void ValidateSproc(IStoredProcedure sproc, string mappingStrategy
             _ => new Dictionary<string, IProperty>()
         };
 
+        if (mappingStrategy == RelationalAnnotationNames.TptMappingStrategy
+            && storeObjectIdentifier.StoreObjectType == StoreObjectType.InsertStoredProcedure
+            && entityType.BaseType?.GetInsertStoredProcedure() != null)
+        {
+            foreach (var property in primaryKey.Properties)
+            {
+                storeGeneratedProperties.Remove(property.Name);
+            }
+        }
+
         var resultColumnNames = new HashSet<string>();
         foreach (var resultColumn in sproc.ResultColumns)
         {

src/EFCore.Relational/Metadata/Builders/IConventionStoredProcedureBuilder.cs

@@ -156,20 +156,4 @@ public interface IConventionStoredProcedureBuilder : IConventionAnnotatableBuild
     /// <param name="fromDataAnnotation">Indicates whether the configuration was specified using a data annotation.</param>
     /// <returns><see langword="true" /> if the column of the result can be used for the stored procedure.</returns>
     bool CanHaveRowsAffectedResultColumn(string propertyName, bool fromDataAnnotation = false);
-
-    /// <summary>
-    ///     Prevents automatically creating a transaction when executing this stored procedure.
-    /// </summary>
-    /// <param name="suppress">A value indicating whether the automatic transactions should be prevented.</param>
-    /// <param name="fromDataAnnotation">Indicates whether the configuration was specified using a data annotation.</param>
-    /// <returns>The same builder instance so that multiple configuration calls can be chained.</returns>
-    IConventionStoredProcedureBuilder? SuppressTransactions(bool suppress, bool fromDataAnnotation = false);
-
-    /// <summary>
-    ///     Returns a value indicating whether the transaction suppression can be set for stored procedure.
-    /// </summary>
-    /// <param name="suppress">A value indicating whether the automatic transactions should be prevented.</param>
-    /// <param name="fromDataAnnotation">Indicates whether the configuration was specified using a data annotation.</param>
-    /// <returns><see langword="true" /> if the column of the result can be used for the stored procedure.</returns>
-    bool CanSetSuppressTransactions(bool suppress, bool fromDataAnnotation = false);
 }

src/EFCore.Relational/Metadata/Builders/OwnedNavigationStoredProcedureBuilder.cs

@@ -219,17 +219,6 @@ public virtual OwnedNavigationStoredProcedureBuilder HasRowsAffectedReturnValue(
         return this;
     }
 
-    /// <summary>
-    ///     Prevents automatically creating a transaction when executing this stored procedure.
-    /// </summary>
-    /// <param name="suppress">A value indicating whether the automatic transactions should be prevented.</param>
-    /// <returns>The same builder instance so that multiple configuration calls can be chained.</returns>
-    public virtual OwnedNavigationStoredProcedureBuilder SuppressTransactions(bool suppress = true)
-    {
-        Builder.SuppressTransactions(suppress, ConfigurationSource.Explicit);
-        return this;
-    }
-
     /// <summary>
     ///     Adds or updates an annotation on the stored procedure. If an annotation with the key specified in
     ///     <paramref name="annotation" /> already exists, its value will be updated.

src/EFCore.Relational/Metadata/Builders/OwnedNavigationStoredProcedureBuilder``.cs

@@ -231,14 +231,6 @@ public virtual OwnedNavigationStoredProcedureBuilder<TOwnerEntity, TDependentEnt
     public new virtual OwnedNavigationStoredProcedureBuilder<TOwnerEntity, TDependentEntity> HasRowsAffectedReturnValue(bool rowsAffectedReturned = true)
         => (OwnedNavigationStoredProcedureBuilder<TOwnerEntity, TDependentEntity>)base.HasRowsAffectedReturnValue(rowsAffectedReturned);
 
-    /// <summary>
-    ///     Prevents automatically creating a transaction when executing this stored procedure.
-    /// </summary>
-    /// <param name="suppress">A value indicating whether the automatic transactions should be prevented.</param>
-    /// <returns>The same builder instance so that multiple configuration calls can be chained.</returns>
-    public new virtual OwnedNavigationStoredProcedureBuilder<TOwnerEntity, TDependentEntity> SuppressTransactions(bool suppress = true)
-        => (OwnedNavigationStoredProcedureBuilder<TOwnerEntity, TDependentEntity>)base.SuppressTransactions(suppress);
-
     /// <summary>
     ///     Adds or updates an annotation on the stored procedure. If an annotation with the key specified in
     ///     <paramref name="annotation" /> already exists, its value will be updated.

src/EFCore.Relational/Metadata/Builders/StoredProcedureBuilder.cs

@@ -182,17 +182,6 @@ public virtual StoredProcedureBuilder HasRowsAffectedReturnValue(bool rowsAffect
         return this;
     }
 
-    /// <summary>
-    ///     Prevents automatically creating a transaction when executing this stored procedure.
-    /// </summary>
-    /// <param name="suppress">A value indicating whether the automatic transactions should be prevented.</param>
-    /// <returns>The same builder instance so that multiple configuration calls can be chained.</returns>
-    public virtual StoredProcedureBuilder SuppressTransactions(bool suppress = true)
-    {
-        Builder.SuppressTransactions(suppress, ConfigurationSource.Explicit);
-        return this;
-    }
-    
     /// <summary>
     ///     Adds or updates an annotation on the stored procedure. If an annotation with the key specified in
     ///     <paramref name="annotation" /> already exists, its value will be updated.

src/EFCore.Relational/Metadata/Builders/StoredProcedureBuilder`.cs

@@ -314,14 +314,6 @@ public virtual StoredProcedureBuilder<TEntity> HasResultColumn<TDerivedEntity, T
     public new virtual StoredProcedureBuilder<TEntity> HasRowsAffectedReturnValue(bool rowsAffectedReturned = true)
         => (StoredProcedureBuilder<TEntity>)base.HasRowsAffectedReturnValue(rowsAffectedReturned);
 
-    /// <summary>
-    ///     Prevents automatically creating a transaction when executing this stored procedure.
-    /// </summary>
-    /// <param name="suppress">A value indicating whether the automatic transactions should be prevented.</param>
-    /// <returns>The same builder instance so that multiple configuration calls can be chained.</returns>
-    public new virtual StoredProcedureBuilder<TEntity> SuppressTransactions(bool suppress = true)
-        => (StoredProcedureBuilder<TEntity>)base.SuppressTransactions(suppress);
-
     /// <summary>
     ///     Adds or updates an annotation on the stored procedure. If an annotation with the key specified in
     ///     <paramref name="annotation" /> already exists, its value will be updated.

src/EFCore.Relational/Metadata/Conventions/RelationalRuntimeModelConvention.cs

@@ -498,8 +498,7 @@ private RuntimeStoredProcedure Create(IStoredProcedure storedProcedure, RuntimeE
             runtimeEntityType,
             storedProcedure.Name,
             storedProcedure.Schema,
-            storedProcedure.IsRowsAffectedReturned,
-            storedProcedure.AreTransactionsSuppressed);
+            storedProcedure.IsRowsAffectedReturned);
 
         foreach (var parameter in storedProcedure.Parameters)
         {

src/EFCore.Relational/Metadata/IColumn.cs

@@ -147,14 +147,6 @@ bool TryGetDefaultValue(out object? defaultValue)
         => PropertyMappings.First().Property
             .GetCollation(StoreObjectIdentifier.Table(Table.Name, Table.Schema));
 
-    /// <summary>
-    ///     Gets the <see cref="ValueComparer" /> for this column.
-    /// </summary>
-    /// <returns>The comparer.</returns>
-    ValueComparer ProviderValueComparer
-        => PropertyMappings.First().Property
-            .GetProviderValueComparer();
-
     /// <summary>
     ///     Returns the property mapping for the given entity type.
     /// </summary>